Fix wrong iteration in ListGraph snapshot, part II. (#598)
1 /* -*- mode: C++; indent-tabs-mode: nil; -*-
3 * This file is a part of LEMON, a generic C++ optimization library.
5 * Copyright (C) 2003-2013
6 * Egervary Jeno Kombinatorikus Optimalizalasi Kutatocsoport
7 * (Egervary Research Group on Combinatorial Optimization, EGRES).
9 * Permission to use, modify and distribute this software is granted
10 * provided that this copyright notice appears in all copies. For
11 * precise terms see the accompanying LICENSE file.
13 * This software is provided "AS IS" with no warranty of any kind,
14 * express or implied, and with no claim as to its suitability for any
19 #include <lemon/concepts/digraph.h>
20 #include <lemon/smart_graph.h>
21 #include <lemon/list_graph.h>
22 #include <lemon/lgf_reader.h>
23 #include <lemon/bellman_ford.h>
24 #include <lemon/path.h>
26 #include "graph_test.h"
27 #include "test_tools.h"
29 using namespace lemon;
55 void checkBellmanFordCompile()
58 typedef concepts::Digraph Digraph;
59 typedef concepts::ReadMap<Digraph::Arc,Value> LengthMap;
60 typedef BellmanFord<Digraph, LengthMap> BF;
61 typedef Digraph::Node Node;
62 typedef Digraph::Arc Arc;
68 ::lemon::ignore_unused_variable_warning(l);
71 ::lemon::ignore_unused_variable_warning(b);
75 concepts::Path<Digraph> pp;
78 BF bf_test(gr,length);
79 const BF& const_bf_test = bf_test;
86 bf_test.addSource(s, 1);
87 b = bf_test.processNextRound();
88 b = bf_test.processNextWeakRound();
91 bf_test.checkedStart();
92 bf_test.limitedStart(k);
94 l = const_bf_test.dist(t);
95 e = const_bf_test.predArc(t);
96 s = const_bf_test.predNode(t);
97 b = const_bf_test.reached(t);
98 d = const_bf_test.distMap();
99 p = const_bf_test.predMap();
100 pp = const_bf_test.path(t);
101 pp = const_bf_test.negativeCycle();
103 for (BF::ActiveIt it(const_bf_test); it != INVALID; ++it) {}
106 BF::SetPredMap<concepts::ReadWriteMap<Node,Arc> >
107 ::SetDistMap<concepts::ReadWriteMap<Node,Value> >
108 ::SetOperationTraits<BellmanFordDefaultOperationTraits<Value> >
109 ::Create bf_test(gr,length);
111 LengthMap length_map;
112 concepts::ReadWriteMap<Node,Arc> pred_map;
113 concepts::ReadWriteMap<Node,Value> dist_map;
116 .lengthMap(length_map)
124 bf_test.addSource(s);
125 bf_test.addSource(s, 1);
126 b = bf_test.processNextRound();
127 b = bf_test.processNextWeakRound();
130 bf_test.checkedStart();
131 bf_test.limitedStart(k);
134 e = bf_test.predArc(t);
135 s = bf_test.predNode(t);
136 b = bf_test.reached(t);
137 pp = bf_test.path(t);
138 pp = bf_test.negativeCycle();
142 void checkBellmanFordFunctionCompile()
145 typedef concepts::Digraph Digraph;
146 typedef Digraph::Arc Arc;
147 typedef Digraph::Node Node;
148 typedef concepts::ReadMap<Digraph::Arc,Value> LengthMap;
152 ::lemon::ignore_unused_variable_warning(b);
154 bellmanFord(g,LengthMap()).run(Node());
155 b = bellmanFord(g,LengthMap()).run(Node(),Node());
156 bellmanFord(g,LengthMap())
157 .predMap(concepts::ReadWriteMap<Node,Arc>())
158 .distMap(concepts::ReadWriteMap<Node,Value>())
160 b=bellmanFord(g,LengthMap())
161 .predMap(concepts::ReadWriteMap<Node,Arc>())
162 .distMap(concepts::ReadWriteMap<Node,Value>())
163 .path(concepts::Path<Digraph>())
169 template <typename Digraph, typename Value>
170 void checkBellmanFord() {
171 TEMPLATE_DIGRAPH_TYPEDEFS(Digraph);
172 typedef typename Digraph::template ArcMap<Value> LengthMap;
176 LengthMap length(gr);
178 std::istringstream input(test_lgf);
179 digraphReader(gr, input).
180 arcMap("length", length).
185 BellmanFord<Digraph, LengthMap>
188 Path<Digraph> p = bf.path(t);
190 check(bf.reached(t) && bf.dist(t) == -1, "Bellman-Ford found a wrong path.");
191 check(p.length() == 3, "path() found a wrong path.");
192 check(checkPath(gr, p), "path() found a wrong path.");
193 check(pathSource(gr, p) == s, "path() found a wrong path.");
194 check(pathTarget(gr, p) == t, "path() found a wrong path.");
196 ListPath<Digraph> path;
198 bool reached = bellmanFord(gr,length).path(path).dist(dist).run(s,t);
200 check(reached && dist == -1, "Bellman-Ford found a wrong path.");
201 check(path.length() == 3, "path() found a wrong path.");
202 check(checkPath(gr, path), "path() found a wrong path.");
203 check(pathSource(gr, path) == s, "path() found a wrong path.");
204 check(pathTarget(gr, path) == t, "path() found a wrong path.");
206 for(ArcIt e(gr); e!=INVALID; ++e) {
209 check(!bf.reached(u) || (bf.dist(v) - bf.dist(u) <= length[e]),
210 "Wrong output. dist(target)-dist(source)-arc_length=" <<
211 bf.dist(v) - bf.dist(u) - length[e]);
214 for(NodeIt v(gr); v!=INVALID; ++v) {
216 check(v==s || bf.predArc(v)!=INVALID, "Wrong tree.");
217 if (bf.predArc(v)!=INVALID ) {
220 check(u==bf.predNode(v),"Wrong tree.");
221 check(bf.dist(v) - bf.dist(u) == length[e],
222 "Wrong distance! Difference: " <<
223 bf.dist(v) - bf.dist(u) - length[e]);
229 void checkBellmanFordNegativeCycle() {
230 DIGRAPH_TYPEDEFS(SmartDigraph);
233 IntArcMap length(gr);
235 Node n1 = gr.addNode();
236 Node n2 = gr.addNode();
237 Node n3 = gr.addNode();
238 Node n4 = gr.addNode();
240 Arc a1 = gr.addArc(n1, n2);
241 Arc a2 = gr.addArc(n2, n2);
247 BellmanFord<SmartDigraph, IntArcMap> bf(gr, length);
249 StaticPath<SmartDigraph> p = bf.negativeCycle();
250 check(p.length() == 1 && p.front() == p.back() && p.front() == a2,
251 "Wrong negative cycle.");
257 BellmanFord<SmartDigraph, IntArcMap> bf(gr, length);
259 check(bf.negativeCycle().empty(),
260 "Negative cycle should not be found.");
263 length[gr.addArc(n1, n3)] = 5;
264 length[gr.addArc(n4, n3)] = 1;
265 length[gr.addArc(n2, n4)] = 2;
266 length[gr.addArc(n3, n2)] = -4;
269 BellmanFord<SmartDigraph, IntArcMap> bf(gr, length);
272 for (int i = 0; i < 4; ++i) {
273 check(bf.negativeCycle().empty(),
274 "Negative cycle should not be found.");
275 bf.processNextRound();
277 StaticPath<SmartDigraph> p = bf.negativeCycle();
278 check(p.length() == 3, "Wrong negative cycle.");
279 check(length[p.nth(0)] + length[p.nth(1)] + length[p.nth(2)] == -1,
280 "Wrong negative cycle.");
285 checkBellmanFord<ListDigraph, int>();
286 checkBellmanFord<SmartDigraph, double>();
287 checkBellmanFordNegativeCycle();