[Lemon-user] Bug in list graph

[Pierre Moulon]

Hi,

Thank you to develop and share the Lemon graph library.

By curiosity I have ran the code analyzer from Visual Studio on the Lemon
library.

And it found some strange things in lemon/list_graph.hpp:

In all the ObserverProxy implementations we can see something like:
"
virtual void add(const std::vector<Node>& nodes) {
          for (int i = nodes.size() - 1; i >= 0; ++i) {
            snapshot.addNode(nodes[i]);
          }
        }
"
The increment step of the loop must be -- and not ++ !!

This error appears 18 times and must be fixed!

I'm using Lemon 1.3 and I have checked on the current mercurials files, the
error is still there in the trunk.

Regards/Cordialement,
Pierre M
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lemon.cs.elte.hu/pipermail/lemon-user/attachments/20150521/98b91065/attachment.html>