Custom Query (545 matches)

I am still trying to compile the base test file included in the tutorial and whenever I go about doing so I get an error with the floor and ceiling calls in the included lemon/math.h file. Specifically I am getting a long list of errors from cmath saying that for example, "error C2039: 'acosf' : is not a member of '`global namespace". Is there any quick solution to this? I am using lemon-1.3.

From lemon-users by Pierre M:

Hi,

Thank you to develop and share the Lemon graph library.

By curiosity I have ran the code analyzer from Visual Studio on the Lemon library.

And it found some strange things in lemon/list_graph.hpp:

In all the ObserverProxy implementations we can see something like:

virtual void add(const std::vector<Node>& nodes) {
          for (int i = nodes.size() - 1; i >= 0; ++i) {
            snapshot.addNode(nodes[i]);
          }
        }

The increment step of the loop must be -- and not ++ !!

This error appears 18 times and must be fixed!

I'm using Lemon 1.3 and I have checked on the current mercurials files, the error is still there in the trunk.

Regards/ Cordialement, Pierre M

Clang compiler version 5.0 reports tons of warnings of unused local typedefs. This renders the compilation unsuccessful in Maintainer mode.

We need a decision how to handle it.

• The majority of these warnings comes from the *GRAPH_TYPEDEFS macros.
  • One way to avoid would be to suppress them to apply some compiler specific #pragma statement, but I have no idea how to do it safely and compiler independently. Can anyone help me in doing this? Is it possible to do it locally only for these typedefs?
  • The other solution is to use the ignore_unused() templates. The attaches chgset [0f291d5010f6] does this, but it is painful, because ignore_unused() cannot (and need not) be used in the global scope. Therefore we need to versions of all of these macros, one with the warning suppression, and one without. This is far from being convenient.
• In addition, there are couple of standalone unused local typedefs, mainly in the test codes. What shall we do with them?
  • Use ignore_unused() for them?
  • Or delete them for they are unnecessary?
  • Or just comment them out and keep them for future reference?