Custom Query (545 matches)

Should we state in the graph structure concepts that node and arc/edge maps must be reference maps for all graph types?

It would make writing a general algorithm easier and more convenient since we would have to use set() functions instead of operator[] only for the "external" map types, and all the "internal" maps, which are created by the algorithm could be used as reference maps. Maybe it could also improve the efficiency in some cases, but it is not clear and wasn't tested.

The attached patch contains a bug fix for ConEdgeIt.

Since the erroneous code is in the 1.0 branch, too, I made the patch on the top of [62f9787c516c]. However the only example I found to indicate the error uses adaptors.

Here it is:

#include<lemon/list_graph.h>
#include<lemon/adaptors.h>
#include<test/graph_test.h>

using namespace lemon;

int main() {
  ListGraph graph;
  ListGraph::Node n1 = graph.addNode();
  ListGraph::Node n2 = graph.addNode();
  ListGraph::Node n3 = graph.addNode();
  graph.addEdge(n1,n2);
  graph.addEdge(n1,n3);
  graph.addEdge(n2,n3);
  
  checkGraphConEdgeList(undirector(graph), 6);

  return 0;
}

If you try to compile and run this code using [919878a41a60], it will fall into an infinite loop!