COIN-OR::LEMON - Graph Library

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#110 closed enhancement (fixed)

graphToEps() improvements

Reported by: Peter Kovacs Owned by: Alpar Juttner
Priority: major Milestone: LEMON 1.0 release
Component: core Version: hg main
Keywords: Cc:
Revision id:

Description

  1. The members of GraphToEps should be grouped in the documentation since there are so many functions. E.g. Node Options, Arc Options, Scaling etc.
  2. The GraphToEps::run() function should be revised. There are \todo commands recommending better epsilon and other improvements.
  3. The demo file graph_to_eps_demo.cc should also be revised. It does not conforms to #27.
    • It should read the graph and all the maps from an LGF file.
    • It would be nice, if it created only one EPS file using options that can be set with command line parameters. However it would be difficult since the graphToEps() function interface does not support incremental option setting as class interfaces do.

Attachments (2)

graph_to_eps_improvements.patch (21.7 KB) - added by Peter Kovacs 11 years ago.
Some improvements in the doc and in the demo file.
graph_to_eps_demo_fix_542dd614cbb4.patch (3.3 KB) - added by Peter Kovacs 11 years ago.

Download all attachments as: .zip

Change History (15)

Changed 11 years ago by Peter Kovacs

Some improvements in the doc and in the demo file.

comment:1 Changed 11 years ago by Peter Kovacs

I uploaded a patch with small improvements.

comment:2 Changed 11 years ago by Peter Kovacs

Version: hg main

comment:3 Changed 11 years ago by Peter Kovacs

About point 2. see also ticket #106.

comment:4 Changed 11 years ago by Peter Kovacs

Milestone: LEMON 1.0 releasePost 1.0

Other improvements are suggested in #76, #85, #86.

comment:5 in reply to:  1 ; Changed 11 years ago by Alpar Juttner

Replying to kpeter:

I uploaded a patch with small improvements.

Why did you remove the generation one of the example figures?

comment:6 in reply to:  5 ; Changed 11 years ago by Peter Kovacs

Replying to alpar:

Why did you remove the generation one of the example figures?

There are six examples now, and this one showed nothing new, nothing intresting compared to the others. So it seemed really unimportant, and I found it better to have not too many variants.

comment:7 in reply to:  6 Changed 11 years ago by Alpar Juttner

Milestone: Post 1.0LEMON 1.0 release

Replying to kpeter:

There are six examples now, and this one showed nothing new, nothing intresting compared to the others. So it seemed really unimportant, and I found it better to have not too many variants.

Well, we all differ. For me, six is not really less than seven, and I also like that now missing figure. Actually, it shows something interesting: is shows that the curve of an arc varies depending on if it has an arrowhead or not.

(I put back this ticket into the 1.0 milestone, because the attached patch not only improves the demo but also contains significant cleanups for the GraphToEps? class itself.)

comment:8 in reply to:  1 Changed 11 years ago by Alpar Juttner

Replying to kpeter:

I uploaded a patch with small improvements.

I pushed a slightly modified version into the main branch (see [4e22275a2b52]). Namely, I made two modifications:

  • The usage of 'a' for the Arcs became more consistent
  • The seventh figure has been restored

Changed 11 years ago by Peter Kovacs

comment:9 Changed 11 years ago by Peter Kovacs

The attached changeset [542dd614cbb4] fixes the demo file.

comment:10 Changed 11 years ago by Alpar Juttner

Resolution: fixed
Status: newclosed

comment:11 Changed 11 years ago by Peter Kovacs

Why was this ticket closed?

Point 2. is a duplication of #106, other improvements are suggested in #76, #85, #86. However point 1. and point 3. are mentioned only in this ticket, and they are not solved nor rejected.

comment:12 in reply to:  11 ; Changed 11 years ago by Alpar Juttner

Replying to kpeter:

Why was this ticket closed?

Point 2. is a duplication of #106, other improvements are suggested in #76, #85, #86. However point 1. and point 3. are mentioned only in this ticket, and they are not solved nor rejected.

  • I was thinking of a good grouping of the options a long ago, but could not come up with a nice one (i.e. which is better than what we have now). You may come up with a solution, but I think the current doc is quite OK.
  • The suggestion 3/1 is not really a reasonable requirement here, as there are different, very small and very specific inputs here. Of course, the LGF input would make sense if this demo were capable to draw more-or-less arbitrary inputs. Unfortunately, this is not the case.
  • For suggestion 3/2, it was even pointed out by you the it isn't feasible. However there might be a solution to this in the long run, see ticket:86

comment:13 in reply to:  12 Changed 11 years ago by Peter Kovacs

Replying to alpar:

...

Thank you. It's okay.

Note: See TracTickets for help on using tickets.