# HG changeset patch
# User klao
# Date 1100123999 0
# Node ID b5fb023cdb7b9c94ff112a9d6e0676002339ee9a
# Parent  175cf8c3a994fd5ed9e3a0c1bc0a369db0f56f14
"make check" pass under icc v8.0

* There are _many_ remarks which are worth examinating! Non-inline (and even
  not template) functions in header files for example.

diff -r 175cf8c3a994 -r b5fb023cdb7b src/benchmark/bench_tools.h
--- a/src/benchmark/bench_tools.h	Wed Nov 10 21:42:28 2004 +0000
+++ b/src/benchmark/bench_tools.h	Wed Nov 10 21:59:59 2004 +0000
@@ -28,7 +28,10 @@
 ///A primitive primtest
 
 ///\bug 2 is not a prime according to this function!
-bool isPrim(int n)
+///
+///\bug This function should go out of header file. I'm making it
+/// inline for now.
+inline bool isPrim(int n)
 {
   if(n%2) {
     for(int k=3;n/k>=k;k+=2)
@@ -39,7 +42,10 @@
 }
 
 ///Finds the smallest prime not less then \c n.
-int nextPrim(int n)
+
+///\bug This function should go out of header file. I'm making it
+/// inline for now.
+inline int nextPrim(int n)
 {
   for(n+=!(n%2);!isPrim(n);n+=2) ;
   return n;
diff -r 175cf8c3a994 -r b5fb023cdb7b src/lemon/array_map.h
--- a/src/lemon/array_map.h	Wed Nov 10 21:42:28 2004 +0000
+++ b/src/lemon/array_map.h	Wed Nov 10 21:59:59 2004 +0000
@@ -364,7 +364,7 @@
 
       typedef ArrayMap<Graph, Node, NodeIt, NodeIdMap, _Value> Parent;
 
-      typedef typename Parent::Graph Graph;
+      //typedef typename Parent::Graph Graph;
       typedef typename Parent::Value Value;
 
       NodeMap(const Graph& g) 
@@ -385,7 +385,7 @@
 
       typedef ArrayMap<Graph, Edge, EdgeIt, EdgeIdMap, _Value> Parent;
 
-      typedef typename Parent::Graph Graph;
+      //typedef typename Parent::Graph Graph;
       typedef typename Parent::Value Value;
 
       EdgeMap(const Graph& g) 
diff -r 175cf8c3a994 -r b5fb023cdb7b src/lemon/default_map.h
--- a/src/lemon/default_map.h	Wed Nov 10 21:42:28 2004 +0000
+++ b/src/lemon/default_map.h	Wed Nov 10 21:59:59 2004 +0000
@@ -187,7 +187,7 @@
 
       typedef DefaultMap<Graph, Node, NodeIt, NodeIdMap, _Value> Parent;
 
-      typedef typename Parent::Graph Graph;
+      //typedef typename Parent::Graph Graph;
       typedef typename Parent::ValueType ValueType;
 
       NodeMap(const Graph& g) 
@@ -208,7 +208,7 @@
 
       typedef DefaultMap<Graph, Edge, EdgeIt, EdgeIdMap, _Value> Parent;
 
-      typedef typename Parent::Graph Graph;
+      //typedef typename Parent::Graph Graph;
       typedef typename Parent::ValueType ValueType;
 
       EdgeMap(const Graph& g) 
diff -r 175cf8c3a994 -r b5fb023cdb7b src/lemon/vector_map.h
--- a/src/lemon/vector_map.h	Wed Nov 10 21:42:28 2004 +0000
+++ b/src/lemon/vector_map.h	Wed Nov 10 21:59:59 2004 +0000
@@ -248,7 +248,7 @@
 
       typedef VectorMap<Graph, Node, NodeIdMap, _Value> Parent;
 
-      typedef typename Parent::Graph Graph;
+      //typedef typename Parent::Graph Graph;
       typedef typename Parent::Value Value;
 
       NodeMap(const Graph& g) 
@@ -268,7 +268,7 @@
 
       typedef VectorMap<Graph, Edge, EdgeIdMap, _Value> Parent;
 
-      typedef typename Parent::Graph Graph;
+      //typedef typename Parent::Graph Graph;
       typedef typename Parent::Value Value;
 
       EdgeMap(const Graph& g)