LEMON/LEMON-main Changeset - r372:7b6466ed488a

Repositories » LEMON » LEMON-main

Summary
Changelog
Files
Switch To
- loading...
Options
- Lightweight changelog
- Search
Pull Requests

Changeset - r372:7b6466ed488a

« 371:164fe3

375:2d87db »

r372:7b6466ed488a

Fri, 07 Nov 2008 14:04:54

[Not Reviewed]

0 comments (0 inline)

alpar (Alpar Juttner)
alpar@cs.elte.hu

Avoid bit operator precedence warning with gcc-4.3 Some of these warnings are actually revealed real bugs

0 2 0

default

2 files changed with 24 insertions and 23 deletions:

lemon/hypercube_graph.h

test/graph_test.cc

↑ Collapse diff ↑

lemon/hypercube_graph.h

Show inline comments

@@ -29,110 +29,111 @@
 		///\brief HypercubeGraph class.
 		namespace lemon {
 		  class HypercubeGraphBase {
 		  public:
 		    typedef HypercubeGraphBase Graph;
 		    class Node;
 		    class Edge;
 		    class Arc;
 		  public:
 		    HypercubeGraphBase() {}
 		  protected:
 		    void construct(int dim) {
 		      LEMON_ASSERT(dim >= 1, "The number of dimensions must be at least 1.");
 		      _dim = dim;
 		      _node_num = 1 << dim;
 		      _edge_num = dim * (1 << dim-1);
+		      _edge_num = dim * (1 << (dim-1));
+		    }
 		  public:
 		    typedef True NodeNumTag;
 		    typedef True EdgeNumTag;
 		    typedef True ArcNumTag;
 		    int nodeNum() const { return _node_num; }
 		    int edgeNum() const { return _edge_num; }
 		    int arcNum() const { return 2 * _edge_num; }
 		    int maxNodeId() const { return _node_num - 1; }
 		    int maxEdgeId() const { return _edge_num - 1; }
 		    int maxArcId() const { return 2 * _edge_num - 1; }
 		    static Node nodeFromId(int id) { return Node(id); }
 		    static Edge edgeFromId(int id) { return Edge(id); }
 		    static Arc arcFromId(int id) { return Arc(id); }
 		    static int id(Node node) { return node._id; }
 		    static int id(Edge edge) { return edge._id; }
 		    static int id(Arc arc) { return arc._id; }
 		    Node u(Edge edge) const {
 		      int base = edge._id & ((1 << _dim-1) - 1);
 		      int k = edge._id >> _dim-1;
-		      return ((base >> k) << k+1) | (base & ((1 << k) - 1));
+		      int base = edge._id & ((1 << (_dim-1)) - 1);
 		      int k = edge._id >> (_dim-1);
 		      return ((base >> k) << (k+1)) | (base & ((1 << k) - 1));
+		    }
 		    Node v(Edge edge) const {
 		      int base = edge._id & ((1 << _dim-1) - 1);
 		      int k = edge._id >> _dim-1;
-		      return ((base >> k) << k+1) | (base & ((1 << k) - 1)) | (1 << k);
+		      int base = edge._id & ((1 << (_dim-1)) - 1);
 		      int k = edge._id >> (_dim-1);
 		      return ((base >> k) << (k+1)) | (base & ((1 << k) - 1)) | (1 << k);
+		    }
 		    Node source(Arc arc) const {
 		      return (arc._id & 1) == 1 ? u(arc) : v(arc);
+		    }
 		    Node target(Arc arc) const {
 		      return (arc._id & 1) == 1 ? v(arc) : u(arc);
+		    }
 		    typedef True FindEdgeTag;
 		    typedef True FindArcTag;
 		    Edge findEdge(Node u, Node v, Edge prev = INVALID) const {
 		      if (prev != INVALID) return INVALID;
 		      int d = u._id ^ v._id;
 		      int k = 0;
 		      if (d == 0) return INVALID;
 		      for ( ; (d & 1) == 0; d >>= 1) ++k;
 		      if (d >> 1 != 0) return INVALID;
-		      return (k << _dim-1) | ((u._id >> k+1) << k) | (u._id & ((1 << k) - 1));
+		      return (k << (_dim-1)) | ((u._id >> (k+1)) << k) |
 		        (u._id & ((1 << k) - 1));
+		    }
 		    Arc findArc(Node u, Node v, Arc prev = INVALID) const {
 		      Edge edge = findEdge(u, v, prev);
 		      if (edge == INVALID) return INVALID;
 		      int k = edge._id >> _dim-1;
+		      int k = edge._id >> (_dim-1);
 		      return ((u._id >> k) & 1) == 1 ? edge._id << 1 : (edge._id << 1) | 1;
+		    }
 		    class Node {
 		      friend class HypercubeGraphBase;
 		    protected:
 		      int _id;
 		      Node(int id) : _id(id) {}
 		    public:
 		      Node() {}
 		      Node (Invalid) : _id(-1) {}
 		      bool operator==(const Node node) const {return _id == node._id;}
 		      bool operator!=(const Node node) const {return _id != node._id;}
 		      bool operator<(const Node node) const {return _id < node._id;}
 		    };
 		    class Edge {
 		      friend class HypercubeGraphBase;
 		      friend class Arc;
 		    protected:
 		      int _id;
@@ -173,109 +174,109 @@
 		    void first(Edge& edge) const {
 		      edge._id = _edge_num - 1;
+		    }
 		    static void next(Edge& edge) {
 		      --edge._id;
+		    }
 		    void first(Arc& arc) const {
 		      arc._id = 2 * _edge_num - 1;
+		    }
 		    static void next(Arc& arc) {
 		      --arc._id;
+		    }
 		    void firstInc(Edge& edge, bool& dir, const Node& node) const {
 		      edge._id = node._id >> 1;
 		      dir = (node._id & 1) == 0;
+		    }
 		    void nextInc(Edge& edge, bool& dir) const {
 		      Node n = dir ? u(edge) : v(edge);
 		      int k = (edge._id >> _dim-1) + 1;
+		      int k = (edge._id >> (_dim-1)) + 1;
 		      if (k < _dim) {
 		        edge._id = (k << _dim-1) |
 		                   ((n._id >> k+1) << k) | (n._id & ((1 << k) - 1));
 		        edge._id = (k << (_dim-1)) |
 		          ((n._id >> (k+1)) << k) | (n._id & ((1 << k) - 1));
 		        dir = ((n._id >> k) & 1) == 0;
 		      } else {
 		        edge._id = -1;
 		        dir = true;
+		      }
+		    }
 		    void firstOut(Arc& arc, const Node& node) const {
 		      arc._id = ((node._id >> 1) << 1) | (~node._id & 1);
+		    }
 		    void nextOut(Arc& arc) const {
 		      Node n = (arc._id & 1) == 1 ? u(arc) : v(arc);
 		      int k = (arc._id >> _dim) + 1;
 		      if (k < _dim) {
 		        arc._id = (k << _dim-1) |
 		                  ((n._id >> k+1) << k) | (n._id & ((1 << k) - 1));
 		        arc._id = (k << (_dim-1)) |
 		          ((n._id >> (k+1)) << k) | (n._id & ((1 << k) - 1));
 		        arc._id = (arc._id << 1) | (~(n._id >> k) & 1);
 		      } else {
 		        arc._id = -1;
+		      }
+		    }
 		    void firstIn(Arc& arc, const Node& node) const {
 		      arc._id = ((node._id >> 1) << 1) | (node._id & 1);
+		    }
 		    void nextIn(Arc& arc) const {
 		      Node n = (arc._id & 1) == 1 ? v(arc) : u(arc);
 		      int k = (arc._id >> _dim) + 1;
 		      if (k < _dim) {
 		        arc._id = (k << _dim-1) |
 		                  ((n._id >> k+1) << k) | (n._id & ((1 << k) - 1));
 		        arc._id = (k << (_dim-1)) |
 		          ((n._id >> (k+1)) << k) | (n._id & ((1 << k) - 1));
 		        arc._id = (arc._id << 1) | ((n._id >> k) & 1);
 		      } else {
 		        arc._id = -1;
+		      }
+		    }
 		    static bool direction(Arc arc) {
 		      return (arc._id & 1) == 1;
+		    }
 		    static Arc direct(Edge edge, bool dir) {
 		      return Arc((edge._id << 1) | (dir ? 1 : 0));
+		    }
 		    int dimension() const {
 		      return _dim;
+		    }
 		    bool projection(Node node, int n) const {
 		      return static_cast<bool>(node._id & (1 << n));
+		    }
 		    int dimension(Edge edge) const {
 		      return edge._id >> _dim-1;
+		      return edge._id >> (_dim-1);
+		    }
 		    int dimension(Arc arc) const {
 		      return arc._id >> _dim;
+		    }
 		    int index(Node node) const {
 		      return node._id;
+		    }
 		    Node operator()(int ix) const {
 		      return Node(ix);
+		    }
 		  private:
 		    int _dim;
 		    int _node_num, _edge_num;
 		  };
 		  typedef GraphExtender<HypercubeGraphBase> ExtendedHypercubeGraphBase;
 		  /// \ingroup graphs
 		  ///

test/graph_test.cc

Show inline comments

@@ -300,80 +300,80 @@
 		    checkGraphOutArcList(G, n, nb);
 		    checkGraphInArcList(G, n, nb);
 		    checkGraphIncEdgeList(G, n, nb);
+		  }
 		  checkArcDirections(G);
 		  checkGraphConArcList(G, 2 * (width * (height - 1) + (width - 1) * height));
 		  checkGraphConEdgeList(G, width * (height - 1) + (width - 1) * height);
 		  checkNodeIds(G);
 		  checkArcIds(G);
 		  checkEdgeIds(G);
 		  checkGraphNodeMap(G);
 		  checkGraphArcMap(G);
 		  checkGraphEdgeMap(G);
+		}
 		void checkHypercubeGraph(int dim) {
 		  GRAPH_TYPEDEFS(HypercubeGraph);
 		  HypercubeGraph G(dim);
 		  checkGraphNodeList(G, 1 << dim);
 		  checkGraphEdgeList(G, dim * (1 << dim-1));
+		  checkGraphEdgeList(G, dim * (1 << (dim-1)));
 		  checkGraphArcList(G, dim * (1 << dim));
 		  Node n = G.nodeFromId(dim);
 		  for (NodeIt n(G); n != INVALID; ++n) {
 		    checkGraphIncEdgeList(G, n, dim);
 		    for (IncEdgeIt e(G, n); e != INVALID; ++e) {
 		      check( (G.u(e) == n &&
 		              G.id(G.v(e)) == G.id(n) ^ (1 << G.dimension(e))) ||
+		              G.id(G.v(e)) == (G.id(n) ^ (1 << G.dimension(e)))) ||
 		             (G.v(e) == n &&
 		              G.id(G.u(e)) == G.id(n) ^ (1 << G.dimension(e))),
+		              G.id(G.u(e)) == (G.id(n) ^ (1 << G.dimension(e)))),
 		             "Wrong edge or wrong dimension");
+		    }
 		    checkGraphOutArcList(G, n, dim);
 		    for (OutArcIt a(G, n); a != INVALID; ++a) {
 		      check(G.source(a) == n &&
 		            G.id(G.target(a)) == G.id(n) ^ (1 << G.dimension(a)),
+		            G.id(G.target(a)) == (G.id(n) ^ (1 << G.dimension(a))),
 		            "Wrong arc or wrong dimension");
+		    }
 		    checkGraphInArcList(G, n, dim);
 		    for (InArcIt a(G, n); a != INVALID; ++a) {
 		      check(G.target(a) == n &&
 		            G.id(G.source(a)) == G.id(n) ^ (1 << G.dimension(a)),
+		            G.id(G.source(a)) == (G.id(n) ^ (1 << G.dimension(a))),
 		            "Wrong arc or wrong dimension");
+		    }
+		  }
 		  checkGraphConArcList(G, (1 << dim) * dim);
 		  checkGraphConEdgeList(G, dim * (1 << dim-1));
+		  checkGraphConEdgeList(G, dim * (1 << (dim-1)));
 		  checkArcDirections(G);
 		  checkNodeIds(G);
 		  checkArcIds(G);
 		  checkEdgeIds(G);
 		  checkGraphNodeMap(G);
 		  checkGraphArcMap(G);
 		  checkGraphEdgeMap(G);
+		}
 		void checkGraphs() {
 		  { // Checking ListGraph
 		    checkGraph<ListGraph>();
 		    checkGraphValidityErase<ListGraph>();
+		  }
 		  { // Checking SmartGraph
 		    checkGraph<SmartGraph>();
 		    checkGraphValidity<SmartGraph>();
+		  }
 		  { // Checking FullGraph
 		    checkFullGraph(7);
 		    checkFullGraph(8);
+		  }

0 comments (0 inline)

RhodeCode

Login to your account