LEMON/LEMON-main Changeset - r740:819ca5b50de0

Repositories » LEMON » LEMON-main

Summary
Changelog
Files
Switch To
- loading...
Options
- Lightweight changelog
- Search
Pull Requests

Changeset - r740:819ca5b50de0

« 738:456fa5

741:10c9c3 »

r740:819ca5b50de0

Tue, 29 Sep 2009 10:21:51

[Not Reviewed]

0 comments (0 inline)

kpeter (Peter Kovacs)
kpeter@inf.elte.hu

Add a warning for List(Di)Graph::Snapshot (#311) and extend tests for snapshots

0 3 0

default

3 files changed with 23 insertions and 0 deletions:

lemon/list_graph.h

test/digraph_test.cc

test/graph_test.cc

↑ Collapse diff ↑

lemon/list_graph.h

Show inline comments

@@ -562,384 +562,387 @@
 		        NodeObserverProxy(Snapshot& _snapshot)
 		          : snapshot(_snapshot) {}
 		        using NodeNotifier::ObserverBase::attach;
 		        using NodeNotifier::ObserverBase::detach;
 		        using NodeNotifier::ObserverBase::attached;
 		      protected:
 		        virtual void add(const Node& node) {
 		          snapshot.addNode(node);
+		        }
 		        virtual void add(const std::vector<Node>& nodes) {
 		          for (int i = nodes.size() - 1; i >= 0; ++i) {
 		            snapshot.addNode(nodes[i]);
+		          }
+		        }
 		        virtual void erase(const Node& node) {
 		          snapshot.eraseNode(node);
+		        }
 		        virtual void erase(const std::vector<Node>& nodes) {
 		          for (int i = 0; i < int(nodes.size()); ++i) {
 		            snapshot.eraseNode(nodes[i]);
+		          }
+		        }
 		        virtual void build() {
 		          Node node;
 		          std::vector<Node> nodes;
 		          for (notifier()->first(node); node != INVALID;
 		               notifier()->next(node)) {
 		            nodes.push_back(node);
+		          }
 		          for (int i = nodes.size() - 1; i >= 0; --i) {
 		            snapshot.addNode(nodes[i]);
+		          }
+		        }
 		        virtual void clear() {
 		          Node node;
 		          for (notifier()->first(node); node != INVALID;
 		               notifier()->next(node)) {
 		            snapshot.eraseNode(node);
+		          }
+		        }
 		        Snapshot& snapshot;
 		      };
 		      class ArcObserverProxy : public ArcNotifier::ObserverBase {
 		      public:
 		        ArcObserverProxy(Snapshot& _snapshot)
 		          : snapshot(_snapshot) {}
 		        using ArcNotifier::ObserverBase::attach;
 		        using ArcNotifier::ObserverBase::detach;
 		        using ArcNotifier::ObserverBase::attached;
 		      protected:
 		        virtual void add(const Arc& arc) {
 		          snapshot.addArc(arc);
+		        }
 		        virtual void add(const std::vector<Arc>& arcs) {
 		          for (int i = arcs.size() - 1; i >= 0; ++i) {
 		            snapshot.addArc(arcs[i]);
+		          }
+		        }
 		        virtual void erase(const Arc& arc) {
 		          snapshot.eraseArc(arc);
+		        }
 		        virtual void erase(const std::vector<Arc>& arcs) {
 		          for (int i = 0; i < int(arcs.size()); ++i) {
 		            snapshot.eraseArc(arcs[i]);
+		          }
+		        }
 		        virtual void build() {
 		          Arc arc;
 		          std::vector<Arc> arcs;
 		          for (notifier()->first(arc); arc != INVALID;
 		               notifier()->next(arc)) {
 		            arcs.push_back(arc);
+		          }
 		          for (int i = arcs.size() - 1; i >= 0; --i) {
 		            snapshot.addArc(arcs[i]);
+		          }
+		        }
 		        virtual void clear() {
 		          Arc arc;
 		          for (notifier()->first(arc); arc != INVALID;
 		               notifier()->next(arc)) {
 		            snapshot.eraseArc(arc);
+		          }
+		        }
 		        Snapshot& snapshot;
 		      };
 		      ListDigraph *digraph;
 		      NodeObserverProxy node_observer_proxy;
 		      ArcObserverProxy arc_observer_proxy;
 		      std::list<Node> added_nodes;
 		      std::list<Arc> added_arcs;
 		      void addNode(const Node& node) {
 		        added_nodes.push_front(node);
+		      }
 		      void eraseNode(const Node& node) {
 		        std::list<Node>::iterator it =
 		          std::find(added_nodes.begin(), added_nodes.end(), node);
 		        if (it == added_nodes.end()) {
 		          clear();
 		          arc_observer_proxy.detach();
 		          throw NodeNotifier::ImmediateDetach();
 		        } else {
 		          added_nodes.erase(it);
+		        }
+		      }
 		      void addArc(const Arc& arc) {
 		        added_arcs.push_front(arc);
+		      }
 		      void eraseArc(const Arc& arc) {
 		        std::list<Arc>::iterator it =
 		          std::find(added_arcs.begin(), added_arcs.end(), arc);
 		        if (it == added_arcs.end()) {
 		          clear();
 		          node_observer_proxy.detach();
 		          throw ArcNotifier::ImmediateDetach();
 		        } else {
 		          added_arcs.erase(it);
+		        }
+		      }
 		      void attach(ListDigraph &_digraph) {
 		        digraph = &_digraph;
 		        node_observer_proxy.attach(digraph->notifier(Node()));
 		        arc_observer_proxy.attach(digraph->notifier(Arc()));
+		      }
 		      void detach() {
 		        node_observer_proxy.detach();
 		        arc_observer_proxy.detach();
+		      }
 		      bool attached() const {
 		        return node_observer_proxy.attached();
+		      }
 		      void clear() {
 		        added_nodes.clear();
 		        added_arcs.clear();
+		      }
 		    public:
 		      /// \brief Default constructor.
 		      ///
 		      /// Default constructor.
 		      /// You have to call save() to actually make a snapshot.
 		      Snapshot()
 		        : digraph(0), node_observer_proxy(*this),
 		          arc_observer_proxy(*this) {}
 		      /// \brief Constructor that immediately makes a snapshot.
 		      ///
 		      /// This constructor immediately makes a snapshot of the given digraph.
 		      Snapshot(ListDigraph &gr)
 		        : node_observer_proxy(*this),
 		          arc_observer_proxy(*this) {
 		        attach(gr);
+		      }
 		      /// \brief Make a snapshot.
 		      ///
 		      /// This function makes a snapshot of the given digraph.
 		      /// It can be called more than once. In case of a repeated
 		      /// call, the previous snapshot gets lost.
 		      void save(ListDigraph &gr) {
 		        if (attached()) {
 		          detach();
 		          clear();
+		        }
 		        attach(gr);
+		      }
 		      /// \brief Undo the changes until the last snapshot.
 		      ///
 		      /// This function undos the changes until the last snapshot
 		      /// created by save() or Snapshot(ListDigraph&).
 		      ///
 		      /// \warning This method invalidates the snapshot, i.e. repeated
 		      /// restoring is not supported unless you call save() again.
 		      void restore() {
 		        detach();
 		        for(std::list<Arc>::iterator it = added_arcs.begin();
 		            it != added_arcs.end(); ++it) {
 		          digraph->erase(*it);
+		        }
 		        for(std::list<Node>::iterator it = added_nodes.begin();
 		            it != added_nodes.end(); ++it) {
 		          digraph->erase(*it);
+		        }
 		        clear();
+		      }
 		      /// \brief Returns \c true if the snapshot is valid.
 		      ///
 		      /// This function returns \c true if the snapshot is valid.
 		      bool valid() const {
 		        return attached();
+		      }
 		    };
 		  };
 		  ///@}
 		  class ListGraphBase {
 		  protected:
 		    struct NodeT {
 		      int first_out;
 		      int prev, next;
 		    };
 		    struct ArcT {
 		      int target;
 		      int prev_out, next_out;
 		    };
 		    std::vector<NodeT> nodes;
 		    int first_node;
 		    int first_free_node;
 		    std::vector<ArcT> arcs;
 		    int first_free_arc;
 		  public:
 		    typedef ListGraphBase Graph;
 		    class Node {
 		      friend class ListGraphBase;
 		    protected:
 		      int id;
 		      explicit Node(int pid) { id = pid;}
 		    public:
 		      Node() {}
 		      Node (Invalid) { id = -1; }
 		      bool operator==(const Node& node) const {return id == node.id;}
 		      bool operator!=(const Node& node) const {return id != node.id;}
 		      bool operator<(const Node& node) const {return id < node.id;}
 		    };
 		    class Edge {
 		      friend class ListGraphBase;
 		    protected:
 		      int id;
 		      explicit Edge(int pid) { id = pid;}
 		    public:
 		      Edge() {}
 		      Edge (Invalid) { id = -1; }
 		      bool operator==(const Edge& edge) const {return id == edge.id;}
 		      bool operator!=(const Edge& edge) const {return id != edge.id;}
 		      bool operator<(const Edge& edge) const {return id < edge.id;}
 		    };
 		    class Arc {
 		      friend class ListGraphBase;
 		    protected:
 		      int id;
 		      explicit Arc(int pid) { id = pid;}
 		    public:
 		      operator Edge() const {
 		        return id != -1 ? edgeFromId(id / 2) : INVALID;
+		      }
 		      Arc() {}
 		      Arc (Invalid) { id = -1; }
 		      bool operator==(const Arc& arc) const {return id == arc.id;}
 		      bool operator!=(const Arc& arc) const {return id != arc.id;}
 		      bool operator<(const Arc& arc) const {return id < arc.id;}
 		    };
 		    ListGraphBase()
 		      : nodes(), first_node(-1),
 		        first_free_node(-1), arcs(), first_free_arc(-1) {}
 		    int maxNodeId() const { return nodes.size()-1; }
 		    int maxEdgeId() const { return arcs.size() / 2 - 1; }
 		    int maxArcId() const { return arcs.size()-1; }
 		    Node source(Arc e) const { return Node(arcs[e.id ^ 1].target); }
 		    Node target(Arc e) const { return Node(arcs[e.id].target); }
 		    Node u(Edge e) const { return Node(arcs[2 * e.id].target); }
 		    Node v(Edge e) const { return Node(arcs[2 * e.id + 1].target); }
 		    static bool direction(Arc e) {
 		      return (e.id & 1) == 1;
+		    }
 		    static Arc direct(Edge e, bool d) {
 		      return Arc(e.id * 2 + (d ? 1 : 0));
+		    }
 		    void first(Node& node) const {
 		      node.id = first_node;
+		    }
 		    void next(Node& node) const {
 		      node.id = nodes[node.id].next;
+		    }
 		    void first(Arc& e) const {
 		      int n = first_node;
 		      while (n != -1 && nodes[n].first_out == -1) {
 		        n = nodes[n].next;
+		      }
 		      e.id = (n == -1) ? -1 : nodes[n].first_out;
+		    }
 		    void next(Arc& e) const {
 		      if (arcs[e.id].next_out != -1) {
 		        e.id = arcs[e.id].next_out;
 		      } else {
 		        int n = nodes[arcs[e.id ^ 1].target].next;
 		        while(n != -1 && nodes[n].first_out == -1) {
 		          n = nodes[n].next;
+		        }
 		        e.id = (n == -1) ? -1 : nodes[n].first_out;
+		      }
+		    }
 		    void first(Edge& e) const {
 		      int n = first_node;
 		      while (n != -1) {
 		        e.id = nodes[n].first_out;
 		        while ((e.id & 1) != 1) {
 		          e.id = arcs[e.id].next_out;
+		        }
 		        if (e.id != -1) {
 		          e.id /= 2;
 		          return;
+		        }
 		        n = nodes[n].next;
+		      }
 		      e.id = -1;
+		    }
 		    void next(Edge& e) const {
 		      int n = arcs[e.id * 2].target;
 		      e.id = arcs[(e.id * 2) | 1].next_out;
 		      while ((e.id & 1) != 1) {
 		        e.id = arcs[e.id].next_out;
+		      }
 		      if (e.id != -1) {
 		        e.id /= 2;
 		        return;
+		      }
 		      n = nodes[n].next;
 		      while (n != -1) {
 		        e.id = nodes[n].first_out;
 		        while ((e.id & 1) != 1) {
 		          e.id = arcs[e.id].next_out;
+		        }
 		        if (e.id != -1) {
 		          e.id /= 2;
 		          return;
+		        }
 		        n = nodes[n].next;
+		      }
 		      e.id = -1;
@@ -1361,219 +1364,222 @@
 		        NodeObserverProxy(Snapshot& _snapshot)
 		          : snapshot(_snapshot) {}
 		        using NodeNotifier::ObserverBase::attach;
 		        using NodeNotifier::ObserverBase::detach;
 		        using NodeNotifier::ObserverBase::attached;
 		      protected:
 		        virtual void add(const Node& node) {
 		          snapshot.addNode(node);
+		        }
 		        virtual void add(const std::vector<Node>& nodes) {
 		          for (int i = nodes.size() - 1; i >= 0; ++i) {
 		            snapshot.addNode(nodes[i]);
+		          }
+		        }
 		        virtual void erase(const Node& node) {
 		          snapshot.eraseNode(node);
+		        }
 		        virtual void erase(const std::vector<Node>& nodes) {
 		          for (int i = 0; i < int(nodes.size()); ++i) {
 		            snapshot.eraseNode(nodes[i]);
+		          }
+		        }
 		        virtual void build() {
 		          Node node;
 		          std::vector<Node> nodes;
 		          for (notifier()->first(node); node != INVALID;
 		               notifier()->next(node)) {
 		            nodes.push_back(node);
+		          }
 		          for (int i = nodes.size() - 1; i >= 0; --i) {
 		            snapshot.addNode(nodes[i]);
+		          }
+		        }
 		        virtual void clear() {
 		          Node node;
 		          for (notifier()->first(node); node != INVALID;
 		               notifier()->next(node)) {
 		            snapshot.eraseNode(node);
+		          }
+		        }
 		        Snapshot& snapshot;
 		      };
 		      class EdgeObserverProxy : public EdgeNotifier::ObserverBase {
 		      public:
 		        EdgeObserverProxy(Snapshot& _snapshot)
 		          : snapshot(_snapshot) {}
 		        using EdgeNotifier::ObserverBase::attach;
 		        using EdgeNotifier::ObserverBase::detach;
 		        using EdgeNotifier::ObserverBase::attached;
 		      protected:
 		        virtual void add(const Edge& edge) {
 		          snapshot.addEdge(edge);
+		        }
 		        virtual void add(const std::vector<Edge>& edges) {
 		          for (int i = edges.size() - 1; i >= 0; ++i) {
 		            snapshot.addEdge(edges[i]);
+		          }
+		        }
 		        virtual void erase(const Edge& edge) {
 		          snapshot.eraseEdge(edge);
+		        }
 		        virtual void erase(const std::vector<Edge>& edges) {
 		          for (int i = 0; i < int(edges.size()); ++i) {
 		            snapshot.eraseEdge(edges[i]);
+		          }
+		        }
 		        virtual void build() {
 		          Edge edge;
 		          std::vector<Edge> edges;
 		          for (notifier()->first(edge); edge != INVALID;
 		               notifier()->next(edge)) {
 		            edges.push_back(edge);
+		          }
 		          for (int i = edges.size() - 1; i >= 0; --i) {
 		            snapshot.addEdge(edges[i]);
+		          }
+		        }
 		        virtual void clear() {
 		          Edge edge;
 		          for (notifier()->first(edge); edge != INVALID;
 		               notifier()->next(edge)) {
 		            snapshot.eraseEdge(edge);
+		          }
+		        }
 		        Snapshot& snapshot;
 		      };
 		      ListGraph *graph;
 		      NodeObserverProxy node_observer_proxy;
 		      EdgeObserverProxy edge_observer_proxy;
 		      std::list<Node> added_nodes;
 		      std::list<Edge> added_edges;
 		      void addNode(const Node& node) {
 		        added_nodes.push_front(node);
+		      }
 		      void eraseNode(const Node& node) {
 		        std::list<Node>::iterator it =
 		          std::find(added_nodes.begin(), added_nodes.end(), node);
 		        if (it == added_nodes.end()) {
 		          clear();
 		          edge_observer_proxy.detach();
 		          throw NodeNotifier::ImmediateDetach();
 		        } else {
 		          added_nodes.erase(it);
+		        }
+		      }
 		      void addEdge(const Edge& edge) {
 		        added_edges.push_front(edge);
+		      }
 		      void eraseEdge(const Edge& edge) {
 		        std::list<Edge>::iterator it =
 		          std::find(added_edges.begin(), added_edges.end(), edge);
 		        if (it == added_edges.end()) {
 		          clear();
 		          node_observer_proxy.detach();
 		          throw EdgeNotifier::ImmediateDetach();
 		        } else {
 		          added_edges.erase(it);
+		        }
+		      }
 		      void attach(ListGraph &_graph) {
 		        graph = &_graph;
 		        node_observer_proxy.attach(graph->notifier(Node()));
 		        edge_observer_proxy.attach(graph->notifier(Edge()));
+		      }
 		      void detach() {
 		        node_observer_proxy.detach();
 		        edge_observer_proxy.detach();
+		      }
 		      bool attached() const {
 		        return node_observer_proxy.attached();
+		      }
 		      void clear() {
 		        added_nodes.clear();
 		        added_edges.clear();
+		      }
 		    public:
 		      /// \brief Default constructor.
 		      ///
 		      /// Default constructor.
 		      /// You have to call save() to actually make a snapshot.
 		      Snapshot()
 		        : graph(0), node_observer_proxy(*this),
 		          edge_observer_proxy(*this) {}
 		      /// \brief Constructor that immediately makes a snapshot.
 		      ///
 		      /// This constructor immediately makes a snapshot of the given graph.
 		      Snapshot(ListGraph &gr)
 		        : node_observer_proxy(*this),
 		          edge_observer_proxy(*this) {
 		        attach(gr);
+		      }
 		      /// \brief Make a snapshot.
 		      ///
 		      /// This function makes a snapshot of the given graph.
 		      /// It can be called more than once. In case of a repeated
 		      /// call, the previous snapshot gets lost.
 		      void save(ListGraph &gr) {
 		        if (attached()) {
 		          detach();
 		          clear();
+		        }
 		        attach(gr);
+		      }
 		      /// \brief Undo the changes until the last snapshot.
 		      ///
 		      /// This function undos the changes until the last snapshot
 		      /// created by save() or Snapshot(ListGraph&).
 		      ///
 		      /// \warning This method invalidates the snapshot, i.e. repeated
 		      /// restoring is not supported unless you call save() again.
 		      void restore() {
 		        detach();
 		        for(std::list<Edge>::iterator it = added_edges.begin();
 		            it != added_edges.end(); ++it) {
 		          graph->erase(*it);
+		        }
 		        for(std::list<Node>::iterator it = added_nodes.begin();
 		            it != added_nodes.end(); ++it) {
 		          graph->erase(*it);
+		        }
 		        clear();
+		      }
 		      /// \brief Returns \c true if the snapshot is valid.
 		      ///
 		      /// This function returns \c true if the snapshot is valid.
 		      bool valid() const {
 		        return attached();
+		      }
 		    };
 		  };
 		  /// @}
 		} //namespace lemon
 		#endif

test/digraph_test.cc

Show inline comments

@@ -97,343 +97,351 @@
 		  check(G.target(OutArcIt(G, n2)) == n4 &&
 		        G.source(InArcIt(G, n4)) == n2,
 		        "Wrong split.");
 		  checkGraphNodeList(G, 4);
 		  checkGraphArcList(G, 5);
 		  checkGraphOutArcList(G, n1, 1);
 		  checkGraphOutArcList(G, n2, 1);
 		  checkGraphOutArcList(G, n3, 0);
 		  checkGraphOutArcList(G, n4, 3);
 		  checkGraphInArcList(G, n1, 1);
 		  checkGraphInArcList(G, n2, 1);
 		  checkGraphInArcList(G, n3, 2);
 		  checkGraphInArcList(G, n4, 1);
 		  checkGraphConArcList(G, 5);
+		}
 		template <class Digraph>
 		void checkDigraphAlter() {
 		  TEMPLATE_DIGRAPH_TYPEDEFS(Digraph);
 		  Digraph G;
 		  Node n1 = G.addNode(), n2 = G.addNode(),
 		       n3 = G.addNode(), n4 = G.addNode();
 		  Arc a1 = G.addArc(n1, n2), a2 = G.addArc(n4, n1),
 		      a3 = G.addArc(n4, n3), a4 = G.addArc(n4, n3),
 		      a5 = G.addArc(n2, n4);
 		  checkGraphNodeList(G, 4);
 		  checkGraphArcList(G, 5);
 		  // Check changeSource() and changeTarget()
 		  G.changeTarget(a4, n1);
 		  checkGraphNodeList(G, 4);
 		  checkGraphArcList(G, 5);
 		  checkGraphOutArcList(G, n1, 1);
 		  checkGraphOutArcList(G, n2, 1);
 		  checkGraphOutArcList(G, n3, 0);
 		  checkGraphOutArcList(G, n4, 3);
 		  checkGraphInArcList(G, n1, 2);
 		  checkGraphInArcList(G, n2, 1);
 		  checkGraphInArcList(G, n3, 1);
 		  checkGraphInArcList(G, n4, 1);
 		  checkGraphConArcList(G, 5);
 		  G.changeSource(a4, n3);
 		  checkGraphNodeList(G, 4);
 		  checkGraphArcList(G, 5);
 		  checkGraphOutArcList(G, n1, 1);
 		  checkGraphOutArcList(G, n2, 1);
 		  checkGraphOutArcList(G, n3, 1);
 		  checkGraphOutArcList(G, n4, 2);
 		  checkGraphInArcList(G, n1, 2);
 		  checkGraphInArcList(G, n2, 1);
 		  checkGraphInArcList(G, n3, 1);
 		  checkGraphInArcList(G, n4, 1);
 		  checkGraphConArcList(G, 5);
 		  // Check contract()
 		  G.contract(n2, n4, false);
 		  checkGraphNodeList(G, 3);
 		  checkGraphArcList(G, 5);
 		  checkGraphOutArcList(G, n1, 1);
 		  checkGraphOutArcList(G, n2, 3);
 		  checkGraphOutArcList(G, n3, 1);
 		  checkGraphInArcList(G, n1, 2);
 		  checkGraphInArcList(G, n2, 2);
 		  checkGraphInArcList(G, n3, 1);
 		  checkGraphConArcList(G, 5);
 		  G.contract(n2, n1);
 		  checkGraphNodeList(G, 2);
 		  checkGraphArcList(G, 3);
 		  checkGraphOutArcList(G, n2, 2);
 		  checkGraphOutArcList(G, n3, 1);
 		  checkGraphInArcList(G, n2, 2);
 		  checkGraphInArcList(G, n3, 1);
 		  checkGraphConArcList(G, 3);
+		}
 		template <class Digraph>
 		void checkDigraphErase() {
 		  TEMPLATE_DIGRAPH_TYPEDEFS(Digraph);
 		  Digraph G;
 		  Node n1 = G.addNode(), n2 = G.addNode(),
 		       n3 = G.addNode(), n4 = G.addNode();
 		  Arc a1 = G.addArc(n1, n2), a2 = G.addArc(n4, n1),
 		      a3 = G.addArc(n4, n3), a4 = G.addArc(n3, n1),
 		      a5 = G.addArc(n2, n4);
 		  // Check arc deletion
 		  G.erase(a1);
 		  checkGraphNodeList(G, 4);
 		  checkGraphArcList(G, 4);
 		  checkGraphOutArcList(G, n1, 0);
 		  checkGraphOutArcList(G, n2, 1);
 		  checkGraphOutArcList(G, n3, 1);
 		  checkGraphOutArcList(G, n4, 2);
 		  checkGraphInArcList(G, n1, 2);
 		  checkGraphInArcList(G, n2, 0);
 		  checkGraphInArcList(G, n3, 1);
 		  checkGraphInArcList(G, n4, 1);
 		  checkGraphConArcList(G, 4);
 		  // Check node deletion
 		  G.erase(n4);
 		  checkGraphNodeList(G, 3);
 		  checkGraphArcList(G, 1);
 		  checkGraphOutArcList(G, n1, 0);
 		  checkGraphOutArcList(G, n2, 0);
 		  checkGraphOutArcList(G, n3, 1);
 		  checkGraphOutArcList(G, n4, 0);
 		  checkGraphInArcList(G, n1, 1);
 		  checkGraphInArcList(G, n2, 0);
 		  checkGraphInArcList(G, n3, 0);
 		  checkGraphInArcList(G, n4, 0);
 		  checkGraphConArcList(G, 1);
+		}
 		template <class Digraph>
 		void checkDigraphSnapshot() {
 		  TEMPLATE_DIGRAPH_TYPEDEFS(Digraph);
 		  Digraph G;
 		  Node n1 = G.addNode(), n2 = G.addNode(), n3 = G.addNode();
 		  Arc a1 = G.addArc(n1, n2), a2 = G.addArc(n2, n1),
 		      a3 = G.addArc(n2, n3), a4 = G.addArc(n2, n3);
 		  typename Digraph::Snapshot snapshot(G);
 		  Node n = G.addNode();
 		  G.addArc(n3, n);
 		  G.addArc(n, n3);
 		  checkGraphNodeList(G, 4);
 		  checkGraphArcList(G, 6);
 		  snapshot.restore();
 		  checkGraphNodeList(G, 3);
 		  checkGraphArcList(G, 4);
 		  checkGraphOutArcList(G, n1, 1);
 		  checkGraphOutArcList(G, n2, 3);
 		  checkGraphOutArcList(G, n3, 0);
 		  checkGraphInArcList(G, n1, 1);
 		  checkGraphInArcList(G, n2, 1);
 		  checkGraphInArcList(G, n3, 2);
 		  checkGraphConArcList(G, 4);
 		  checkNodeIds(G);
 		  checkArcIds(G);
 		  checkGraphNodeMap(G);
 		  checkGraphArcMap(G);
 		  G.addNode();
 		  snapshot.save(G);
 		  G.addArc(G.addNode(), G.addNode());
 		  snapshot.restore();
 		  snapshot.save(G);
 		  checkGraphNodeList(G, 4);
 		  checkGraphArcList(G, 4);
 		  G.addArc(G.addNode(), G.addNode());
 		  snapshot.restore();
 		  checkGraphNodeList(G, 4);
 		  checkGraphArcList(G, 4);
+		}
 		void checkConcepts() {
 		  { // Checking digraph components
 		    checkConcept<BaseDigraphComponent, BaseDigraphComponent >();
 		    checkConcept<IDableDigraphComponent<>,
 		      IDableDigraphComponent<> >();
 		    checkConcept<IterableDigraphComponent<>,
 		      IterableDigraphComponent<> >();
 		    checkConcept<MappableDigraphComponent<>,
 		      MappableDigraphComponent<> >();
+		  }
 		  { // Checking skeleton digraph
 		    checkConcept<Digraph, Digraph>();
+		  }
 		  { // Checking ListDigraph
 		    checkConcept<Digraph, ListDigraph>();
 		    checkConcept<AlterableDigraphComponent<>, ListDigraph>();
 		    checkConcept<ExtendableDigraphComponent<>, ListDigraph>();
 		    checkConcept<ClearableDigraphComponent<>, ListDigraph>();
 		    checkConcept<ErasableDigraphComponent<>, ListDigraph>();
+		  }
 		  { // Checking SmartDigraph
 		    checkConcept<Digraph, SmartDigraph>();
 		    checkConcept<AlterableDigraphComponent<>, SmartDigraph>();
 		    checkConcept<ExtendableDigraphComponent<>, SmartDigraph>();
 		    checkConcept<ClearableDigraphComponent<>, SmartDigraph>();
+		  }
 		  { // Checking FullDigraph
 		    checkConcept<Digraph, FullDigraph>();
+		  }
+		}
 		template <typename Digraph>
 		void checkDigraphValidity() {
 		  TEMPLATE_DIGRAPH_TYPEDEFS(Digraph);
 		  Digraph g;
 		  Node
 		    n1 = g.addNode(),
 		    n2 = g.addNode(),
 		    n3 = g.addNode();
 		  Arc
 		    e1 = g.addArc(n1, n2),
 		    e2 = g.addArc(n2, n3);
 		  check(g.valid(n1), "Wrong validity check");
 		  check(g.valid(e1), "Wrong validity check");
 		  check(!g.valid(g.nodeFromId(-1)), "Wrong validity check");
 		  check(!g.valid(g.arcFromId(-1)), "Wrong validity check");
+		}
 		template <typename Digraph>
 		void checkDigraphValidityErase() {
 		  TEMPLATE_DIGRAPH_TYPEDEFS(Digraph);
 		  Digraph g;
 		  Node
 		    n1 = g.addNode(),
 		    n2 = g.addNode(),
 		    n3 = g.addNode();
 		  Arc
 		    e1 = g.addArc(n1, n2),
 		    e2 = g.addArc(n2, n3);
 		  check(g.valid(n1), "Wrong validity check");
 		  check(g.valid(e1), "Wrong validity check");
 		  g.erase(n1);
 		  check(!g.valid(n1), "Wrong validity check");
 		  check(g.valid(n2), "Wrong validity check");
 		  check(g.valid(n3), "Wrong validity check");
 		  check(!g.valid(e1), "Wrong validity check");
 		  check(g.valid(e2), "Wrong validity check");
 		  check(!g.valid(g.nodeFromId(-1)), "Wrong validity check");
 		  check(!g.valid(g.arcFromId(-1)), "Wrong validity check");
+		}
 		void checkFullDigraph(int num) {
 		  typedef FullDigraph Digraph;
 		  DIGRAPH_TYPEDEFS(Digraph);
 		  Digraph G(num);
 		  check(G.nodeNum() == num && G.arcNum() == num * num, "Wrong size");
 		  G.resize(num);
 		  check(G.nodeNum() == num && G.arcNum() == num * num, "Wrong size");
 		  checkGraphNodeList(G, num);
 		  checkGraphArcList(G, num * num);
 		  for (NodeIt n(G); n != INVALID; ++n) {
 		    checkGraphOutArcList(G, n, num);
 		    checkGraphInArcList(G, n, num);
+		  }
 		  checkGraphConArcList(G, num * num);
 		  checkNodeIds(G);
 		  checkArcIds(G);
 		  checkGraphNodeMap(G);
 		  checkGraphArcMap(G);
 		  for (int i = 0; i < G.nodeNum(); ++i) {
 		    check(G.index(G(i)) == i, "Wrong index");
+		  }
 		  for (NodeIt s(G); s != INVALID; ++s) {
 		    for (NodeIt t(G); t != INVALID; ++t) {
 		      Arc a = G.arc(s, t);
 		      check(G.source(a) == s && G.target(a) == t, "Wrong arc lookup");
+		    }
+		  }
+		}
 		void checkDigraphs() {
 		  { // Checking ListDigraph
 		    checkDigraphBuild<ListDigraph>();
 		    checkDigraphSplit<ListDigraph>();
 		    checkDigraphAlter<ListDigraph>();
 		    checkDigraphErase<ListDigraph>();
 		    checkDigraphSnapshot<ListDigraph>();
 		    checkDigraphValidityErase<ListDigraph>();
+		  }
 		  { // Checking SmartDigraph
 		    checkDigraphBuild<SmartDigraph>();
 		    checkDigraphSplit<SmartDigraph>();
 		    checkDigraphSnapshot<SmartDigraph>();
 		    checkDigraphValidity<SmartDigraph>();
+		  }
 		  { // Checking FullDigraph
 		    checkFullDigraph(8);
+		  }
+		}
 		int main() {
 		  checkDigraphs();
 		  checkConcepts();
 		  return 0;
+		}

test/graph_test.cc

Show inline comments

@@ -70,384 +70,393 @@
 		  checkGraphNodeList(G, 3);
 		  checkGraphEdgeList(G, 3);
 		  checkGraphArcList(G, 6);
 		  checkGraphIncEdgeArcLists(G, n1, 2);
 		  checkGraphIncEdgeArcLists(G, n2, 3);
 		  checkGraphIncEdgeArcLists(G, n3, 1);
 		  checkGraphConEdgeList(G, 3);
 		  checkGraphConArcList(G, 6);
 		  checkArcDirections(G);
 		  checkNodeIds(G);
 		  checkArcIds(G);
 		  checkEdgeIds(G);
 		  checkGraphNodeMap(G);
 		  checkGraphArcMap(G);
 		  checkGraphEdgeMap(G);
+		}
 		template <class Graph>
 		void checkGraphAlter() {
 		  TEMPLATE_GRAPH_TYPEDEFS(Graph);
 		  Graph G;
 		  Node n1 = G.addNode(), n2 = G.addNode(),
 		       n3 = G.addNode(), n4 = G.addNode();
 		  Edge e1 = G.addEdge(n1, n2), e2 = G.addEdge(n2, n1),
 		       e3 = G.addEdge(n2, n3), e4 = G.addEdge(n1, n4),
 		       e5 = G.addEdge(n4, n3);
 		  checkGraphNodeList(G, 4);
 		  checkGraphEdgeList(G, 5);
 		  checkGraphArcList(G, 10);
 		  // Check changeU() and changeV()
 		  if (G.u(e2) == n2) {
 		    G.changeU(e2, n3);
 		  } else {
 		    G.changeV(e2, n3);
+		  }
 		  checkGraphNodeList(G, 4);
 		  checkGraphEdgeList(G, 5);
 		  checkGraphArcList(G, 10);
 		  checkGraphIncEdgeArcLists(G, n1, 3);
 		  checkGraphIncEdgeArcLists(G, n2, 2);
 		  checkGraphIncEdgeArcLists(G, n3, 3);
 		  checkGraphIncEdgeArcLists(G, n4, 2);
 		  checkGraphConEdgeList(G, 5);
 		  checkGraphConArcList(G, 10);
 		  if (G.u(e2) == n1) {
 		    G.changeU(e2, n2);
 		  } else {
 		    G.changeV(e2, n2);
+		  }
 		  checkGraphNodeList(G, 4);
 		  checkGraphEdgeList(G, 5);
 		  checkGraphArcList(G, 10);
 		  checkGraphIncEdgeArcLists(G, n1, 2);
 		  checkGraphIncEdgeArcLists(G, n2, 3);
 		  checkGraphIncEdgeArcLists(G, n3, 3);
 		  checkGraphIncEdgeArcLists(G, n4, 2);
 		  checkGraphConEdgeList(G, 5);
 		  checkGraphConArcList(G, 10);
 		  // Check contract()
 		  G.contract(n1, n4, false);
 		  checkGraphNodeList(G, 3);
 		  checkGraphEdgeList(G, 5);
 		  checkGraphArcList(G, 10);
 		  checkGraphIncEdgeArcLists(G, n1, 4);
 		  checkGraphIncEdgeArcLists(G, n2, 3);
 		  checkGraphIncEdgeArcLists(G, n3, 3);
 		  checkGraphConEdgeList(G, 5);
 		  checkGraphConArcList(G, 10);
 		  G.contract(n2, n3);
 		  checkGraphNodeList(G, 2);
 		  checkGraphEdgeList(G, 3);
 		  checkGraphArcList(G, 6);
 		  checkGraphIncEdgeArcLists(G, n1, 4);
 		  checkGraphIncEdgeArcLists(G, n2, 2);
 		  checkGraphConEdgeList(G, 3);
 		  checkGraphConArcList(G, 6);
+		}
 		template <class Graph>
 		void checkGraphErase() {
 		  TEMPLATE_GRAPH_TYPEDEFS(Graph);
 		  Graph G;
 		  Node n1 = G.addNode(), n2 = G.addNode(),
 		       n3 = G.addNode(), n4 = G.addNode();
 		  Edge e1 = G.addEdge(n1, n2), e2 = G.addEdge(n2, n1),
 		       e3 = G.addEdge(n2, n3), e4 = G.addEdge(n1, n4),
 		       e5 = G.addEdge(n4, n3);
 		  // Check edge deletion
 		  G.erase(e2);
 		  checkGraphNodeList(G, 4);
 		  checkGraphEdgeList(G, 4);
 		  checkGraphArcList(G, 8);
 		  checkGraphIncEdgeArcLists(G, n1, 2);
 		  checkGraphIncEdgeArcLists(G, n2, 2);
 		  checkGraphIncEdgeArcLists(G, n3, 2);
 		  checkGraphIncEdgeArcLists(G, n4, 2);
 		  checkGraphConEdgeList(G, 4);
 		  checkGraphConArcList(G, 8);
 		  // Check node deletion
 		  G.erase(n3);
 		  checkGraphNodeList(G, 3);
 		  checkGraphEdgeList(G, 2);
 		  checkGraphArcList(G, 4);
 		  checkGraphIncEdgeArcLists(G, n1, 2);
 		  checkGraphIncEdgeArcLists(G, n2, 1);
 		  checkGraphIncEdgeArcLists(G, n4, 1);
 		  checkGraphConEdgeList(G, 2);
 		  checkGraphConArcList(G, 4);
+		}
 		template <class Graph>
 		void checkGraphSnapshot() {
 		  TEMPLATE_GRAPH_TYPEDEFS(Graph);
 		  Graph G;
 		  Node n1 = G.addNode(), n2 = G.addNode(), n3 = G.addNode();
 		  Edge e1 = G.addEdge(n1, n2), e2 = G.addEdge(n2, n1),
 		       e3 = G.addEdge(n2, n3);
 		  checkGraphNodeList(G, 3);
 		  checkGraphEdgeList(G, 3);
 		  checkGraphArcList(G, 6);
 		  typename Graph::Snapshot snapshot(G);
 		  Node n = G.addNode();
 		  G.addEdge(n3, n);
 		  G.addEdge(n, n3);
 		  G.addEdge(n3, n2);
 		  checkGraphNodeList(G, 4);
 		  checkGraphEdgeList(G, 6);
 		  checkGraphArcList(G, 12);
 		  snapshot.restore();
 		  checkGraphNodeList(G, 3);
 		  checkGraphEdgeList(G, 3);
 		  checkGraphArcList(G, 6);
 		  checkGraphIncEdgeArcLists(G, n1, 2);
 		  checkGraphIncEdgeArcLists(G, n2, 3);
 		  checkGraphIncEdgeArcLists(G, n3, 1);
 		  checkGraphConEdgeList(G, 3);
 		  checkGraphConArcList(G, 6);
 		  checkNodeIds(G);
 		  checkEdgeIds(G);
 		  checkArcIds(G);
 		  checkGraphNodeMap(G);
 		  checkGraphEdgeMap(G);
 		  checkGraphArcMap(G);
 		  G.addNode();
 		  snapshot.save(G);
 		  G.addEdge(G.addNode(), G.addNode());
 		  snapshot.restore();
 		  snapshot.save(G);
 		  checkGraphNodeList(G, 4);
 		  checkGraphEdgeList(G, 3);
 		  checkGraphArcList(G, 6);
 		  G.addEdge(G.addNode(), G.addNode());
 		  snapshot.restore();
 		  checkGraphNodeList(G, 4);
 		  checkGraphEdgeList(G, 3);
 		  checkGraphArcList(G, 6);
+		}
 		void checkFullGraph(int num) {
 		  typedef FullGraph Graph;
 		  GRAPH_TYPEDEFS(Graph);
 		  Graph G(num);
 		  check(G.nodeNum() == num && G.edgeNum() == num * (num - 1) / 2,
 		        "Wrong size");
 		  G.resize(num);
 		  check(G.nodeNum() == num && G.edgeNum() == num * (num - 1) / 2,
 		        "Wrong size");
 		  checkGraphNodeList(G, num);
 		  checkGraphEdgeList(G, num * (num - 1) / 2);
 		  for (NodeIt n(G); n != INVALID; ++n) {
 		    checkGraphOutArcList(G, n, num - 1);
 		    checkGraphInArcList(G, n, num - 1);
 		    checkGraphIncEdgeList(G, n, num - 1);
+		  }
 		  checkGraphConArcList(G, num * (num - 1));
 		  checkGraphConEdgeList(G, num * (num - 1) / 2);
 		  checkArcDirections(G);
 		  checkNodeIds(G);
 		  checkArcIds(G);
 		  checkEdgeIds(G);
 		  checkGraphNodeMap(G);
 		  checkGraphArcMap(G);
 		  checkGraphEdgeMap(G);
 		  for (int i = 0; i < G.nodeNum(); ++i) {
 		    check(G.index(G(i)) == i, "Wrong index");
+		  }
 		  for (NodeIt u(G); u != INVALID; ++u) {
 		    for (NodeIt v(G); v != INVALID; ++v) {
 		      Edge e = G.edge(u, v);
 		      Arc a = G.arc(u, v);
 		      if (u == v) {
 		        check(e == INVALID, "Wrong edge lookup");
 		        check(a == INVALID, "Wrong arc lookup");
 		      } else {
 		        check((G.u(e) == u && G.v(e) == v) ||
 		              (G.u(e) == v && G.v(e) == u), "Wrong edge lookup");
 		        check(G.source(a) == u && G.target(a) == v, "Wrong arc lookup");
+		      }
+		    }
+		  }
+		}
 		void checkConcepts() {
 		  { // Checking graph components
 		    checkConcept<BaseGraphComponent, BaseGraphComponent >();
 		    checkConcept<IDableGraphComponent<>,
 		      IDableGraphComponent<> >();
 		    checkConcept<IterableGraphComponent<>,
 		      IterableGraphComponent<> >();
 		    checkConcept<MappableGraphComponent<>,
 		      MappableGraphComponent<> >();
+		  }
 		  { // Checking skeleton graph
 		    checkConcept<Graph, Graph>();
+		  }
 		  { // Checking ListGraph
 		    checkConcept<Graph, ListGraph>();
 		    checkConcept<AlterableGraphComponent<>, ListGraph>();
 		    checkConcept<ExtendableGraphComponent<>, ListGraph>();
 		    checkConcept<ClearableGraphComponent<>, ListGraph>();
 		    checkConcept<ErasableGraphComponent<>, ListGraph>();
+		  }
 		  { // Checking SmartGraph
 		    checkConcept<Graph, SmartGraph>();
 		    checkConcept<AlterableGraphComponent<>, SmartGraph>();
 		    checkConcept<ExtendableGraphComponent<>, SmartGraph>();
 		    checkConcept<ClearableGraphComponent<>, SmartGraph>();
+		  }
 		  { // Checking FullGraph
 		    checkConcept<Graph, FullGraph>();
+		  }
 		  { // Checking GridGraph
 		    checkConcept<Graph, GridGraph>();
+		  }
 		  { // Checking HypercubeGraph
 		    checkConcept<Graph, HypercubeGraph>();
+		  }
+		}
 		template <typename Graph>
 		void checkGraphValidity() {
 		  TEMPLATE_GRAPH_TYPEDEFS(Graph);
 		  Graph g;
 		  Node
 		    n1 = g.addNode(),
 		    n2 = g.addNode(),
 		    n3 = g.addNode();
 		  Edge
 		    e1 = g.addEdge(n1, n2),
 		    e2 = g.addEdge(n2, n3);
 		  check(g.valid(n1), "Wrong validity check");
 		  check(g.valid(e1), "Wrong validity check");
 		  check(g.valid(g.direct(e1, true)), "Wrong validity check");
 		  check(!g.valid(g.nodeFromId(-1)), "Wrong validity check");
 		  check(!g.valid(g.edgeFromId(-1)), "Wrong validity check");
 		  check(!g.valid(g.arcFromId(-1)), "Wrong validity check");
+		}
 		template <typename Graph>
 		void checkGraphValidityErase() {
 		  TEMPLATE_GRAPH_TYPEDEFS(Graph);
 		  Graph g;
 		  Node
 		    n1 = g.addNode(),
 		    n2 = g.addNode(),
 		    n3 = g.addNode();
 		  Edge
 		    e1 = g.addEdge(n1, n2),
 		    e2 = g.addEdge(n2, n3);
 		  check(g.valid(n1), "Wrong validity check");
 		  check(g.valid(e1), "Wrong validity check");
 		  check(g.valid(g.direct(e1, true)), "Wrong validity check");
 		  g.erase(n1);
 		  check(!g.valid(n1), "Wrong validity check");
 		  check(g.valid(n2), "Wrong validity check");
 		  check(g.valid(n3), "Wrong validity check");
 		  check(!g.valid(e1), "Wrong validity check");
 		  check(g.valid(e2), "Wrong validity check");
 		  check(!g.valid(g.nodeFromId(-1)), "Wrong validity check");
 		  check(!g.valid(g.edgeFromId(-1)), "Wrong validity check");
 		  check(!g.valid(g.arcFromId(-1)), "Wrong validity check");
+		}
 		void checkGridGraph(int width, int height) {
 		  typedef GridGraph Graph;
 		  GRAPH_TYPEDEFS(Graph);
 		  Graph G(width, height);
 		  check(G.width() == width, "Wrong column number");
 		  check(G.height() == height, "Wrong row number");
 		  G.resize(width, height);
 		  check(G.width() == width, "Wrong column number");
 		  check(G.height() == height, "Wrong row number");
 		  for (int i = 0; i < width; ++i) {
 		    for (int j = 0; j < height; ++j) {
 		      check(G.col(G(i, j)) == i, "Wrong column");
 		      check(G.row(G(i, j)) == j, "Wrong row");
 		      check(G.pos(G(i, j)).x == i, "Wrong column");
 		      check(G.pos(G(i, j)).y == j, "Wrong row");
+		    }
+		  }
 		  for (int j = 0; j < height; ++j) {
 		    for (int i = 0; i < width - 1; ++i) {
 		      check(G.source(G.right(G(i, j))) == G(i, j), "Wrong right");
 		      check(G.target(G.right(G(i, j))) == G(i + 1, j), "Wrong right");
+		    }
 		    check(G.right(G(width - 1, j)) == INVALID, "Wrong right");
+		  }
 		  for (int j = 0; j < height; ++j) {
 		    for (int i = 1; i < width; ++i) {
 		      check(G.source(G.left(G(i, j))) == G(i, j), "Wrong left");
 		      check(G.target(G.left(G(i, j))) == G(i - 1, j), "Wrong left");
+		    }
 		    check(G.left(G(0, j)) == INVALID, "Wrong left");
+		  }
 		  for (int i = 0; i < width; ++i) {

0 comments (0 inline)

RhodeCode

Login to your account