LEMON/LEMON-official Changeset - r465:31d224a3c0af

Repositories » LEMON » LEMON-official

Summary
Changelog
Files
Switch To
- loading...
Options
- Lightweight changelog
- Search
Pull Requests

Changeset - r465:31d224a3c0af

« 464:4f7224

466:de16f1 »

r465:31d224a3c0af

Tue, 02 Dec 2008 11:17:30

[Not Reviewed]

0 comments (0 inline)

alpar (Alpar Juttner)
alpar@cs.elte.hu

Doc improvements and source unification in radix_sort (#72)

0 2 0

default

2 files changed with 176 insertions and 174 deletions:

lemon/radix_sort.h

170

168

test/radix_sort_test.cc

↑ Collapse diff ↑

lemon/radix_sort.h

Show inline comments

 		/* -*- C++ -*-
+		/* -*- mode: C++; indent-tabs-mode: nil; -*-
+		 *
 		 * This file is a part of LEMON, a generic C++ optimization library
+		 * This file is a part of LEMON, a generic C++ optimization library.
+		 *
 		 * Copyright (C) 2003-2008
@@ -38,5 +38,5 @@
 		    struct Identity {
 		      const Value& operator()(const Value& val) {
-			return val;
+		        return val;
+		      }
 		    };
@@ -44,85 +44,85 @@
 		    template <typename Value, typename Iterator, typename Functor>
 		    Iterator radixSortPartition(Iterator first, Iterator last,
 						Functor functor, Value mask) {
 		    Iterator radixSortPartition(Iterator first, Iterator last,
 		                                Functor functor, Value mask) {
 		      while (first != last && !(functor(*first) & mask)) {
-			++first;
+		        ++first;
+		      }
 		      if (first == last) {
-			return first;
+		        return first;
+		      }
 		      --last;
 		      while (first != last && (functor(*last) & mask)) {
-			--last;
+		        --last;
+		      }
 		      if (first == last) {
-			return first;
+		        return first;
+		      }
 		      std::iter_swap(first, last);
 		      ++first;
 		      if (!(first < last)) {
-			return first;
+		        return first;
+		      }
 		      while (true) {
 			while (!(functor(*first) & mask)) {
 			  ++first;
+			}
 			--last;
 			while (functor(*last) & mask) {
 			  --last;
+			}
 			if (!(first < last)) {
 			  return first;
+			}
 			std::iter_swap(first, last);
 			++first;
 		        while (!(functor(*first) & mask)) {
 		          ++first;
+		        }
 		        --last;
 		        while (functor(*last) & mask) {
 		          --last;
+		        }
 		        if (!(first < last)) {
 		          return first;
+		        }
 		        std::iter_swap(first, last);
 		        ++first;
+		      }
+		    }
 		    template <typename Iterator, typename Functor>
 		    Iterator radixSortSignPartition(Iterator first, Iterator last,
 						    Functor functor) {
 		    Iterator radixSortSignPartition(Iterator first, Iterator last,
 		                                    Functor functor) {
 		      while (first != last && functor(*first) < 0) {
-			++first;
+		        ++first;
+		      }
 		      if (first == last) {
-			return first;
+		        return first;
+		      }
 		      --last;
 		      while (first != last && functor(*last) >= 0) {
-			--last;
+		        --last;
+		      }
 		      if (first == last) {
-			return first;
+		        return first;
+		      }
 		      std::iter_swap(first, last);
 		      ++first;
 		      if (!(first < last)) {
-			return first;
+		        return first;
+		      }
 		      while (true) {
 			while (functor(*first) < 0) {
 			  ++first;
+			}
 			--last;
 			while (functor(*last) >= 0) {
 			  --last;
+			}
 			if (!(first < last)) {
 			  return first;
+			}
 			std::iter_swap(first, last);
 			++first;
 		        while (functor(*first) < 0) {
 		          ++first;
+		        }
 		        --last;
 		        while (functor(*last) >= 0) {
 		          --last;
+		        }
 		        if (!(first < last)) {
 		          return first;
+		        }
 		        std::iter_swap(first, last);
 		        ++first;
+		      }
+		    }
 		    template <typename Value, typename Iterator, typename Functor>
 		    void radixIntroSort(Iterator first, Iterator last,
 					Functor functor, Value mask) {
 		    void radixIntroSort(Iterator first, Iterator last,
 		                        Functor functor, Value mask) {
 		      while (mask != 0 && last - first > 1) {
 			Iterator cut = radixSortPartition(first, last, functor, mask);
 			mask >>= 1;
 			radixIntroSort(first, cut, functor, mask);
 			first = cut;
 		        Iterator cut = radixSortPartition(first, last, functor, mask);
 		        mask >>= 1;
 		        radixIntroSort(first, cut, functor, mask);
 		        first = cut;
+		      }
+		    }
@@ -139,8 +139,8 @@
 		      mask = ~0; max_digit = 0;
 		      for (it = first; it != cut; ++it) {
 			while ((mask & functor(*it)) != mask) {
 			  ++max_digit;
 			  mask <<= 1;
+			}
 		        while ((mask & functor(*it)) != mask) {
 		          ++max_digit;
 		          mask <<= 1;
+		        }
+		      }
 		      radixIntroSort(first, cut, functor, 1 << max_digit);
@@ -148,8 +148,8 @@
 		      mask = 0; max_digit = 0;
 		      for (it = cut; it != last; ++it) {
 			while ((mask | functor(*it)) != mask) {
 			  ++max_digit;
 			  mask <<= 1; mask |= 1;
+			}
 		        while ((mask | functor(*it)) != mask) {
 		          ++max_digit;
 		          mask <<= 1; mask |= 1;
+		        }
+		      }
 		      radixIntroSort(cut, last, functor, 1 << max_digit);
@@ -164,8 +164,8 @@
 		      Iterator it;
 		      for (it = first; it != last; ++it) {
 			while ((mask | functor(*it)) != mask) {
 			  ++max_digit;
 			  mask <<= 1; mask |= 1;
+			}
 		        while ((mask | functor(*it)) != mask) {
 		          ++max_digit;
 		          mask <<= 1; mask |= 1;
+		        }
+		      }
 		      radixIntroSort(first, last, functor, 1 << max_digit);
@@ -173,10 +173,10 @@
 		    template <typename Value,
 			      bool sign = std::numeric_limits<Value>::is_signed >
 		    template <typename Value,
 		              bool sign = std::numeric_limits<Value>::is_signed >
 		    struct RadixSortSelector {
 		      template <typename Iterator, typename Functor>
 		      static void sort(Iterator first, Iterator last, Functor functor) {
-			radixSignedSort<Value>(first, last, functor);
+		        radixSignedSort<Value>(first, last, functor);
+		      }
 		    };
@@ -186,5 +186,5 @@
 		      template <typename Iterator, typename Functor>
 		      static void sort(Iterator first, Iterator last, Functor functor) {
-			radixUnsignedSort<Value>(first, last, functor);
+		        radixUnsignedSort<Value>(first, last, functor);
+		      }
 		    };
@@ -196,18 +196,19 @@
 		  /// \brief Sorts the STL compatible range into ascending order.
 		  ///
 		  /// The \c radixSort sorts the STL compatible range into ascending
 		  /// order.  The radix sort algorithm can sort the items which mapped
 		  /// to an integer with an adaptable unary function \c functor and the
 		  /// order will be ascending by these mapped values. As function
 		  /// specialization it is possible to use a normal function instead
 		  /// of the functor object or if the functor is not given it will use
-		  /// an identity function instead.
+		  /// The \c radixSort sorts an STL compatible range into ascending
 		  /// order.  The radix sort algorithm can sort items which are mapped
 		  /// to integers with an adaptable unary function \c functor and the
 		  /// order will be ascending according to these mapped values.
 		  ///
 		  /// This implemented radix sort is a special quick sort which pivot
 		  /// value is choosen to partite the items on the next
 		  /// bit. Therefore, let be \c c the maximal capacity and \c n the
 		  /// number of the items in the container, the time complexity of the
 		  /// algorithm is \f$ O(\log(c)n) \f$ and the additional space
 		  /// complexity is \f$ O(\log(c)) \f$.
 		  /// It is also possible to use a normal function instead
 		  /// of the functor object. If the functor is not given it will use
 		  /// the identity function instead.
 		  ///
 		  /// This is a special quick sort algorithm where the pivot
 		  /// values to split the items are choosen to be \f$ 2^k \f$ for each \c k.
 		  /// Therefore, the time complexity of the
 		  /// algorithm is \f$ O(\log(c)n) \f$ and it uses \f$ O(\log(c)) \f$,
 		  /// additional space, where \c c is the maximal value and \c n is the
 		  /// number of the items in the container.
 		  ///
 		  /// \param first The begin of the given range.
@@ -216,4 +217,6 @@
 		  /// which maps the items to any integer type which can be either
 		  /// signed or unsigned.
 		  ///
 		  /// \sa counterSort()
 		  template <typename Iterator, typename Functor>
 		  void radixSort(Iterator first, Iterator last, Functor functor) {
@@ -262,61 +265,61 @@
 		    template <typename Functor, typename Key>
 		    void counterIntroSort(Key *first, Key *last, Key *target,
 					  int byte, Functor functor) {
 		      const int size =
 			unsigned(std::numeric_limits<unsigned char>::max()) + 1;
 		    void counterIntroSort(Key *first, Key *last, Key *target,
 		                          int byte, Functor functor) {
 		      const int size =
 		        unsigned(std::numeric_limits<unsigned char>::max()) + 1;
 		      std::vector<int> counter(size);
 		      for (int i = 0; i < size; ++i) {
-			counter[i] = 0;
+		        counter[i] = 0;
+		      }
 		      Key *it = first;
 		      while (first != last) {
 			++counter[valueByte(functor(*first), byte)];
 			++first;
 		        ++counter[valueByte(functor(*first), byte)];
 		        ++first;
+		      }
 		      int prev, num = 0;
 		      for (int i = 0; i < size; ++i) {
 			prev = num;
 			num += counter[i];
-			counter[i] = prev;
+		        prev = num;
 		        num += counter[i];
 		        counter[i] = prev;
+		      }
 		      while (it != last) {
 			target[counter[valueByte(functor(*it), byte)]++] = *it;
 			++it;
 		        target[counter[valueByte(functor(*it), byte)]++] = *it;
 		        ++it;
+		      }
+		    }
 		    template <typename Functor, typename Key>
 		    void signedCounterIntroSort(Key *first, Key *last, Key *target,
 						int byte, Functor functor) {
 		      const int size =
 			unsigned(std::numeric_limits<unsigned char>::max()) + 1;
 		    void signedCounterIntroSort(Key *first, Key *last, Key *target,
 		                                int byte, Functor functor) {
 		      const int size =
 		        unsigned(std::numeric_limits<unsigned char>::max()) + 1;
 		      std::vector<int> counter(size);
 		      for (int i = 0; i < size; ++i) {
-			counter[i] = 0;
+		        counter[i] = 0;
+		      }
 		      Key *it = first;
 		      while (first != last) {
 			counter[valueByte(functor(*first), byte)]++;
 			++first;
 		        counter[valueByte(functor(*first), byte)]++;
 		        ++first;
+		      }
 		      int prev, num = 0;
 		      for (int i = size / 2; i < size; ++i) {
 			prev = num;
 			num += counter[i];
-			counter[i] = prev;
+		        prev = num;
 		        num += counter[i];
 		        counter[i] = prev;
+		      }
 		      for (int i = 0; i < size / 2; ++i) {
 			prev = num;
 			num += counter[i];
-			counter[i] = prev;
+		        prev = num;
 		        num += counter[i];
 		        counter[i] = prev;
+		      }
 		      while (it != last) {
 			target[counter[valueByte(functor(*it), byte)]++] = *it;
 			++it;
 		        target[counter[valueByte(functor(*it), byte)]++] = *it;
 		        ++it;
+		      }
+		    }
 		    template <typename Value, typename Iterator, typename Functor>
 		    void counterSignedSort(Iterator first, Iterator last, Functor functor) {
@@ -329,28 +332,28 @@
 		      Key* buffer = allocator.allocate(2 * length);
 		      try {
 			bool dir = true;
 			std::copy(first, last, buffer);
 			for (int i = 0; i < int(sizeof(Value)) - 1; ++i) {
 			  if (dir) {
 			    counterIntroSort(buffer, buffer + length, buffer + length,
 					     i, functor);
 			  } else {
 			    counterIntroSort(buffer + length, buffer + 2 * length, buffer,
 					     i, functor);
+			  }
 			  dir = !dir;
+			}
 			if (dir) {
 			  signedCounterIntroSort(buffer, buffer + length, buffer + length,
 						 sizeof(Value) - 1, functor);
 			  std::copy(buffer + length, buffer + 2 * length, first);
 			}	else {
 			  signedCounterIntroSort(buffer + length, buffer + 2 * length, buffer,
 						 sizeof(Value) - 1, functor);
 			  std::copy(buffer, buffer + length, first);
+			}
+		        bool dir = true;
 		        std::copy(first, last, buffer);
 		        for (int i = 0; i < int(sizeof(Value)) - 1; ++i) {
 		          if (dir) {
 		            counterIntroSort(buffer, buffer + length, buffer + length,
 		                             i, functor);
 		          } else {
 		            counterIntroSort(buffer + length, buffer + 2 * length, buffer,
 		                             i, functor);
+		          }
 		          dir = !dir;
+		        }
 		        if (dir) {
 		          signedCounterIntroSort(buffer, buffer + length, buffer + length,
 		                                 sizeof(Value) - 1, functor);
 		          std::copy(buffer + length, buffer + 2 * length, first);
 		        }        else {
 		          signedCounterIntroSort(buffer + length, buffer + 2 * length, buffer,
 		                                 sizeof(Value) - 1, functor);
 		          std::copy(buffer, buffer + length, first);
+		        }
 		      } catch (...) {
 			allocator.deallocate(buffer, 2 * length);
 			throw;
 		        allocator.deallocate(buffer, 2 * length);
 		        throw;
+		      }
 		      allocator.deallocate(buffer, 2 * length);
@@ -367,24 +370,24 @@
 		      Key *buffer = allocator.allocate(2 * length);
 		      try {
 			bool dir = true;
 			std::copy(first, last, buffer);
 			for (int i = 0; i < int(sizeof(Value)); ++i) {
 			  if (dir) {
 			    counterIntroSort(buffer, buffer + length,
 					     buffer + length, i, functor);
 			  } else {
 			    counterIntroSort(buffer + length, buffer + 2 * length,
 					     buffer, i, functor);
+			  }
 			  dir = !dir;
+			}
 			if (dir) {
 			  std::copy(buffer, buffer + length, first);
 			}	else {
 			  std::copy(buffer + length, buffer + 2 * length, first);
+			}
+		        bool dir = true;
 		        std::copy(first, last, buffer);
 		        for (int i = 0; i < int(sizeof(Value)); ++i) {
 		          if (dir) {
 		            counterIntroSort(buffer, buffer + length,
 		                             buffer + length, i, functor);
 		          } else {
 		            counterIntroSort(buffer + length, buffer + 2 * length,
 		                             buffer, i, functor);
+		          }
 		          dir = !dir;
+		        }
 		        if (dir) {
 		          std::copy(buffer, buffer + length, first);
 		        }        else {
 		          std::copy(buffer + length, buffer + 2 * length, first);
+		        }
 		      } catch (...) {
 			allocator.deallocate(buffer, 2 * length);
 			throw;
 		        allocator.deallocate(buffer, 2 * length);
 		        throw;
+		      }
 		      allocator.deallocate(buffer, 2 * length);
@@ -393,10 +396,10 @@
 		    template <typename Value,
 			      bool sign = std::numeric_limits<Value>::is_signed >
 		    template <typename Value,
 		              bool sign = std::numeric_limits<Value>::is_signed >
 		    struct CounterSortSelector {
 		      template <typename Iterator, typename Functor>
 		      static void sort(Iterator first, Iterator last, Functor functor) {
-			counterSignedSort<Value>(first, last, functor);
+		        counterSignedSort<Value>(first, last, functor);
+		      }
 		    };
@@ -406,5 +409,5 @@
 		      template <typename Iterator, typename Functor>
 		      static void sort(Iterator first, Iterator last, Functor functor) {
-			counterUnsignedSort<Value>(first, last, functor);
+		        counterUnsignedSort<Value>(first, last, functor);
+		      }
 		    };
@@ -414,27 +417,25 @@
 		  /// \ingroup auxalg
 		  ///
-		  /// \brief Sorts stable the STL compatible range into ascending order.
+		  /// \brief Sorts the STL compatible range into ascending order in a stable
 		  /// way.
 		  ///
 		  /// The \c counterSort sorts the STL compatible range into ascending
 		  /// order.  The counter sort algorithm can sort the items which
 		  /// mapped to an integer with an adaptable unary function \c functor
 		  /// and the order will be ascending by these mapped values. As
 		  /// function specialization it is possible to use a normal function
 		  /// instead of the functor object or if the functor is not given it
-		  /// will use an identity function instead.
+		  /// This function sorts an STL compatible range into ascending
 		  /// order according to an integer mapping in the same as radixSort() does.
 		  ///
-		  /// The implemented counter sort use a radix forward sort on the
+		  /// This sorting algorithm is stable, i.e. the order of two equal
 		  /// element remains the same after the sorting.
 		  ///
 		  /// This sort algorithm  use a radix forward sort on the
 		  /// bytes of the integer number. The algorithm sorts the items
 		  /// byte-by-byte, first it counts how many times occurs a byte value
 		  /// in the containerm, and with the occurence number the container
 		  /// can be copied to an other in asceding order in \c O(n) time.
 		  /// Let be \c c the maximal capacity of the integer type and \c n
 		  /// the number of the items in the container, the time complexity of
 		  /// the algorithm is \f$ O(\log(c)n) \f$ and the additional space
-		  /// complexity is \f$ O(n) \f$.
+		  /// byte-by-byte. First, it counts how many times a byte value occurs
 		  /// in the container, then it copies the corresponding items to
 		  /// another container in asceding order in \c O(n) time.
 		  ///
 		  /// The sorting algorithm is stable, i.e. the order of two equal
 		  /// element remains the same.
 		  /// The time complexity of the algorithm is \f$ O(\log(c)n) \f$ and
 		  /// it uses \f$ O(n) \f$, additional space, where \c c is the
 		  /// maximal value and \c n is the number of the items in the
 		  /// container.
 		  ///
 		  /// \param first The begin of the given range.
 		  /// \param last The end of the given range.
@@ -442,4 +443,5 @@
 		  /// which maps the items to any integer type which can be either
 		  /// signed or unsigned.
 		  /// \sa radixSort()
 		  template <typename Iterator, typename Functor>
 		  void counterSort(Iterator first, Iterator last, Functor functor) {

test/radix_sort_test.cc

Show inline comments

/* -*- C++ -*-
/* -*- mode: C++; indent-tabs-mode: nil; -*-
 *
 * This file is a part of LEMON, a generic C++ optimization library
 * This file is a part of LEMON, a generic C++ optimization library.
 *
 * Copyright (C) 2003-2008
@@ -82,6 +82,6 @@
    }

  } 
  
  }

  {
    std::vector<unsigned char> data1(n);
@@ -122,5 +122,5 @@
      check(data1[i] == data2[n - 1 - i], "Test failed");
    }
  } 
  }

  {
@@ -141,5 +141,5 @@
int main() {

  checkRadixSort();  
  checkRadixSort();
  checkCounterSort();


0 comments (0 inline)

RhodeCode

Login to your account

1		/* -- C++ --
	1	/* -- mode: C++; indent-tabs-mode: nil; --
2	2	*
3		* This file is a part of LEMON, a generic C++ optimization library
	3	* This file is a part of LEMON, a generic C++ optimization library.
4	4	*
5	5	* Copyright (C) 2003-2008
...	...	@@ -82,6 +82,6 @@
82	82	}
83	83
84		}
85
	84	}
	85
86	86	{
87	87	std::vector<unsigned char> data1(n);
...	...	@@ -122,5 +122,5 @@
122	122	check(data1[i] == data2[n - 1 - i], "Test failed");
123	123	}
124		}
	124	}
125	125
126	126	{
...	...	@@ -141,5 +141,5 @@
141	141	int main() {
142	142
143		checkRadixSort();
	143	checkRadixSort();
144	144	checkCounterSort();
145	145