Changeset 864:d3ea191c3412 in lemon-main

Timestamp:

03/13/10 22:01:38 (15 years ago)

Author:

Peter Kovacs <kpeter@…>

Branch:

default

Phase:

public

Message:

Rename min mean cycle classes and their members (#179)
with respect to the possible introduction of min ratio
cycle algorithms in the future.

The renamed classes:

• Karp --> KarpMmc?
• HartmannOrlin? --> HartmannOrlinMmc?
• Howard --> HowardMmc?

The renamed members:

• cycleLength() --> cycleCost()
• cycleArcNum() --> cycleSize()
• findMinMean() --> findCycleMean()
• Value --> Cost
• LargeValue? --> LargeCost?
• SetLargeValue? --> SetLargeCost?

Files:

• lemon/Makefile.am (modified) (1 diff)
• lemon/cycle_canceling.h (modified) (5 diffs)
• lemon/hartmann_orlin_mmc.h (moved) (moved from lemon/hartmann_orlin.h) (40 diffs)
• lemon/howard_mmc.h (moved) (moved from lemon/howard.h) (33 diffs)
• lemon/karp_mmc.h (moved) (moved from lemon/karp.h) (34 diffs)
• test/min_mean_cycle_test.cc (modified) (7 diffs)

lemon/Makefile.am

@@ -90 +90 @@
         lemon/graph_to_eps.h \
         lemon/grid_graph.h \
-        lemon/hartmann_orlin.h \
-        lemon/howard.h \
+        lemon/hartmann_orlin_mmc.h \
+        lemon/howard_mmc.h \
         lemon/hypercube_graph.h \
-        lemon/karp.h \
+        lemon/karp_mmc.h \
         lemon/kruskal.h \
         lemon/hao_orlin.h \

lemon/cycle_canceling.h

@@ -35 +35 @@
 #include <lemon/circulation.h>
 #include <lemon/bellman_ford.h>
-#include <lemon/howard.h>
+#include <lemon/howard_mmc.h>
 
 namespace lemon {
@@ -925 +925 @@
       typedef SimplePath<StaticDigraph> SPath;
       typedef typename SPath::ArcIt SPathArcIt;
-      typedef typename Howard<StaticDigraph, CostArcMap>
+      typedef typename HowardMmc<StaticDigraph, CostArcMap>
         ::template SetPath<SPath>::Create MMC;
       
@@ -932 +932 @@
       mmc.cycle(cycle);
       buildResidualNetwork();
-      while (mmc.findMinMean() && mmc.cycleLength() < 0) {
+      while (mmc.findCycleMean() && mmc.cycleCost() < 0) {
         // Find the cycle
         mmc.findCycle();
@@ -1133 +1133 @@
           }
         } else {
-          typedef Howard<StaticDigraph, CostArcMap> MMC;
+          typedef HowardMmc<StaticDigraph, CostArcMap> MMC;
           typedef typename BellmanFord<StaticDigraph, CostArcMap>
             ::template SetDistMap<CostNodeMap>::Create BF;
@@ -1140 +1140 @@
           buildResidualNetwork();
           MMC mmc(_sgr, _cost_map);
-          mmc.findMinMean();
+          mmc.findCycleMean();
           epsilon = -mmc.cycleMean();
-          Cost cycle_cost = mmc.cycleLength();
-          int cycle_size = mmc.cycleArcNum();
+          Cost cycle_cost = mmc.cycleCost();
+          int cycle_size = mmc.cycleSize();
           
           // Compute feasible potentials for the current epsilon

lemon/hartmann_orlin_mmc.h

@@ -17 +17 @@
  */
 
-#ifndef LEMON_HARTMANN_ORLIN_H
-#define LEMON_HARTMANN_ORLIN_H
+#ifndef LEMON_HARTMANN_ORLIN_MMC_H
+#define LEMON_HARTMANN_ORLIN_MMC_H
 
 /// \ingroup min_mean_cycle
@@ -34 +34 @@
 namespace lemon {
 
-  /// \brief Default traits class of HartmannOrlin algorithm.
+  /// \brief Default traits class of HartmannOrlinMmc class.
   ///
-  /// Default traits class of HartmannOrlin algorithm.
+  /// Default traits class of HartmannOrlinMmc class.
   /// \tparam GR The type of the digraph.
-  /// \tparam LEN The type of the length map.
+  /// \tparam CM The type of the cost map.
   /// It must conform to the \ref concepts::Rea_data "Rea_data" concept.
 #ifdef DOXYGEN
-  template <typename GR, typename LEN>
+  template <typename GR, typename CM>
 #else
-  template <typename GR, typename LEN,
-    bool integer = std::numeric_limits<typename LEN::Value>::is_integer>
+  template <typename GR, typename CM,
+    bool integer = std::numeric_limits<typename CM::Value>::is_integer>
 #endif
-  struct HartmannOrlinDefaultTraits
+  struct HartmannOrlinMmcDefaultTraits
   {
     /// The type of the digraph
     typedef GR Digraph;
-    /// The type of the length map
-    typedef LEN LengthMap;
-    /// The type of the arc lengths
-    typedef typename LengthMap::Value Value;
-
-    /// \brief The large value type used for internal computations
-    ///
-    /// The large value type used for internal computations.
-    /// It is \c long \c long if the \c Value type is integer,
+    /// The type of the cost map
+    typedef CM CostMap;
+    /// The type of the arc costs
+    typedef typename CostMap::Value Cost;
+
+    /// \brief The large cost type used for internal computations
+    ///
+    /// The large cost type used for internal computations.
+    /// It is \c long \c long if the \c Cost type is integer,
     /// otherwise it is \c double.
-    /// \c Value must be convertible to \c LargeValue.
-    typedef double LargeValue;
+    /// \c Cost must be convertible to \c LargeCost.
+    typedef double LargeCost;
 
     /// The tolerance type used for internal computations
-    typedef lemon::Tolerance<LargeValue> Tolerance;
+    typedef lemon::Tolerance<LargeCost> Tolerance;
 
     /// \brief The path type of the found cycles
@@ -74 +74 @@
   };
 
-  // Default traits class for integer value types
-  template <typename GR, typename LEN>
-  struct HartmannOrlinDefaultTraits<GR, LEN, true>
+  // Default traits class for integer cost types
+  template <typename GR, typename CM>
+  struct HartmannOrlinMmcDefaultTraits<GR, CM, true>
   {
     typedef GR Digraph;
-    typedef LEN LengthMap;
-    typedef typename LengthMap::Value Value;
+    typedef CM CostMap;
+    typedef typename CostMap::Value Cost;
 #ifdef LEMON_HAVE_LONG_LONG
-    typedef long long LargeValue;
+    typedef long long LargeCost;
 #else
-    typedef long LargeValue;
+    typedef long LargeCost;
 #endif
-    typedef lemon::Tolerance<LargeValue> Tolerance;
+    typedef lemon::Tolerance<LargeCost> Tolerance;
     typedef lemon::Path<Digraph> Path;
   };
@@ -98 +98 @@
   ///
   /// This class implements the Hartmann-Orlin algorithm for finding
-  /// a directed cycle of minimum mean length (cost) in a digraph
+  /// a directed cycle of minimum mean cost in a digraph
   /// \ref amo93networkflows, \ref dasdan98minmeancycle.
   /// It is an improved version of \ref Karp "Karp"'s original algorithm,
@@ -105 +105 @@
   ///
   /// \tparam GR The type of the digraph the algorithm runs on.
-  /// \tparam LEN The type of the length map. The default
+  /// \tparam CM The type of the cost map. The default
   /// map type is \ref concepts::Digraph::ArcMap "GR::ArcMap<int>".
   /// \tparam TR The traits class that defines various types used by the
-  /// algorithm. By default, it is \ref HartmannOrlinDefaultTraits
-  /// "HartmannOrlinDefaultTraits<GR, LEN>".
+  /// algorithm. By default, it is \ref HartmannOrlinMmcDefaultTraits
+  /// "HartmannOrlinMmcDefaultTraits<GR, CM>".
   /// In most cases, this parameter should not be set directly,
   /// consider to use the named template parameters instead.
 #ifdef DOXYGEN
-  template <typename GR, typename LEN, typename TR>
+  template <typename GR, typename CM, typename TR>
 #else
   template < typename GR,
-             typename LEN = typename GR::template ArcMap<int>,
-             typename TR = HartmannOrlinDefaultTraits<GR, LEN> >
+             typename CM = typename GR::template ArcMap<int>,
+             typename TR = HartmannOrlinMmcDefaultTraits<GR, CM> >
 #endif
-  class HartmannOrlin
+  class HartmannOrlinMmc
   {
   public:
@@ -125 +125 @@
     /// The type of the digraph
     typedef typename TR::Digraph Digraph;
-    /// The type of the length map
-    typedef typename TR::LengthMap LengthMap;
-    /// The type of the arc lengths
-    typedef typename TR::Value Value;
-
-    /// \brief The large value type
-    ///
-    /// The large value type used for internal computations.
-    /// By default, it is \c long \c long if the \c Value type is integer,
+    /// The type of the cost map
+    typedef typename TR::CostMap CostMap;
+    /// The type of the arc costs
+    typedef typename TR::Cost Cost;
+
+    /// \brief The large cost type
+    ///
+    /// The large cost type used for internal computations.
+    /// By default, it is \c long \c long if the \c Cost type is integer,
     /// otherwise it is \c double.
-    typedef typename TR::LargeValue LargeValue;
+    typedef typename TR::LargeCost LargeCost;
 
     /// The tolerance type
@@ -143 +143 @@
     ///
     /// The path type of the found cycles.
-    /// Using the \ref HartmannOrlinDefaultTraits "default traits class",
+    /// Using the \ref HartmannOrlinMmcDefaultTraits "default traits class",
     /// it is \ref lemon::Path "Path<Digraph>".
     typedef typename TR::Path Path;
 
-    /// The \ref HartmannOrlinDefaultTraits "traits class" of the algorithm
+    /// The \ref HartmannOrlinMmcDefaultTraits "traits class" of the algorithm
     typedef TR Traits;
 
@@ -157 +157 @@
     struct PathData
     {
-      LargeValue dist;
+      LargeCost dist;
       Arc pred;
-      PathData(LargeValue d, Arc p = INVALID) :
+      PathData(LargeCost d, Arc p = INVALID) :
         dist(d), pred(p) {}
     };
@@ -170 +170 @@
     // The digraph the algorithm runs on
     const Digraph &_gr;
-    // The length of the arcs
-    const LengthMap &_length;
+    // The cost of the arcs
+    const CostMap &_cost;
 
     // Data for storing the strongly connected components
@@ -182 +182 @@
     // Data for the found cycles
     bool _curr_found, _best_found;
-    LargeValue _curr_length, _best_length;
+    LargeCost _curr_cost, _best_cost;
     int _curr_size, _best_size;
     Node _curr_node, _best_node;
@@ -198 +198 @@
 
     // Infinite constant
-    const LargeValue INF;
+    const LargeCost INF;
 
   public:
@@ -206 +206 @@
 
     template <typename T>
-    struct SetLargeValueTraits : public Traits {
-      typedef T LargeValue;
+    struct SetLargeCostTraits : public Traits {
+      typedef T LargeCost;
       typedef lemon::Tolerance<T> Tolerance;
     };
 
     /// \brief \ref named-templ-param "Named parameter" for setting
-    /// \c LargeValue type.
-    ///
-    /// \ref named-templ-param "Named parameter" for setting \c LargeValue
+    /// \c LargeCost type.
+    ///
+    /// \ref named-templ-param "Named parameter" for setting \c LargeCost
     /// type. It is used for internal computations in the algorithm.
     template <typename T>
-    struct SetLargeValue
-      : public HartmannOrlin<GR, LEN, SetLargeValueTraits<T> > {
-      typedef HartmannOrlin<GR, LEN, SetLargeValueTraits<T> > Create;
+    struct SetLargeCost
+      : public HartmannOrlinMmc<GR, CM, SetLargeCostTraits<T> > {
+      typedef HartmannOrlinMmc<GR, CM, SetLargeCostTraits<T> > Create;
     };
 
@@ -236 +236 @@
     template <typename T>
     struct SetPath
-      : public HartmannOrlin<GR, LEN, SetPathTraits<T> > {
-      typedef HartmannOrlin<GR, LEN, SetPathTraits<T> > Create;
+      : public HartmannOrlinMmc<GR, CM, SetPathTraits<T> > {
+      typedef HartmannOrlinMmc<GR, CM, SetPathTraits<T> > Create;
     };
 
@@ -244 +244 @@
   protected:
 
-    HartmannOrlin() {}
+    HartmannOrlinMmc() {}
 
   public:
@@ -253 +253 @@
     ///
     /// \param digraph The digraph the algorithm runs on.
-    /// \param length The lengths (costs) of the arcs.
-    HartmannOrlin( const Digraph &digraph,
-                   const LengthMap &length ) :
-      _gr(digraph), _length(length), _comp(digraph), _out_arcs(digraph),
-      _best_found(false), _best_length(0), _best_size(1),
+    /// \param cost The costs of the arcs.
+    HartmannOrlinMmc( const Digraph &digraph,
+                      const CostMap &cost ) :
+      _gr(digraph), _cost(cost), _comp(digraph), _out_arcs(digraph),
+      _best_found(false), _best_cost(0), _best_size(1),
       _cycle_path(NULL), _local_path(false), _data(digraph),
-      INF(std::numeric_limits<LargeValue>::has_infinity ?
-          std::numeric_limits<LargeValue>::infinity() :
-          std::numeric_limits<LargeValue>::max())
+      INF(std::numeric_limits<LargeCost>::has_infinity ?
+          std::numeric_limits<LargeCost>::infinity() :
+          std::numeric_limits<LargeCost>::max())
     {}
 
     /// Destructor.
-    ~HartmannOrlin() {
+    ~HartmannOrlinMmc() {
       if (_local_path) delete _cycle_path;
     }
@@ -275 +275 @@
     ///
     /// If you don't call this function before calling \ref run() or
-    /// \ref findMinMean(), it will allocate a local \ref Path "path"
+    /// \ref findCycleMean(), it will allocate a local \ref Path "path"
     /// structure. The destuctor deallocates this automatically
     /// allocated object, of course.
@@ -283 +283 @@
     ///
     /// \return <tt>(*this)</tt>
-    HartmannOrlin& cycle(Path &path) {
+    HartmannOrlinMmc& cycle(Path &path) {
       if (_local_path) {
         delete _cycle_path;
@@ -297 +297 @@
     ///
     /// \return <tt>(*this)</tt>
-    HartmannOrlin& tolerance(const Tolerance& tolerance) {
+    HartmannOrlinMmc& tolerance(const Tolerance& tolerance) {
       _tolerance = tolerance;
       return *this;
@@ -313 +313 @@
     /// The simplest way to execute the algorithm is to call the \ref run()
     /// function.\n
-    /// If you only need the minimum mean length, you may call
-    /// \ref findMinMean().
+    /// If you only need the minimum mean cost, you may call
+    /// \ref findCycleMean().
 
     /// @{
@@ -322 +322 @@
     /// This function runs the algorithm.
     /// It can be called more than once (e.g. if the underlying digraph
-    /// and/or the arc lengths have been modified).
+    /// and/or the arc costs have been modified).
     ///
     /// \return \c true if a directed cycle exists in the digraph.
@@ -328 +328 @@
     /// \note <tt>mmc.run()</tt> is just a shortcut of the following code.
     /// \code
-    ///   return mmc.findMinMean() && mmc.findCycle();
+    ///   return mmc.findCycleMean() && mmc.findCycle();
     /// \endcode
     bool run() {
-      return findMinMean() && findCycle();
+      return findCycleMean() && findCycle();
     }
 
     /// \brief Find the minimum cycle mean.
     ///
-    /// This function finds the minimum mean length of the directed
+    /// This function finds the minimum mean cost of the directed
     /// cycles in the digraph.
     ///
     /// \return \c true if a directed cycle exists in the digraph.
-    bool findMinMean() {
+    bool findCycleMean() {
       // Initialization and find strongly connected components
       init();
@@ -352 +352 @@
         // Update the best cycle (global minimum mean cycle)
         if ( _curr_found && (!_best_found || 
-             _curr_length * _best_size < _best_length * _curr_size) ) {
+             _curr_cost * _best_size < _best_cost * _curr_size) ) {
           _best_found = true;
-          _best_length = _curr_length;
+          _best_cost = _curr_cost;
           _best_size = _curr_size;
           _best_node = _curr_node;
@@ -365 +365 @@
     /// \brief Find a minimum mean directed cycle.
     ///
-    /// This function finds a directed cycle of minimum mean length
-    /// in the digraph using the data computed by findMinMean().
+    /// This function finds a directed cycle of minimum mean cost
+    /// in the digraph using the data computed by findCycleMean().
     ///
     /// \return \c true if a directed cycle exists in the digraph.
     ///
-    /// \pre \ref findMinMean() must be called before using this function.
+    /// \pre \ref findCycleMean() must be called before using this function.
     bool findCycle() {
       if (!_best_found) return false;
@@ -383 +383 @@
       Arc e = _data[u][r].pred;
       _cycle_path->addFront(e);
-      _best_length = _length[e];
+      _best_cost = _cost[e];
       _best_size = 1;
       Node v;
@@ -389 +389 @@
         e = _data[v][--r].pred;
         _cycle_path->addFront(e);
-        _best_length += _length[e];
+        _best_cost += _cost[e];
         ++_best_size;
       }
@@ -404 +404 @@
     /// @{
 
-    /// \brief Return the total length of the found cycle.
-    ///
-    /// This function returns the total length of the found cycle.
-    ///
-    /// \pre \ref run() or \ref findMinMean() must be called before
+    /// \brief Return the total cost of the found cycle.
+    ///
+    /// This function returns the total cost of the found cycle.
+    ///
+    /// \pre \ref run() or \ref findCycleMean() must be called before
     /// using this function.
-    Value cycleLength() const {
-      return static_cast<Value>(_best_length);
+    Cost cycleCost() const {
+      return static_cast<Cost>(_best_cost);
     }
 
@@ -418 +418 @@
     /// This function returns the number of arcs on the found cycle.
     ///
-    /// \pre \ref run() or \ref findMinMean() must be called before
+    /// \pre \ref run() or \ref findCycleMean() must be called before
     /// using this function.
-    int cycleArcNum() const {
+    int cycleSize() const {
       return _best_size;
     }
 
-    /// \brief Return the mean length of the found cycle.
-    ///
-    /// This function returns the mean length of the found cycle.
+    /// \brief Return the mean cost of the found cycle.
+    ///
+    /// This function returns the mean cost of the found cycle.
     ///
     /// \note <tt>alg.cycleMean()</tt> is just a shortcut of the
     /// following code.
     /// \code
-    ///   return static_cast<double>(alg.cycleLength()) / alg.cycleArcNum();
+    ///   return static_cast<double>(alg.cycleCost()) / alg.cycleSize();
     /// \endcode
     ///
-    /// \pre \ref run() or \ref findMinMean() must be called before
+    /// \pre \ref run() or \ref findCycleMean() must be called before
     /// using this function.
     double cycleMean() const {
-      return static_cast<double>(_best_length) / _best_size;
+      return static_cast<double>(_best_cost) / _best_size;
     }
 
@@ -463 +463 @@
       _cycle_path->clear();
       _best_found = false;
-      _best_length = 0;
+      _best_cost = 0;
       _best_size = 1;
       _cycle_path->clear();
@@ -512 +512 @@
 
     // Process all rounds of computing path data for the current component.
-    // _data[v][k] is the length of a shortest directed walk from the root
+    // _data[v][k] is the cost of a shortest directed walk from the root
     // node to node v containing exactly k arcs.
     void processRounds() {
@@ -544 +544 @@
       Node u, v;
       Arc e;
-      LargeValue d;
+      LargeCost d;
       for (int i = 0; i < int(_process.size()); ++i) {
         u = _process[i];
@@ -550 +550 @@
           e = _out_arcs[u][j];
           v = _gr.target(e);
-          d = _data[u][k-1].dist + _length[e];
+          d = _data[u][k-1].dist + _cost[e];
           if (_tolerance.less(d, _data[v][k].dist)) {
             if (_data[v][k].dist == INF) next.push_back(v);
@@ -564 +564 @@
       Node u, v;
       Arc e;
-      LargeValue d;
+      LargeCost d;
       for (int i = 0; i < int(_nodes->size()); ++i) {
         u = (*_nodes)[i];
@@ -570 +570 @@
           e = _out_arcs[u][j];
           v = _gr.target(e);
-          d = _data[u][k-1].dist + _length[e];
+          d = _data[u][k-1].dist + _cost[e];
           if (_tolerance.less(d, _data[v][k].dist)) {
             _data[v][k] = PathData(d, e);
@@ -582 +582 @@
       typedef std::pair<int, int> Pair;
       typename GR::template NodeMap<Pair> level(_gr, Pair(-1, 0));
-      typename GR::template NodeMap<LargeValue> pi(_gr);
+      typename GR::template NodeMap<LargeCost> pi(_gr);
       int n = _nodes->size();
-      LargeValue length;
+      LargeCost cost;
       int size;
       Node u;
@@ -596 +596 @@
           if (level[u].first == i && level[u].second > 0) {
             // A cycle is found
-            length = _data[u][level[u].second].dist - _data[u][j].dist;
+            cost = _data[u][level[u].second].dist - _data[u][j].dist;
             size = level[u].second - j;
-            if (!_curr_found || length * _curr_size < _curr_length * size) {
-              _curr_length = length;
+            if (!_curr_found || cost * _curr_size < _curr_cost * size) {
+              _curr_cost = cost;
               _curr_size = size;
               _curr_node = u;
@@ -614 +614 @@
 
       // If at least one cycle is found, check the optimality condition
-      LargeValue d;
+      LargeCost d;
       if (_curr_found && k < n) {
         // Find node potentials
@@ -622 +622 @@
           for (int j = 0; j <= k; ++j) {
             if (_data[u][j].dist < INF) {
-              d = _data[u][j].dist * _curr_size - j * _curr_length;
+              d = _data[u][j].dist * _curr_size - j * _curr_cost;
               if (_tolerance.less(d, pi[u])) pi[u] = d;
             }
@@ -631 +631 @@
         bool done = true;
         for (ArcIt a(_gr); a != INVALID; ++a) {
-          if (_tolerance.less(_length[a] * _curr_size - _curr_length,
+          if (_tolerance.less(_cost[a] * _curr_size - _curr_cost,
                               pi[_gr.target(a)] - pi[_gr.source(a)]) ) {
             done = false;
@@ -642 +642 @@
     }
 
-  }; //class HartmannOrlin
+  }; //class HartmannOrlinMmc
 
   ///@}
@@ -648 +648 @@
 } //namespace lemon
 
-#endif //LEMON_HARTMANN_ORLIN_H
+#endif //LEMON_HARTMANN_ORLIN_MMC_H

lemon/howard_mmc.h

@@ -17 +17 @@
  */
 
-#ifndef LEMON_HOWARD_H
-#define LEMON_HOWARD_H
+#ifndef LEMON_HOWARD_MMC_H
+#define LEMON_HOWARD_MMC_H
 
 /// \ingroup min_mean_cycle
@@ -34 +34 @@
 namespace lemon {
 
-  /// \brief Default traits class of Howard class.
+  /// \brief Default traits class of HowardMmc class.
   ///
-  /// Default traits class of Howard class.
+  /// Default traits class of HowardMmc class.
   /// \tparam GR The type of the digraph.
-  /// \tparam LEN The type of the length map.
+  /// \tparam CM The type of the cost map.
   /// It must conform to the \ref concepts::ReadMap "ReadMap" concept.
 #ifdef DOXYGEN
-  template <typename GR, typename LEN>
+  template <typename GR, typename CM>
 #else
-  template <typename GR, typename LEN,
-    bool integer = std::numeric_limits<typename LEN::Value>::is_integer>
+  template <typename GR, typename CM,
+    bool integer = std::numeric_limits<typename CM::Value>::is_integer>
 #endif
-  struct HowardDefaultTraits
+  struct HowardMmcDefaultTraits
   {
     /// The type of the digraph
     typedef GR Digraph;
-    /// The type of the length map
-    typedef LEN LengthMap;
-    /// The type of the arc lengths
-    typedef typename LengthMap::Value Value;
-
-    /// \brief The large value type used for internal computations
-    ///
-    /// The large value type used for internal computations.
-    /// It is \c long \c long if the \c Value type is integer,
+    /// The type of the cost map
+    typedef CM CostMap;
+    /// The type of the arc costs
+    typedef typename CostMap::Value Cost;
+
+    /// \brief The large cost type used for internal computations
+    ///
+    /// The large cost type used for internal computations.
+    /// It is \c long \c long if the \c Cost type is integer,
     /// otherwise it is \c double.
-    /// \c Value must be convertible to \c LargeValue.
-    typedef double LargeValue;
+    /// \c Cost must be convertible to \c LargeCost.
+    typedef double LargeCost;
 
     /// The tolerance type used for internal computations
-    typedef lemon::Tolerance<LargeValue> Tolerance;
+    typedef lemon::Tolerance<LargeCost> Tolerance;
 
     /// \brief The path type of the found cycles
@@ -74 +74 @@
   };
 
-  // Default traits class for integer value types
-  template <typename GR, typename LEN>
-  struct HowardDefaultTraits<GR, LEN, true>
+  // Default traits class for integer cost types
+  template <typename GR, typename CM>
+  struct HowardMmcDefaultTraits<GR, CM, true>
   {
     typedef GR Digraph;
-    typedef LEN LengthMap;
-    typedef typename LengthMap::Value Value;
+    typedef CM CostMap;
+    typedef typename CostMap::Value Cost;
 #ifdef LEMON_HAVE_LONG_LONG
-    typedef long long LargeValue;
+    typedef long long LargeCost;
 #else
-    typedef long LargeValue;
+    typedef long LargeCost;
 #endif
-    typedef lemon::Tolerance<LargeValue> Tolerance;
+    typedef lemon::Tolerance<LargeCost> Tolerance;
     typedef lemon::Path<Digraph> Path;
   };
@@ -98 +98 @@
   ///
   /// This class implements Howard's policy iteration algorithm for finding
-  /// a directed cycle of minimum mean length (cost) in a digraph
+  /// a directed cycle of minimum mean cost in a digraph
   /// \ref amo93networkflows, \ref dasdan98minmeancycle.
   /// This class provides the most efficient algorithm for the
@@ -105 +105 @@
   ///
   /// \tparam GR The type of the digraph the algorithm runs on.
-  /// \tparam LEN The type of the length map. The default
+  /// \tparam CM The type of the cost map. The default
   /// map type is \ref concepts::Digraph::ArcMap "GR::ArcMap<int>".
   /// \tparam TR The traits class that defines various types used by the
-  /// algorithm. By default, it is \ref HowardDefaultTraits
-  /// "HowardDefaultTraits<GR, LEN>".
+  /// algorithm. By default, it is \ref HowardMmcDefaultTraits
+  /// "HowardMmcDefaultTraits<GR, CM>".
   /// In most cases, this parameter should not be set directly,
   /// consider to use the named template parameters instead.
 #ifdef DOXYGEN
-  template <typename GR, typename LEN, typename TR>
+  template <typename GR, typename CM, typename TR>
 #else
   template < typename GR,
-             typename LEN = typename GR::template ArcMap<int>,
-             typename TR = HowardDefaultTraits<GR, LEN> >
+             typename CM = typename GR::template ArcMap<int>,
+             typename TR = HowardMmcDefaultTraits<GR, CM> >
 #endif
-  class Howard
+  class HowardMmc
   {
   public:
@@ -125 +125 @@
     /// The type of the digraph
     typedef typename TR::Digraph Digraph;
-    /// The type of the length map
-    typedef typename TR::LengthMap LengthMap;
-    /// The type of the arc lengths
-    typedef typename TR::Value Value;
-
-    /// \brief The large value type
-    ///
-    /// The large value type used for internal computations.
-    /// By default, it is \c long \c long if the \c Value type is integer,
+    /// The type of the cost map
+    typedef typename TR::CostMap CostMap;
+    /// The type of the arc costs
+    typedef typename TR::Cost Cost;
+
+    /// \brief The large cost type
+    ///
+    /// The large cost type used for internal computations.
+    /// By default, it is \c long \c long if the \c Cost type is integer,
     /// otherwise it is \c double.
-    typedef typename TR::LargeValue LargeValue;
+    typedef typename TR::LargeCost LargeCost;
 
     /// The tolerance type
@@ -143 +143 @@
     ///
     /// The path type of the found cycles.
-    /// Using the \ref HowardDefaultTraits "default traits class",
+    /// Using the \ref HowardMmcDefaultTraits "default traits class",
     /// it is \ref lemon::Path "Path<Digraph>".
     typedef typename TR::Path Path;
 
-    /// The \ref HowardDefaultTraits "traits class" of the algorithm
+    /// The \ref HowardMmcDefaultTraits "traits class" of the algorithm
     typedef TR Traits;
 
@@ -156 +156 @@
     // The digraph the algorithm runs on
     const Digraph &_gr;
-    // The length of the arcs
-    const LengthMap &_length;
+    // The cost of the arcs
+    const CostMap &_cost;
 
     // Data for the found cycles
     bool _curr_found, _best_found;
-    LargeValue _curr_length, _best_length;
+    LargeCost _curr_cost, _best_cost;
     int _curr_size, _best_size;
     Node _curr_node, _best_node;
@@ -172 +172 @@
     typename Digraph::template NodeMap<bool> _reached;
     typename Digraph::template NodeMap<int> _level;
-    typename Digraph::template NodeMap<LargeValue> _dist;
+    typename Digraph::template NodeMap<LargeCost> _dist;
 
     // Data for storing the strongly connected components
@@ -188 +188 @@
   
     // Infinite constant
-    const LargeValue INF;
+    const LargeCost INF;
 
   public:
@@ -196 +196 @@
 
     template <typename T>
-    struct SetLargeValueTraits : public Traits {
-      typedef T LargeValue;
+    struct SetLargeCostTraits : public Traits {
+      typedef T LargeCost;
       typedef lemon::Tolerance<T> Tolerance;
     };
 
     /// \brief \ref named-templ-param "Named parameter" for setting
-    /// \c LargeValue type.
-    ///
-    /// \ref named-templ-param "Named parameter" for setting \c LargeValue
+    /// \c LargeCost type.
+    ///
+    /// \ref named-templ-param "Named parameter" for setting \c LargeCost
     /// type. It is used for internal computations in the algorithm.
     template <typename T>
-    struct SetLargeValue
-      : public Howard<GR, LEN, SetLargeValueTraits<T> > {
-      typedef Howard<GR, LEN, SetLargeValueTraits<T> > Create;
+    struct SetLargeCost
+      : public HowardMmc<GR, CM, SetLargeCostTraits<T> > {
+      typedef HowardMmc<GR, CM, SetLargeCostTraits<T> > Create;
     };
 
@@ -226 +226 @@
     template <typename T>
     struct SetPath
-      : public Howard<GR, LEN, SetPathTraits<T> > {
-      typedef Howard<GR, LEN, SetPathTraits<T> > Create;
+      : public HowardMmc<GR, CM, SetPathTraits<T> > {
+      typedef HowardMmc<GR, CM, SetPathTraits<T> > Create;
     };
     
@@ -234 +234 @@
   protected:
 
-    Howard() {}
+    HowardMmc() {}
 
   public:
@@ -243 +243 @@
     ///
     /// \param digraph The digraph the algorithm runs on.
-    /// \param length The lengths (costs) of the arcs.
-    Howard( const Digraph &digraph,
-            const LengthMap &length ) :
-      _gr(digraph), _length(length), _best_found(false),
-      _best_length(0), _best_size(1), _cycle_path(NULL), _local_path(false),
+    /// \param cost The costs of the arcs.
+    HowardMmc( const Digraph &digraph,
+               const CostMap &cost ) :
+      _gr(digraph), _cost(cost), _best_found(false),
+      _best_cost(0), _best_size(1), _cycle_path(NULL), _local_path(false),
       _policy(digraph), _reached(digraph), _level(digraph), _dist(digraph),
       _comp(digraph), _in_arcs(digraph),
-      INF(std::numeric_limits<LargeValue>::has_infinity ?
-          std::numeric_limits<LargeValue>::infinity() :
-          std::numeric_limits<LargeValue>::max())
+      INF(std::numeric_limits<LargeCost>::has_infinity ?
+          std::numeric_limits<LargeCost>::infinity() :
+          std::numeric_limits<LargeCost>::max())
     {}
 
     /// Destructor.
-    ~Howard() {
+    ~HowardMmc() {
       if (_local_path) delete _cycle_path;
     }
@@ -266 +266 @@
     ///
     /// If you don't call this function before calling \ref run() or
-    /// \ref findMinMean(), it will allocate a local \ref Path "path"
+    /// \ref findCycleMean(), it will allocate a local \ref Path "path"
     /// structure. The destuctor deallocates this automatically
     /// allocated object, of course.
@@ -274 +274 @@
     ///
     /// \return <tt>(*this)</tt>
-    Howard& cycle(Path &path) {
+    HowardMmc& cycle(Path &path) {
       if (_local_path) {
         delete _cycle_path;
@@ -288 +288 @@
     ///
     /// \return <tt>(*this)</tt>
-    Howard& tolerance(const Tolerance& tolerance) {
+    HowardMmc& tolerance(const Tolerance& tolerance) {
       _tolerance = tolerance;
       return *this;
@@ -304 +304 @@
     /// The simplest way to execute the algorithm is to call the \ref run()
     /// function.\n
-    /// If you only need the minimum mean length, you may call
-    /// \ref findMinMean().
+    /// If you only need the minimum mean cost, you may call
+    /// \ref findCycleMean().
 
     /// @{
@@ -313 +313 @@
     /// This function runs the algorithm.
     /// It can be called more than once (e.g. if the underlying digraph
-    /// and/or the arc lengths have been modified).
+    /// and/or the arc costs have been modified).
     ///
     /// \return \c true if a directed cycle exists in the digraph.
@@ -319 +319 @@
     /// \note <tt>mmc.run()</tt> is just a shortcut of the following code.
     /// \code
-    ///   return mmc.findMinMean() && mmc.findCycle();
+    ///   return mmc.findCycleMean() && mmc.findCycle();
     /// \endcode
     bool run() {
-      return findMinMean() && findCycle();
+      return findCycleMean() && findCycle();
     }
 
     /// \brief Find the minimum cycle mean.
     ///
-    /// This function finds the minimum mean length of the directed
+    /// This function finds the minimum mean cost of the directed
     /// cycles in the digraph.
     ///
     /// \return \c true if a directed cycle exists in the digraph.
-    bool findMinMean() {
+    bool findCycleMean() {
       // Initialize and find strongly connected components
       init();
@@ -346 +346 @@
         // Update the best cycle (global minimum mean cycle)
         if ( _curr_found && (!_best_found ||
-             _curr_length * _best_size < _best_length * _curr_size) ) {
+             _curr_cost * _best_size < _best_cost * _curr_size) ) {
           _best_found = true;
-          _best_length = _curr_length;
+          _best_cost = _curr_cost;
           _best_size = _curr_size;
           _best_node = _curr_node;
@@ -358 +358 @@
     /// \brief Find a minimum mean directed cycle.
     ///
-    /// This function finds a directed cycle of minimum mean length
-    /// in the digraph using the data computed by findMinMean().
+    /// This function finds a directed cycle of minimum mean cost
+    /// in the digraph using the data computed by findCycleMean().
     ///
     /// \return \c true if a directed cycle exists in the digraph.
     ///
-    /// \pre \ref findMinMean() must be called before using this function.
+    /// \pre \ref findCycleMean() must be called before using this function.
     bool findCycle() {
       if (!_best_found) return false;
@@ -383 +383 @@
     /// @{
 
-    /// \brief Return the total length of the found cycle.
-    ///
-    /// This function returns the total length of the found cycle.
-    ///
-    /// \pre \ref run() or \ref findMinMean() must be called before
+    /// \brief Return the total cost of the found cycle.
+    ///
+    /// This function returns the total cost of the found cycle.
+    ///
+    /// \pre \ref run() or \ref findCycleMean() must be called before
     /// using this function.
-    Value cycleLength() const {
-      return static_cast<Value>(_best_length);
+    Cost cycleCost() const {
+      return static_cast<Cost>(_best_cost);
     }
 
@@ -397 +397 @@
     /// This function returns the number of arcs on the found cycle.
     ///
-    /// \pre \ref run() or \ref findMinMean() must be called before
+    /// \pre \ref run() or \ref findCycleMean() must be called before
     /// using this function.
-    int cycleArcNum() const {
+    int cycleSize() const {
       return _best_size;
     }
 
-    /// \brief Return the mean length of the found cycle.
-    ///
-    /// This function returns the mean length of the found cycle.
+    /// \brief Return the mean cost of the found cycle.
+    ///
+    /// This function returns the mean cost of the found cycle.
     ///
     /// \note <tt>alg.cycleMean()</tt> is just a shortcut of the
     /// following code.
     /// \code
-    ///   return static_cast<double>(alg.cycleLength()) / alg.cycleArcNum();
+    ///   return static_cast<double>(alg.cycleCost()) / alg.cycleSize();
     /// \endcode
     ///
-    /// \pre \ref run() or \ref findMinMean() must be called before
+    /// \pre \ref run() or \ref findCycleMean() must be called before
     /// using this function.
     double cycleMean() const {
-      return static_cast<double>(_best_length) / _best_size;
+      return static_cast<double>(_best_cost) / _best_size;
     }
 
@@ -442 +442 @@
       _queue.resize(countNodes(_gr));
       _best_found = false;
-      _best_length = 0;
+      _best_cost = 0;
       _best_size = 1;
       _cycle_path->clear();
@@ -493 +493 @@
           e = _in_arcs[v][j];
           u = _gr.source(e);
-          if (_length[e] < _dist[u]) {
-            _dist[u] = _length[e];
+          if (_cost[e] < _dist[u]) {
+            _dist[u] = _cost[e];
             _policy[u] = e;
           }
@@ -507 +507 @@
         _level[(*_nodes)[i]] = -1;
       }
-      LargeValue clength;
+      LargeCost ccost;
       int csize;
       Node u, v;
@@ -519 +519 @@
         if (_level[u] == i) {
           // A cycle is found
-          clength = _length[_policy[u]];
+          ccost = _cost[_policy[u]];
           csize = 1;
           for (v = u; (v = _gr.target(_policy[v])) != u; ) {
-            clength += _length[_policy[v]];
+            ccost += _cost[_policy[v]];
             ++csize;
           }
           if ( !_curr_found ||
-               (clength * _curr_size < _curr_length * csize) ) {
+               (ccost * _curr_size < _curr_cost * csize) ) {
             _curr_found = true;
-            _curr_length = clength;
+            _curr_cost = ccost;
             _curr_size = csize;
             _curr_node = u;
@@ -556 +556 @@
           if (_policy[u] == e && !_reached[u]) {
             _reached[u] = true;
-            _dist[u] = _dist[v] + _length[e] * _curr_size - _curr_length;
+            _dist[u] = _dist[v] + _cost[e] * _curr_size - _curr_cost;
             _queue[++_qback] = u;
           }
@@ -573 +573 @@
             _reached[u] = true;
             _policy[u] = e;
-            _dist[u] = _dist[v] + _length[e] * _curr_size - _curr_length;
+            _dist[u] = _dist[v] + _cost[e] * _curr_size - _curr_cost;
             _queue[++_qback] = u;
           }
@@ -586 +586 @@
           e = _in_arcs[v][j];
           u = _gr.source(e);
-          LargeValue delta = _dist[v] + _length[e] * _curr_size - _curr_length;
+          LargeCost delta = _dist[v] + _cost[e] * _curr_size - _curr_cost;
           if (_tolerance.less(delta, _dist[u])) {
             _dist[u] = delta;
@@ -597 +597 @@
     }
 
-  }; //class Howard
+  }; //class HowardMmc
 
   ///@}
@@ -603 +603 @@
 } //namespace lemon
 
-#endif //LEMON_HOWARD_H
+#endif //LEMON_HOWARD_MMC_H

lemon/karp_mmc.h

@@ -17 +17 @@
  */
 
-#ifndef LEMON_KARP_H
-#define LEMON_KARP_H
+#ifndef LEMON_KARP_MMC_H
+#define LEMON_KARP_MMC_H
 
 /// \ingroup min_mean_cycle
@@ -34 +34 @@
 namespace lemon {
 
-  /// \brief Default traits class of Karp algorithm.
+  /// \brief Default traits class of KarpMmc class.
   ///
-  /// Default traits class of Karp algorithm.
+  /// Default traits class of KarpMmc class.
   /// \tparam GR The type of the digraph.
-  /// \tparam LEN The type of the length map.
+  /// \tparam CM The type of the cost map.
   /// It must conform to the \ref concepts::ReadMap "ReadMap" concept.
 #ifdef DOXYGEN
-  template <typename GR, typename LEN>
+  template <typename GR, typename CM>
 #else
-  template <typename GR, typename LEN,
-    bool integer = std::numeric_limits<typename LEN::Value>::is_integer>
+  template <typename GR, typename CM,
+    bool integer = std::numeric_limits<typename CM::Value>::is_integer>
 #endif
-  struct KarpDefaultTraits
+  struct KarpMmcDefaultTraits
   {
     /// The type of the digraph
     typedef GR Digraph;
-    /// The type of the length map
-    typedef LEN LengthMap;
-    /// The type of the arc lengths
-    typedef typename LengthMap::Value Value;
-
-    /// \brief The large value type used for internal computations
-    ///
-    /// The large value type used for internal computations.
-    /// It is \c long \c long if the \c Value type is integer,
+    /// The type of the cost map
+    typedef CM CostMap;
+    /// The type of the arc costs
+    typedef typename CostMap::Value Cost;
+
+    /// \brief The large cost type used for internal computations
+    ///
+    /// The large cost type used for internal computations.
+    /// It is \c long \c long if the \c Cost type is integer,
     /// otherwise it is \c double.
-    /// \c Value must be convertible to \c LargeValue.
-    typedef double LargeValue;
+    /// \c Cost must be convertible to \c LargeCost.
+    typedef double LargeCost;
 
     /// The tolerance type used for internal computations
-    typedef lemon::Tolerance<LargeValue> Tolerance;
+    typedef lemon::Tolerance<LargeCost> Tolerance;
 
     /// \brief The path type of the found cycles
@@ -74 +74 @@
   };
 
-  // Default traits class for integer value types
-  template <typename GR, typename LEN>
-  struct KarpDefaultTraits<GR, LEN, true>
+  // Default traits class for integer cost types
+  template <typename GR, typename CM>
+  struct KarpMmcDefaultTraits<GR, CM, true>
   {
     typedef GR Digraph;
-    typedef LEN LengthMap;
-    typedef typename LengthMap::Value Value;
+    typedef CM CostMap;
+    typedef typename CostMap::Value Cost;
 #ifdef LEMON_HAVE_LONG_LONG
-    typedef long long LargeValue;
+    typedef long long LargeCost;
 #else
-    typedef long LargeValue;
+    typedef long LargeCost;
 #endif
-    typedef lemon::Tolerance<LargeValue> Tolerance;
+    typedef lemon::Tolerance<LargeCost> Tolerance;
     typedef lemon::Path<Digraph> Path;
   };
@@ -98 +98 @@
   ///
   /// This class implements Karp's algorithm for finding a directed
-  /// cycle of minimum mean length (cost) in a digraph
+  /// cycle of minimum mean cost in a digraph
   /// \ref amo93networkflows, \ref dasdan98minmeancycle.
   /// It runs in time O(ne) and uses space O(n<sup>2</sup>+e).
   ///
   /// \tparam GR The type of the digraph the algorithm runs on.
-  /// \tparam LEN The type of the length map. The default
+  /// \tparam CM The type of the cost map. The default
   /// map type is \ref concepts::Digraph::ArcMap "GR::ArcMap<int>".
   /// \tparam TR The traits class that defines various types used by the
-  /// algorithm. By default, it is \ref KarpDefaultTraits
-  /// "KarpDefaultTraits<GR, LEN>".
+  /// algorithm. By default, it is \ref KarpMmcDefaultTraits
+  /// "KarpMmcDefaultTraits<GR, CM>".
   /// In most cases, this parameter should not be set directly,
   /// consider to use the named template parameters instead.
 #ifdef DOXYGEN
-  template <typename GR, typename LEN, typename TR>
+  template <typename GR, typename CM, typename TR>
 #else
   template < typename GR,
-             typename LEN = typename GR::template ArcMap<int>,
-             typename TR = KarpDefaultTraits<GR, LEN> >
+             typename CM = typename GR::template ArcMap<int>,
+             typename TR = KarpMmcDefaultTraits<GR, CM> >
 #endif
-  class Karp
+  class KarpMmc
   {
   public:
@@ -123 +123 @@
     /// The type of the digraph
     typedef typename TR::Digraph Digraph;
-    /// The type of the length map
-    typedef typename TR::LengthMap LengthMap;
-    /// The type of the arc lengths
-    typedef typename TR::Value Value;
-
-    /// \brief The large value type
-    ///
-    /// The large value type used for internal computations.
-    /// By default, it is \c long \c long if the \c Value type is integer,
+    /// The type of the cost map
+    typedef typename TR::CostMap CostMap;
+    /// The type of the arc costs
+    typedef typename TR::Cost Cost;
+
+    /// \brief The large cost type
+    ///
+    /// The large cost type used for internal computations.
+    /// By default, it is \c long \c long if the \c Cost type is integer,
     /// otherwise it is \c double.
-    typedef typename TR::LargeValue LargeValue;
+    typedef typename TR::LargeCost LargeCost;
 
     /// The tolerance type
@@ -141 +141 @@
     ///
     /// The path type of the found cycles.
-    /// Using the \ref KarpDefaultTraits "default traits class",
+    /// Using the \ref KarpMmcDefaultTraits "default traits class",
     /// it is \ref lemon::Path "Path<Digraph>".
     typedef typename TR::Path Path;
 
-    /// The \ref KarpDefaultTraits "traits class" of the algorithm
+    /// The \ref KarpMmcDefaultTraits "traits class" of the algorithm
     typedef TR Traits;
 
@@ -155 +155 @@
     struct PathData
     {
-      LargeValue dist;
+      LargeCost dist;
       Arc pred;
-      PathData(LargeValue d, Arc p = INVALID) :
+      PathData(LargeCost d, Arc p = INVALID) :
         dist(d), pred(p) {}
     };
@@ -168 +168 @@
     // The digraph the algorithm runs on
     const Digraph &_gr;
-    // The length of the arcs
-    const LengthMap &_length;
+    // The cost of the arcs
+    const CostMap &_cost;
 
     // Data for storing the strongly connected components
@@ -179 +179 @@
 
     // Data for the found cycle
-    LargeValue _cycle_length;
+    LargeCost _cycle_cost;
     int _cycle_size;
     Node _cycle_node;
@@ -194 +194 @@
     
     // Infinite constant
-    const LargeValue INF;
+    const LargeCost INF;
 
   public:
@@ -202 +202 @@
 
     template <typename T>
-    struct SetLargeValueTraits : public Traits {
-      typedef T LargeValue;
+    struct SetLargeCostTraits : public Traits {
+      typedef T LargeCost;
       typedef lemon::Tolerance<T> Tolerance;
     };
 
     /// \brief \ref named-templ-param "Named parameter" for setting
-    /// \c LargeValue type.
-    ///
-    /// \ref named-templ-param "Named parameter" for setting \c LargeValue
+    /// \c LargeCost type.
+    ///
+    /// \ref named-templ-param "Named parameter" for setting \c LargeCost
     /// type. It is used for internal computations in the algorithm.
     template <typename T>
-    struct SetLargeValue
-      : public Karp<GR, LEN, SetLargeValueTraits<T> > {
-      typedef Karp<GR, LEN, SetLargeValueTraits<T> > Create;
+    struct SetLargeCost
+      : public KarpMmc<GR, CM, SetLargeCostTraits<T> > {
+      typedef KarpMmc<GR, CM, SetLargeCostTraits<T> > Create;
     };
 
@@ -232 +232 @@
     template <typename T>
     struct SetPath
-      : public Karp<GR, LEN, SetPathTraits<T> > {
-      typedef Karp<GR, LEN, SetPathTraits<T> > Create;
+      : public KarpMmc<GR, CM, SetPathTraits<T> > {
+      typedef KarpMmc<GR, CM, SetPathTraits<T> > Create;
     };
 
@@ -240 +240 @@
   protected:
 
-    Karp() {}
+    KarpMmc() {}
 
   public:
@@ -249 +249 @@
     ///
     /// \param digraph The digraph the algorithm runs on.
-    /// \param length The lengths (costs) of the arcs.
-    Karp( const Digraph &digraph,
-          const LengthMap &length ) :
-      _gr(digraph), _length(length), _comp(digraph), _out_arcs(digraph),
-      _cycle_length(0), _cycle_size(1), _cycle_node(INVALID),
+    /// \param cost The costs of the arcs.
+    KarpMmc( const Digraph &digraph,
+             const CostMap &cost ) :
+      _gr(digraph), _cost(cost), _comp(digraph), _out_arcs(digraph),
+      _cycle_cost(0), _cycle_size(1), _cycle_node(INVALID),
       _cycle_path(NULL), _local_path(false), _data(digraph),
-      INF(std::numeric_limits<LargeValue>::has_infinity ?
-          std::numeric_limits<LargeValue>::infinity() :
-          std::numeric_limits<LargeValue>::max())
+      INF(std::numeric_limits<LargeCost>::has_infinity ?
+          std::numeric_limits<LargeCost>::infinity() :
+          std::numeric_limits<LargeCost>::max())
     {}
 
     /// Destructor.
-    ~Karp() {
+    ~KarpMmc() {
       if (_local_path) delete _cycle_path;
     }
@@ -271 +271 @@
     ///
     /// If you don't call this function before calling \ref run() or
-    /// \ref findMinMean(), it will allocate a local \ref Path "path"
+    /// \ref findCycleMean(), it will allocate a local \ref Path "path"
     /// structure. The destuctor deallocates this automatically
     /// allocated object, of course.
@@ -279 +279 @@
     ///
     /// \return <tt>(*this)</tt>
-    Karp& cycle(Path &path) {
+    KarpMmc& cycle(Path &path) {
       if (_local_path) {
         delete _cycle_path;
@@ -293 +293 @@
     ///
     /// \return <tt>(*this)</tt>
-    Karp& tolerance(const Tolerance& tolerance) {
+    KarpMmc& tolerance(const Tolerance& tolerance) {
       _tolerance = tolerance;
       return *this;
@@ -309 +309 @@
     /// The simplest way to execute the algorithm is to call the \ref run()
     /// function.\n
-    /// If you only need the minimum mean length, you may call
-    /// \ref findMinMean().
+    /// If you only need the minimum mean cost, you may call
+    /// \ref findCycleMean().
 
     /// @{
@@ -318 +318 @@
     /// This function runs the algorithm.
     /// It can be called more than once (e.g. if the underlying digraph
-    /// and/or the arc lengths have been modified).
+    /// and/or the arc costs have been modified).
     ///
     /// \return \c true if a directed cycle exists in the digraph.
@@ -324 +324 @@
     /// \note <tt>mmc.run()</tt> is just a shortcut of the following code.
     /// \code
-    ///   return mmc.findMinMean() && mmc.findCycle();
+    ///   return mmc.findCycleMean() && mmc.findCycle();
     /// \endcode
     bool run() {
-      return findMinMean() && findCycle();
+      return findCycleMean() && findCycle();
     }
 
     /// \brief Find the minimum cycle mean.
     ///
-    /// This function finds the minimum mean length of the directed
+    /// This function finds the minimum mean cost of the directed
     /// cycles in the digraph.
     ///
     /// \return \c true if a directed cycle exists in the digraph.
-    bool findMinMean() {
+    bool findCycleMean() {
       // Initialization and find strongly connected components
       init();
@@ -352 +352 @@
     /// \brief Find a minimum mean directed cycle.
     ///
-    /// This function finds a directed cycle of minimum mean length
-    /// in the digraph using the data computed by findMinMean().
+    /// This function finds a directed cycle of minimum mean cost
+    /// in the digraph using the data computed by findCycleMean().
     ///
     /// \return \c true if a directed cycle exists in the digraph.
     ///
-    /// \pre \ref findMinMean() must be called before using this function.
+    /// \pre \ref findCycleMean() must be called before using this function.
     bool findCycle() {
       if (_cycle_node == INVALID) return false;
@@ -370 +370 @@
       Arc e = _data[u][r].pred;
       _cycle_path->addFront(e);
-      _cycle_length = _length[e];
+      _cycle_cost = _cost[e];
       _cycle_size = 1;
       Node v;
@@ -376 +376 @@
         e = _data[v][--r].pred;
         _cycle_path->addFront(e);
-        _cycle_length += _length[e];
+        _cycle_cost += _cost[e];
         ++_cycle_size;
       }
@@ -391 +391 @@
     /// @{
 
-    /// \brief Return the total length of the found cycle.
-    ///
-    /// This function returns the total length of the found cycle.
-    ///
-    /// \pre \ref run() or \ref findMinMean() must be called before
+    /// \brief Return the total cost of the found cycle.
+    ///
+    /// This function returns the total cost of the found cycle.
+    ///
+    /// \pre \ref run() or \ref findCycleMean() must be called before
     /// using this function.
-    Value cycleLength() const {
-      return static_cast<Value>(_cycle_length);
+    Cost cycleCost() const {
+      return static_cast<Cost>(_cycle_cost);
     }
 
@@ -405 +405 @@
     /// This function returns the number of arcs on the found cycle.
     ///
-    /// \pre \ref run() or \ref findMinMean() must be called before
+    /// \pre \ref run() or \ref findCycleMean() must be called before
     /// using this function.
-    int cycleArcNum() const {
+    int cycleSize() const {
       return _cycle_size;
     }
 
-    /// \brief Return the mean length of the found cycle.
-    ///
-    /// This function returns the mean length of the found cycle.
+    /// \brief Return the mean cost of the found cycle.
+    ///
+    /// This function returns the mean cost of the found cycle.
     ///
     /// \note <tt>alg.cycleMean()</tt> is just a shortcut of the
     /// following code.
     /// \code
-    ///   return static_cast<double>(alg.cycleLength()) / alg.cycleArcNum();
+    ///   return static_cast<double>(alg.cycleCost()) / alg.cycleSize();
     /// \endcode
     ///
-    /// \pre \ref run() or \ref findMinMean() must be called before
+    /// \pre \ref run() or \ref findCycleMean() must be called before
     /// using this function.
     double cycleMean() const {
-      return static_cast<double>(_cycle_length) / _cycle_size;
+      return static_cast<double>(_cycle_cost) / _cycle_size;
     }
 
@@ -449 +449 @@
       }
       _cycle_path->clear();
-      _cycle_length = 0;
+      _cycle_cost = 0;
       _cycle_size = 1;
       _cycle_node = INVALID;
@@ -498 +498 @@
 
     // Process all rounds of computing path data for the current component.
-    // _data[v][k] is the length of a shortest directed walk from the root
+    // _data[v][k] is the cost of a shortest directed walk from the root
     // node to node v containing exactly k arcs.
     void processRounds() {
@@ -520 +520 @@
       Node u, v;
       Arc e;
-      LargeValue d;
+      LargeCost d;
       for (int i = 0; i < int(_process.size()); ++i) {
         u = _process[i];
@@ -526 +526 @@
           e = _out_arcs[u][j];
           v = _gr.target(e);
-          d = _data[u][k-1].dist + _length[e];
+          d = _data[u][k-1].dist + _cost[e];
           if (_tolerance.less(d, _data[v][k].dist)) {
             if (_data[v][k].dist == INF) next.push_back(v);
@@ -540 +540 @@
       Node u, v;
       Arc e;
-      LargeValue d;
+      LargeCost d;
       for (int i = 0; i < int(_nodes->size()); ++i) {
         u = (*_nodes)[i];
@@ -546 +546 @@
           e = _out_arcs[u][j];
           v = _gr.target(e);
-          d = _data[u][k-1].dist + _length[e];
+          d = _data[u][k-1].dist + _cost[e];
           if (_tolerance.less(d, _data[v][k].dist)) {
             _data[v][k] = PathData(d, e);
@@ -560 +560 @@
         Node u = (*_nodes)[i];
         if (_data[u][n].dist == INF) continue;
-        LargeValue length, max_length = 0;
+        LargeCost cost, max_cost = 0;
         int size, max_size = 1;
         bool found_curr = false;
         for (int k = 0; k < n; ++k) {
           if (_data[u][k].dist == INF) continue;
-          length = _data[u][n].dist - _data[u][k].dist;
+          cost = _data[u][n].dist - _data[u][k].dist;
           size = n - k;
-          if (!found_curr || length * max_size > max_length * size) {
+          if (!found_curr || cost * max_size > max_cost * size) {
             found_curr = true;
-            max_length = length;
+            max_cost = cost;
             max_size = size;
           }
         }
         if ( found_curr && (_cycle_node == INVALID ||
-             max_length * _cycle_size < _cycle_length * max_size) ) {
-          _cycle_length = max_length;
+             max_cost * _cycle_size < _cycle_cost * max_size) ) {
+          _cycle_cost = max_cost;
           _cycle_size = max_size;
           _cycle_node = u;
@@ -582 +582 @@
     }
 
-  }; //class Karp
+  }; //class KarpMmc
 
   ///@}
@@ -588 +588 @@
 } //namespace lemon
 
-#endif //LEMON_KARP_H
+#endif //LEMON_KARP_MMC_H

test/min_mean_cycle_test.cc

@@ -26 +26 @@
 #include <lemon/concept_check.h>
 
-#include <lemon/karp.h>
-#include <lemon/hartmann_orlin.h>
-#include <lemon/howard.h>
+#include <lemon/karp_mmc.h>
+#include <lemon/hartmann_orlin_mmc.h>
+#include <lemon/howard_mmc.h>
 
 #include "test_tools.h"
@@ -64 +64 @@
                         
 // Check the interface of an MMC algorithm
-template <typename GR, typename Value>
+template <typename GR, typename Cost>
 struct MmcClassConcept
 {
@@ -74 +74 @@
       typedef typename MMC
         ::template SetPath<ListPath<GR> >
-        ::template SetLargeValue<Value>
+        ::template SetLargeCost<Cost>
         ::Create MmcAlg;
-      MmcAlg mmc(me.g, me.length);
+      MmcAlg mmc(me.g, me.cost);
       const MmcAlg& const_mmc = mmc;
       
@@ -83 +83 @@
       
       b = mmc.cycle(p).run();
-      b = mmc.findMinMean();
+      b = mmc.findCycleMean();
       b = mmc.findCycle();
 
-      v = const_mmc.cycleLength();
-      i = const_mmc.cycleArcNum();
+      v = const_mmc.cycleCost();
+      i = const_mmc.cycleSize();
       d = const_mmc.cycleMean();
       p = const_mmc.cycle();
     }
 
-    typedef concepts::ReadMap<typename GR::Arc, Value> LM;
+    typedef concepts::ReadMap<typename GR::Arc, Cost> CM;
   
     GR g;
-    LM length;
+    CM cost;
     ListPath<GR> p;
-    Value v;
+    Cost v;
     int i;
     double d;
@@ -109 +109 @@
                  const SmartDigraph::ArcMap<int>& lm,
                  const SmartDigraph::ArcMap<int>& cm,
-                 int length, int size) {
+                 int cost, int size) {
   MMC alg(gr, lm);
-  alg.findMinMean();
-  check(alg.cycleMean() == static_cast<double>(length) / size,
+  alg.findCycleMean();
+  check(alg.cycleMean() == static_cast<double>(cost) / size,
         "Wrong cycle mean");
   alg.findCycle();
-  check(alg.cycleLength() == length && alg.cycleArcNum() == size,
+  check(alg.cycleCost() == cost && alg.cycleSize() == size,
         "Wrong path");
   SmartDigraph::ArcMap<int> cycle(gr, 0);
@@ -149 +149 @@
     typedef concepts::Digraph GR;
 
-    // Karp
+    // KarpMmc
     checkConcept< MmcClassConcept<GR, int>,
-                  Karp<GR, concepts::ReadMap<GR::Arc, int> > >();
+                  KarpMmc<GR, concepts::ReadMap<GR::Arc, int> > >();
     checkConcept< MmcClassConcept<GR, float>,
-                  Karp<GR, concepts::ReadMap<GR::Arc, float> > >();
-    
-    // HartmannOrlin
+                  KarpMmc<GR, concepts::ReadMap<GR::Arc, float> > >();
+    
+    // HartmannOrlinMmc
     checkConcept< MmcClassConcept<GR, int>,
-                  HartmannOrlin<GR, concepts::ReadMap<GR::Arc, int> > >();
+                  HartmannOrlinMmc<GR, concepts::ReadMap<GR::Arc, int> > >();
     checkConcept< MmcClassConcept<GR, float>,
-                  HartmannOrlin<GR, concepts::ReadMap<GR::Arc, float> > >();
-    
-    // Howard
+                  HartmannOrlinMmc<GR, concepts::ReadMap<GR::Arc, float> > >();
+    
+    // HowardMmc
     checkConcept< MmcClassConcept<GR, int>,
-                  Howard<GR, concepts::ReadMap<GR::Arc, int> > >();
+                  HowardMmc<GR, concepts::ReadMap<GR::Arc, int> > >();
     checkConcept< MmcClassConcept<GR, float>,
-                  Howard<GR, concepts::ReadMap<GR::Arc, float> > >();
-
-    if (IsSameType<Howard<GR, concepts::ReadMap<GR::Arc, int> >::LargeValue,
-          long_int>::result == 0) check(false, "Wrong LargeValue type");
-    if (IsSameType<Howard<GR, concepts::ReadMap<GR::Arc, float> >::LargeValue,
-          double>::result == 0) check(false, "Wrong LargeValue type");
+                  HowardMmc<GR, concepts::ReadMap<GR::Arc, float> > >();
+
+    check((IsSameType<HowardMmc<GR, concepts::ReadMap<GR::Arc, int> >
+           ::LargeCost, long_int>::result == 1), "Wrong LargeCost type");
+    check((IsSameType<HowardMmc<GR, concepts::ReadMap<GR::Arc, float> >
+           ::LargeCost, double>::result == 1), "Wrong LargeCost type");
   }
 
@@ -195 +195 @@
 
     // Karp
-    checkMmcAlg<Karp<GR, IntArcMap> >(gr, l1, c1,  6, 3);
-    checkMmcAlg<Karp<GR, IntArcMap> >(gr, l2, c2,  5, 2);
-    checkMmcAlg<Karp<GR, IntArcMap> >(gr, l3, c3,  0, 1);
-    checkMmcAlg<Karp<GR, IntArcMap> >(gr, l4, c4, -1, 1);
+    checkMmcAlg<KarpMmc<GR, IntArcMap> >(gr, l1, c1,  6, 3);
+    checkMmcAlg<KarpMmc<GR, IntArcMap> >(gr, l2, c2,  5, 2);
+    checkMmcAlg<KarpMmc<GR, IntArcMap> >(gr, l3, c3,  0, 1);
+    checkMmcAlg<KarpMmc<GR, IntArcMap> >(gr, l4, c4, -1, 1);
 
     // HartmannOrlin
-    checkMmcAlg<HartmannOrlin<GR, IntArcMap> >(gr, l1, c1,  6, 3);
-    checkMmcAlg<HartmannOrlin<GR, IntArcMap> >(gr, l2, c2,  5, 2);
-    checkMmcAlg<HartmannOrlin<GR, IntArcMap> >(gr, l3, c3,  0, 1);
-    checkMmcAlg<HartmannOrlin<GR, IntArcMap> >(gr, l4, c4, -1, 1);
+    checkMmcAlg<HartmannOrlinMmc<GR, IntArcMap> >(gr, l1, c1,  6, 3);
+    checkMmcAlg<HartmannOrlinMmc<GR, IntArcMap> >(gr, l2, c2,  5, 2);
+    checkMmcAlg<HartmannOrlinMmc<GR, IntArcMap> >(gr, l3, c3,  0, 1);
+    checkMmcAlg<HartmannOrlinMmc<GR, IntArcMap> >(gr, l4, c4, -1, 1);
 
     // Howard
-    checkMmcAlg<Howard<GR, IntArcMap> >(gr, l1, c1,  6, 3);
-    checkMmcAlg<Howard<GR, IntArcMap> >(gr, l2, c2,  5, 2);
-    checkMmcAlg<Howard<GR, IntArcMap> >(gr, l3, c3,  0, 1);
-    checkMmcAlg<Howard<GR, IntArcMap> >(gr, l4, c4, -1, 1);
+    checkMmcAlg<HowardMmc<GR, IntArcMap> >(gr, l1, c1,  6, 3);
+    checkMmcAlg<HowardMmc<GR, IntArcMap> >(gr, l2, c2,  5, 2);
+    checkMmcAlg<HowardMmc<GR, IntArcMap> >(gr, l3, c3,  0, 1);
+    checkMmcAlg<HowardMmc<GR, IntArcMap> >(gr, l4, c4, -1, 1);
   }