COIN-OR::LEMON - Graph Library

Opened 3 years ago

Last modified 3 years ago

#615 closed defect

Compilation warnings (unused local typedefs) — at Version 1

Reported by: Alpar Juttner Owned by: Alpar Juttner
Priority: blocker Milestone: LEMON 1.4 release
Component: core Version: hg main
Keywords: Cc:
Revision id:

Description (last modified by Alpar Juttner)

Clang compiler version 5.0 reports a tons of warnings of unused local typedefs (recent gcc doesn'n - the reason is unclear to me). This renders the compilation unsuccessful in Maintainer mode.

We need a decision how to handle it.

  • The majority of these warnings comes from the *GRAPH_TYPEDEFS macros.
    • One way to avoid would be to suppress them to apply some compiler specific #pragma statement, but I have no idea how to do it safely and compiler independently. Can anyone help me in doing this? Is it possible to do it locally only for these typedefs?
    • The other solution is to use the ignore_unused() templates. The attaches chgset [2f7f2fd5b1a4] does this, but it is painful, because ignore_unused() cannot (and need not) be used in the global scope. Therefore we need to versions of all of these macros, one with the warning suppression, and one without. This is far from being convenient.
  • In addition, there are couple of standalone unused local typedefs, mainly in the test codes. What shall we do with them?
    • Use ignore_unused() for them?
    • Or delete them for they are unnecessary?
    • Or just comment them out and keep them for future reference?

Change History (2)

Changed 3 years ago by Alpar Juttner

Attachment: 0f291d5010f6.patch added

comment:1 Changed 3 years ago by Alpar Juttner

Description: modified (diff)
Note: See TracTickets for help on using tickets.