COIN-OR::LEMON - Graph Library

Opened 11 years ago

Closed 11 years ago

#120 closed task (fixed)

Review INSTALL and README files

Reported by: Alpar Juttner Owned by: Akos Ladanyi
Priority: blocker Milestone: LEMON 1.0 release
Component: build system Version: hg main
Keywords: Cc:
Revision id:

Description

  • INSTALL
    • description on ./configure flags
    • make targets
    • write something about --prefix
  • README
    • Directory structure and supplementary files

Attachments (5)

install-40e8e42b2e79.patch (5.3 KB) - added by Akos Ladanyi 11 years ago.
readme-8eca97771b18.patch (3.1 KB) - added by Akos Ladanyi 11 years ago.
install-da1d220b176b.patch (5.3 KB) - added by Akos Ladanyi 11 years ago.
readme-1686b3f59141.patch (3.1 KB) - added by Akos Ladanyi 11 years ago.
readme-7c67988fca07.patch (3.1 KB) - added by Alpar Juttner 11 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 11 years ago by Alpar Juttner

Version: hg main

comment:2 Changed 11 years ago by Akos Ladanyi

Status: newassigned

Changed 11 years ago by Akos Ladanyi

Attachment: install-40e8e42b2e79.patch added

Changed 11 years ago by Akos Ladanyi

Attachment: readme-8eca97771b18.patch added

comment:3 Changed 11 years ago by Akos Ladanyi

Attached 2 patches.

comment:4 in reply to:  3 ; Changed 11 years ago by Peter Kovacs

Replying to ladanyi:

Attached 2 patches.

I think tese changes are good.

Maybe I'm wrong, but the usage of the word "this" seems to be strange for me in a few cases in INSTALL, e.g. "this installs ...", "this runs ...". Maybe "it" or "this command" would be better.

Changed 11 years ago by Akos Ladanyi

Attachment: install-da1d220b176b.patch added

Changed 11 years ago by Akos Ladanyi

Attachment: readme-1686b3f59141.patch added

comment:5 in reply to:  4 ; Changed 11 years ago by Akos Ladanyi

Replying to kpeter:

Maybe I'm wrong, but the usage of the word "this" seems to be strange for me in a few cases in INSTALL, e.g. "this installs ...", "this runs ...". Maybe "it" or "this command" would be better.

Thanks for the comment. Updated the patches (1 2).

Changed 11 years ago by Alpar Juttner

Attachment: readme-7c67988fca07.patch added

comment:6 in reply to:  5 ; Changed 11 years ago by Alpar Juttner

Replying to ladanyi:

Replying to kpeter:

Maybe I'm wrong, but the usage of the word "this" seems to be strange for me in a few cases in INSTALL, e.g. "this installs ...", "this runs ...". Maybe "it" or "this command" would be better.

Thanks for the comment. Updated the patches (1 2).

I modified attachment:readme-1686b3f59141.patch a little bit. In [7c67988fca07] I changed only the intro paragraph, removed some duplications and explicitly wrote that LEMON focuses on graph algorithms. If you like these changes, I put them to the main branch.

comment:7 in reply to:  6 ; Changed 11 years ago by Akos Ladanyi

Replying to alpar:

... If you like these changes, I put them to the main branch.

I like them.

comment:8 in reply to:  7 Changed 11 years ago by Alpar Juttner

Resolution: fixed
Status: assignedclosed

Replying to ladanyi:

Replying to alpar:

... If you like these changes, I put them to the main branch.

I like them.

Changesets [da1d220b176b] and [7c67988fca07] are in the main branch, so I close the ticket.

Note: See TracTickets for help on using tickets.