COIN-OR::LEMON - Graph Library

Opened 11 years ago

Closed 10 years ago

Last modified 10 years ago

#25 closed task (fixed)

Unify the output of the test programs

Reported by: Alpar Juttner Owned by: Peter Kovacs
Priority: major Milestone: LEMON 1.0 release
Component: build system Version: hg main
Keywords: Cc: Akos Ladanyi
Revision id:

Description

The rules on thumb:

  • Print something to the output only if it really seems necessary. Check the validity of the results of the algorithms instead (using the check() macro).
  • Do not print a message saying all test passed at the end of the output.

Change History (10)

comment:1 Changed 11 years ago by Peter Kovacs

It should be done all at once both in HG and SVN repositories.

comment:2 Changed 11 years ago by Akos Ladanyi

Cc: Akos Ladanyi added

What about introducing an environment variable (e.g. LEMON_TESTS_VERBOSE) and only print anything when it is set? So by default (when it is unset) the test programs would report their result only by their exit status. If somebody is interested in the details, then he could rerun the failed tests with LEMON_TESTS_VERBOSE set.

comment:3 in reply to:  1 Changed 11 years ago by Alpar Juttner

Replying to kpeter:

It should be done all at once both in HG and SVN repositories.

Probably not. We should focus on the HG version as much as we can. Only critical bugs are to be fixed in the SVN version.

comment:4 in reply to:  2 Changed 11 years ago by Alpar Juttner

Replying to ladanyi:

What about introducing an environment variable (e.g. LEMON_TESTS_VERBOSE) and only print anything when it is set?

It is quite unnecessary. If everything is OK, we don't need any output. When something goes wrong, the chech() macro reports the corresponding line (with emacs you can directly jump to that line by hitting C-x `), and also an error message. These two together should be enough.

comment:5 in reply to:  2 Changed 11 years ago by Peter Kovacs

Replying to ladanyi:

What about introducing an environment variable (e.g. LEMON_TESTS_VERBOSE) and only print anything when it is set?

I think it is not important.

  • If a test fails, one of the check() functions prints the proper message. That's enough.
  • If a test passes, there is usually nothing intresting to be print. Maybe there is only one exception: when benchmark tests are also involved in the file and the results are printed.

By the way validity checks and benchmark tests should be separated and "make check" should not run benchmark tests.

comment:6 Changed 10 years ago by Alpar Juttner

Owner: changed from Alpar Juttner to Peter Kovacs

comment:7 Changed 10 years ago by Peter Kovacs

Status: newassigned

comment:8 Changed 10 years ago by Alpar Juttner

Version: hg main

comment:9 Changed 10 years ago by Peter Kovacs

Resolution: fixed
Status: assignedclosed

The changeset [02f4d5d9bfd7] solves this issue.

comment:10 Changed 10 years ago by Alpar Juttner

Component: corebuild system
Note: See TracTickets for help on using tickets.