COIN-OR::LEMON - Graph Library

Opened 10 years ago

Closed 10 years ago

#267 closed task (fixed)

Revise the interface of MinCostArborescence

Reported by: Peter Kovacs Owned by: Peter Kovacs
Priority: major Milestone: LEMON 1.1 release
Component: core Version: hg main
Keywords: Cc:
Revision id:

Description

  1. Check the interface (and the documentaton).
  2. Rename DefXyz template named pramaters to SetXyz.

Attachments (2)

61676b3b85f0.patch (22.4 KB) - added by Peter Kovacs 10 years ago.
029a48052c67.patch (22.5 KB) - added by Peter Kovacs 10 years ago.

Download all attachments as: .zip

Change History (8)

Changed 10 years ago by Peter Kovacs

Attachment: 61676b3b85f0.patch added

comment:1 Changed 10 years ago by Peter Kovacs

The attached patch [61676b3b85f0] contains improvements and fixes. It renames DefXyz template named pramaters to SetXyz and also extends the test file with interface checking.

I suggest another renaming: arborescenceValue() --> arborescenceCost(), like in matching algorithms matchingValue() was renamed to matchingWeight().

As far as I understand, this algorithm is practically the Prim algorithm for directed graphs. Am I right? If yes, then it should be noted in the doc.

comment:2 Changed 10 years ago by Peter Kovacs

Status: newassigned

comment:3 in reply to:  1 Changed 10 years ago by Alpar Juttner

Replying to kpeter:

The attached patch [61676b3b85f0] contains improvements and fixes. It renames DefXyz template named pramaters to SetXyz and also extends the test file with interface checking.

I suggest another renaming: arborescenceValue() --> arborescenceCost(), like in matching algorithms matchingValue() was renamed to matchingWeight().

As far as I understand, this algorithm is practically the Prim algorithm for directed graphs. Am I right?

I don't think so. There are some vague similarities but the differences are much more substantial.

comment:4 in reply to:  1 Changed 10 years ago by Alpar Juttner

Replying to kpeter:

I suggest another renaming: arborescenceValue() --> arborescenceCost(), like in matching algorithms matchingValue() was renamed to matchingWeight().

Let's do it!

Changed 10 years ago by Peter Kovacs

Attachment: 029a48052c67.patch added

comment:5 Changed 10 years ago by Peter Kovacs

[029a48052c67] is the same as [61676b3b85f0], with the addition of the arborescenceValue() --> arborescenceCost() renaming.

comment:6 Changed 10 years ago by Peter Kovacs

Resolution: fixed
Status: assignedclosed

[029a48052c67] went to the main branch.

Note: See TracTickets for help on using tickets.