Opened 17 years ago
Closed 17 years ago
#278 closed defect (fixed)
Superfluous HAVE_CONFIG_H
| Reported by: | Akos Ladanyi | Owned by: | Akos Ladanyi |
|---|---|---|---|
| Priority: | minor | Milestone: | LEMON 1.1 release |
| Component: | build system | Version: | hg main |
| Keywords: | Cc: | ||
| Revision id: |
Description
lp_test.cc and mip_test.cc use HAVE_CONFIG_H unnecessarily.
Attachments (1)
Change History (5)
Changed 17 years ago by
| Attachment: | remove-have-config-h.patch added |
|---|
comment:2 follow-up: 3 Changed 17 years ago by
As far as I see this ticket partially reverts the changes of [d8ca76573eb3] in CMakeLists.txt
comment:3 Changed 17 years ago by
Replying to kpeter:
As far as I see this ticket partially reverts the changes of [d8ca76573eb3] in
CMakeLists.txt
Well, yes. [d8ca76573eb3] added ADD_DEFINITIONS(-DHAVE_CONFIG_H) because it was not present at the fork of the 1.0 branch. When merging this changeset to the head of the main branch in [20dac2104519] a duplicate ADD_DEFINITIONS(-DHAVE_CONFIG_H) ended up in CMakeLists.txt.
Anyway, the HAVE_CONFIG_H define is only required if one includes the top level config.h, and we never do that. Therefore it can be removed from everywhere.
comment:4 Changed 17 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
[d21b38647e53] went to the main branch.
d21b38647e53