COIN-OR::LEMON - Graph Library

Opened 10 years ago

Closed 10 years ago

#321 closed defect (fixed)

Inconsistency - (di)graphCopy vs copyPath

Reported by: Peter Kovacs Owned by: Peter Kovacs
Priority: critical Milestone: LEMON 1.2 release
Component: core Version: hg main
Keywords: Cc:
Revision id:

Description

There is an annoying inconsistency in the current releases (1.0, 1.1): we have functions graphCopy() and copyPath(). Moreover the order of their parameters also differ: graphCopy(from, to) and copyPath(to, from).

More than one year ago, we decided to modify the 0.x version of graph copying functions: copyGraph(to, from) --> graphCopy(from, to), see #150. However, we were not careful enoguh, the path copying tools should have been modified, as well.

What could/should we do with this problem after we have released these tools with inconsistent interfaces?

Attachments (1)

321-c6acc34f98dc.patch (6.4 KB) - added by Peter Kovacs 10 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 10 years ago by Peter Kovacs

Status: newassigned

We could introduce pathCopy(from, to) and keep copyPath(to, from) as an obsolete solution without showing it in the doc (just for backward compatibility).

comment:2 in reply to:  1 Changed 10 years ago by Alpar Juttner

gReplying to kpeter:

We could introduce pathCopy(from, to) and keep copyPath(to, from) as an obsolete solution without showing it in the doc (just for backward compatibility).

I agree. We may even leave it in the doc with a proper remark that it is deprecated.

Changed 10 years ago by Peter Kovacs

Attachment: 321-c6acc34f98dc.patch added

comment:3 Changed 10 years ago by Peter Kovacs

[c6acc34f98dc] solves this problem as you suggested.

It is in the top of the bug fix [41bdb4d6c8c3], thus you can merge it into all branches you want.

comment:4 Changed 10 years ago by Peter Kovacs

Resolution: fixed
Status: assignedclosed

The patch went to all branches.

Note: See TracTickets for help on using tickets.