COIN-OR::LEMON - Graph Library

Opened 9 years ago

Closed 9 years ago

#335 closed defect (fixed)

Bug in ExtendFindEnum::clear

Reported by: deba Owned by: alpar
Priority: major Milestone: LEMON 1.2 release
Component: core Version: hg main
Keywords: Cc:
Revision id:

Description

The clear function is not called properly.

Attachments (1)

28c7ad6f8d91.patch (622 bytes) - added by deba 9 years ago.
Fix clear() function

Download all attachments as: .zip

Change History (8)

Changed 9 years ago by deba

Fix clear() function

comment:1 in reply to: ↑ description ; follow-up: Changed 9 years ago by alpar

Replying to deba:

The clear function is not called properly.

How did you find this bug?

At least, it shows that our test coverage is far from being full.

comment:2 in reply to: ↑ 1 Changed 9 years ago by deba

Replying to alpar:

Replying to deba:

The clear function is not called properly.

How did you find this bug?

At least, it shows that our test coverage is far from being full.

I tried to find a bug, which caused segfault in my program, and I checked this class line-by-line. The other bug did not exist, the segfault was caused by stack overflow, because the extractBlossom() in weighted matching uses recursive call. Indeed, it may have to be changed to iterative implementation sometime.

comment:3 follow-up: Changed 9 years ago by kpeter

  • Resolution set to fixed
  • Status changed from new to closed

[28c7ad6f8d91] has been merged to the main branch.

comment:4 in reply to: ↑ 3 ; follow-ups: Changed 9 years ago by kpeter

  • Resolution fixed deleted
  • Status changed from closed to reopened

Replying to kpeter:

[28c7ad6f8d91] has been merged to the main branch.

Why don't we merged this bugfix to the 1.0 and 1.1 branches?

comment:5 Changed 9 years ago by kpeter

  • Milestone set to LEMON 1.2 release

comment:6 in reply to: ↑ 4 Changed 9 years ago by kpeter

Replying to kpeter:

Why don't we merged this bugfix to the 1.0 and 1.1 branches?

Correctly: Why didn't we merge this bugfix to the branches 1.0 and 1.1?

comment:7 in reply to: ↑ 4 Changed 9 years ago by alpar

  • Resolution set to fixed
  • Status changed from reopened to closed

Replying to kpeter:

Replying to kpeter:

[28c7ad6f8d91] has been merged to the main branch.

Why don't we merged this bugfix to the 1.0 and 1.1 branches?

Good point. See [cf0c1b85618c] and [268a052c3043] for the backport.

Note: See TracTickets for help on using tickets.