Port graph_to_eps and eps.h

[Alpar Juttner]

We should also consider

• using eps.h for the actual drawing.
• rewriting using virtual-maps instead of named template parameters.

The affected files are:

• lemon/eps.h
• lemon/eps.cc

• lemon/graph_to_eps.h

• lemon/color.h
• lemon/color.cc

• demo/eps_demo.cc
• demo/graph_to_eps_demo.cc

• lemon/bits/bezier.h

[Alpar Juttner]

I uploaded here​ an initial port of the GraphToEps and the Color utilities. (And also the file bits/bezier.h as GraphToEps heavily depends on it.)

Some nice pictures are still missing from the documentation. See ticket:79 for more details.

[Alpar Juttner]

I uploaded here​ a new version of the port of the GraphToEps and the Color utilities.

I also changed the way a of the node size and the edge widths scaling. I believe it is more logical now.

A would be grateful if someone could have a short look at the doc and gave me some feedback on the current choices of the parameter names (i.e. the member functions of the class GraphToEps).

The doc still needs some improvements.

[Balazs Dezso]

I have some issue for graph_to_eps.h:

• If the coords parameter is not given to the drawer then the result will always meaningless. Therefore I suggest, that assertion or some other error handling would be preferred.
  
• The undirected parameter could be default turned of if the given graph is undirected.
  
• In my opinion the bidir() function should be called undirected().
  
• The tabbing should be reformatted.
  
• The _NegY could be hided into a local namespace.
  

On the other points, the interface is generally good.

[Alpar Juttner]

Replying to deba:

• The tabbing should be reformatted.
  

What do you mean by 'tabbing'?

[Balazs Dezso]

I mean the indentation by tabbing.

[Balazs Dezso]

Sorry, but I wrote some mistaken stuffs yesterday. The corrections:

• Whether the given graph is directed or undirected the undirected parameter could be switched on or off automatically.
• The indentation should be reformatted.
• The bidir() should be called bidirected() or the undirected() should be called undir().

[Alpar Juttner]

The port is now in the main branch, see [6e7aee618f03].

The port of eps.h will probably postponed to the next release, therefore I close this ticket.

See ticket:85 and ticket:86 for the followups on the remaining issues.