COIN-OR::LEMON - Graph Library

Opened 11 years ago

Closed 10 years ago

#65 closed task (fixed)

Port the Euler tour algorithm

Reported by: Alpar Juttner Owned by: Alpar Juttner
Priority: critical Milestone: LEMON 1.1 release
Component: core Version:
Keywords: Cc:
Revision id:

Description

It affects the file:

  • lemon/euler.h

Attachments (1)

euler-port-6b493b6d9328-1f3e7fb1edf2-f5eaf04b41c5.bundle (4.5 KB) - added by Alpar Juttner 10 years ago.

Download all attachments as: .zip

Change History (15)

comment:1 Changed 11 years ago by Alpar Juttner

Milestone: LEMON 1.0 releasePost 1.0

comment:2 Changed 10 years ago by Peter Kovacs

Owner: changed from Alpar Juttner to Peter Kovacs
Status: newassigned

comment:3 Changed 10 years ago by anonymous

Iron decorates your home. They have a wide variety of design, assuring that you will find a special one for display at home. The metal stai http://www.hebei-railings.cn/

comment:4 in reply to:  description Changed 10 years ago by Alpar Juttner

Replying to alpar:

It affects the file:

  • lemon/euler.h

It depends on the connectivity checking algorithm, i.e. #61.

comment:5 Changed 10 years ago by Alpar Juttner

Owner: changed from Peter Kovacs to Alpar Juttner
Status: assignednew

comment:6 Changed 10 years ago by Alpar Juttner

Status: newassigned

comment:7 Changed 10 years ago by Alpar Juttner

Priority: majorcritical

comment:8 Changed 10 years ago by Alpar Juttner

The attached bundle file contains the port of the Euler walk related stuff.

Could you please review it?

comment:9 in reply to:  8 ; Changed 10 years ago by Alpar Juttner

Replying to alpar:

The attached bundle file contains the port of the Euler walk related stuff.

Could you please review it?

Is there any pending issue with this port?

comment:10 in reply to:  9 ; Changed 10 years ago by Balazs Dezso

Replying to alpar:

Replying to alpar:

The attached bundle file contains the port of the Euler walk related stuff.

Could you please review it?

Is there any pending issue with this port?

I have some minor issues:

  • the todo should be removed from the file (it has already test)
  • the documentation must be fixed (UEulerIt is already removed)
  • the header does not have include guard
  • the copyright date should be updated
  • unfortunately, the connectivity.h is not in the Makefile.am, which should be fixed before
  • euler.h should include directly the adaptors.h
  • test main() should return 0

After the fixes it could be push to the main.

comment:11 in reply to:  10 ; Changed 10 years ago by Alpar Juttner

Replying to deba:

  • euler.h should include directly the adaptors.h

Oops, this revealed another bug - adaptors.h needs lemon/bits/graph_extender.h to be included. What would be the right place to do that?

  • Should it be included directly by adaptors.h?
  • Or by lemon/bits/graph_adaptor_extender.h?

comment:12 in reply to:  11 Changed 10 years ago by Balazs Dezso

Replying to alpar:

Replying to deba:

  • euler.h should include directly the adaptors.h

Oops, this revealed another bug - adaptors.h needs lemon/bits/graph_extender.h to be included. What would be the right place to do that?

  • Should it be included directly by adaptors.h?
  • Or by lemon/bits/graph_adaptor_extender.h?

Use the first option (direct inclusion).

comment:13 Changed 10 years ago by Peter Kovacs

Replying to alpar:

Oops, this revealed another bug - adaptors.h needs lemon/bits/graph_extender.h to be included. What would be the right place to do that?

  • Should it be included directly by adaptors.h?
  • Or by lemon/bits/graph_adaptor_extender.h?

As far as I see adaptors.h doesn't need bits/graph_extender.h, only bits/map_extender.h. And bits/graph_adaptor_extender.h doesn't need any of these files, so I suggest to put an #include <lemon/bits/map_extender.h> only into adaptors.h. It should be enough.

comment:14 Changed 10 years ago by Alpar Juttner

Resolution: fixed
Status: assignedclosed

This port is in the main branch, see [42d4b889903a], [3af83b6be1df] and [22f932bbb305].

Note: See TracTickets for help on using tickets.