COIN-OR::LEMON - Graph Library

Opened 11 years ago

Closed 11 years ago

#97 closed enhancement (fixed)

Reorganize fundamental header files and those of minor gadgets.

Reported by: Alpar Juttner Owned by: Peter Kovacs
Priority: major Milestone: LEMON 1.0 release
Component: core Version: hg main
Keywords: Cc:
Revision id:

Description (last modified by Alpar Juttner)

Currently, the following files are affected.

  • lemon/maps.h
  • lemon/graph_utils.h
  • lemon/assert.h
  • lemon/error.h
  • lemon/tolerance.h
  • lemon/assert.h
  • lemon/bits/invalid.h
  • lemon/bits/traits.h
  • lemon/bits/utility.h

Attachments (5)

89e004f571d9.patch (190.6 KB) - added by Balazs Dezso 11 years ago.
5b8f6f06687e.patch (190.9 KB) - added by Balazs Dezso 11 years ago.
219172956e81.patch (191.3 KB) - added by Balazs Dezso 11 years ago.
a5d8c039f218.patch (191.4 KB) - added by Balazs Dezso 11 years ago.
aebc0161f6e5.patch (642 bytes) - added by Peter Kovacs 11 years ago.

Download all attachments as: .zip

Change History (20)

comment:1 Changed 11 years ago by Alpar Juttner

Version: hg main

comment:2 Changed 11 years ago by Alpar Juttner

Description: modified (diff)
Summary: Reorganize header files of minor gadgets.Reorganize fundamental header files and those of minor gadgets.

comment:3 Changed 11 years ago by Alpar Juttner

Owner: changed from Alpar Juttner to Balazs Dezso

Changed 11 years ago by Balazs Dezso

Attachment: 89e004f571d9.patch added

comment:4 Changed 11 years ago by Balazs Dezso

Status: newassigned

The [89e004f571d9] patch makes the reorganization.

comment:5 in reply to:  4 Changed 11 years ago by Alpar Juttner

Replying to deba:

The [89e004f571d9] patch makes the reorganization.

The patch seems to be broken, I cannot import it with --exact.

Changed 11 years ago by Balazs Dezso

Attachment: 5b8f6f06687e.patch added

comment:6 Changed 11 years ago by Balazs Dezso

The previous patch was damaged, I have uploaded a new patch [5b8f6f06687e].

comment:7 in reply to:  6 ; Changed 11 years ago by Alpar Juttner

Replying to deba:

The previous patch was damaged, I have uploaded a new patch [5b8f6f06687e].

make check fails on [5b8f6f06687e]

Changed 11 years ago by Balazs Dezso

Attachment: 219172956e81.patch added

comment:8 in reply to:  7 ; Changed 11 years ago by Balazs Dezso

Replying to alpar:

Replying to deba:

The previous patch was damaged, I have uploaded a new patch [5b8f6f06687e].

make check fails on [5b8f6f06687e]

The [219172956e81] fixes the problem. The invalid.h is forgotten in my repository, therefore the make check did not show the bug for me. Now, the make distcheck compiles well.

comment:9 in reply to:  8 ; Changed 11 years ago by Alpar Juttner

Replying to deba:

The [219172956e81] fixes the problem.

It indeed fixes some problem, but not all. The make check still fails.

Changed 11 years ago by Balazs Dezso

Attachment: a5d8c039f218.patch added

comment:10 in reply to:  9 ; Changed 11 years ago by Balazs Dezso

Replying to alpar:

Replying to deba:

The [219172956e81] fixes the problem.

It indeed fixes some problem, but not all. The make check still fails.

The related problem was in the demo files, which was not enabled in repository. Now, I hope [a5d8c039f218] is correct.

comment:11 in reply to:  10 ; Changed 11 years ago by Alpar Juttner

Replying to deba:

The related problem was in the demo files, which was not enabled in repository. Now, I hope [a5d8c039f218] is correct.

Yes now it compiles fine. I like these changes, too. Still I would like to hear other's opinion.

I think, we need a short description at the doc of core.h saying that these file are automatically included by the graphs (make sure that it is indeed done so), therefore the users do not have to include this header directly.

After that we can close the ticket.

comment:12 in reply to:  11 Changed 11 years ago by Peter Kovacs

Replying to alpar:

Yes now it compiles fine. I like these changes, too. Still I would like to hear other's opinion.

I also like these changes. It seems to be simplier and more rational. It is good that no include file is needed for e.g. copying graphs apart form the graph type that is used. And maps can also be founded more easily.

Test files shouldn't be reorganized? It seems to be strange to have graph_utils_test.cc if do not have graph_utils.h any more.

comment:13 in reply to:  11 ; Changed 11 years ago by Alpar Juttner

Owner: changed from Balazs Dezso to Peter Kovacs
Status: assignednew

Replying to alpar:

I think, we need a short description at the doc of core.h saying that these file are automatically included by the graphs (make sure that it is indeed done so), therefore the users do not have to include this header directly.

Peter, could you do this doc improvements?

Changed 11 years ago by Peter Kovacs

Attachment: aebc0161f6e5.patch added

comment:14 in reply to:  13 ; Changed 11 years ago by Peter Kovacs

Replying to alpar:

Peter, could you do this doc improvements?

See [aebc0161f6e5].

comment:15 in reply to:  14 Changed 11 years ago by Alpar Juttner

Resolution: fixed
Status: newclosed

Replying to kpeter:

Replying to alpar:

Peter, could you do this doc improvements?

See [aebc0161f6e5].

Many thanks.

Note: See TracTickets for help on using tickets.