#110 closed enhancement (fixed)
graphToEps() improvements
| Reported by: | Peter Kovacs | Owned by: | Alpar Juttner |
|---|---|---|---|
| Priority: | major | Milestone: | LEMON 1.0 release |
| Component: | core | Version: | hg main |
| Keywords: | Cc: | ||
| Revision id: |
Description
- The members of
GraphToEpsshould be grouped in the documentation since there are so many functions. E.g. Node Options, Arc Options, Scaling etc. - The
GraphToEps::run()function should be revised. There are\todocommands recommending better epsilon and other improvements. - The demo file graph_to_eps_demo.cc should also be revised. It does not conforms to #27.
- It should read the graph and all the maps from an LGF file.
- It would be nice, if it created only one EPS file using options that can be set with command line parameters. However it would be difficult since the
graphToEps()function interface does not support incremental option setting as class interfaces do.
Attachments (2)
Change History (15)
Changed 16 years ago by
| Attachment: | graph_to_eps_improvements.patch added |
|---|
comment:2 Changed 16 years ago by
| Version: | → hg main |
|---|
comment:4 Changed 16 years ago by
| Milestone: | LEMON 1.0 release → Post 1.0 |
|---|
comment:5 follow-up: 6 Changed 16 years ago by
Replying to kpeter:
I uploaded a patch with small improvements.
Why did you remove the generation one of the example figures?
comment:6 follow-up: 7 Changed 16 years ago by
Replying to alpar:
Why did you remove the generation one of the example figures?
There are six examples now, and this one showed nothing new, nothing intresting compared to the others. So it seemed really unimportant, and I found it better to have not too many variants.
comment:7 Changed 16 years ago by
| Milestone: | Post 1.0 → LEMON 1.0 release |
|---|
Replying to kpeter:
There are six examples now, and this one showed nothing new, nothing intresting compared to the others. So it seemed really unimportant, and I found it better to have not too many variants.
Well, we all differ. For me, six is not really less than seven, and I also like that now missing figure. Actually, it shows something interesting: is shows that the curve of an arc varies depending on if it has an arrowhead or not.
(I put back this ticket into the 1.0 milestone, because the attached patch not only improves the demo but also contains significant cleanups for the GraphToEps? class itself.)
comment:8 Changed 16 years ago by
Replying to kpeter:
I uploaded a patch with small improvements.
I pushed a slightly modified version into the main branch (see [4e22275a2b52]). Namely, I made two modifications:
- The usage of 'a' for the
Arcs became more consistent - The seventh figure has been restored
Changed 16 years ago by
| Attachment: | graph_to_eps_demo_fix_542dd614cbb4.patch added |
|---|
comment:10 Changed 16 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:11 follow-up: 12 Changed 16 years ago by
comment:12 follow-up: 13 Changed 16 years ago by
Replying to kpeter:
Why was this ticket closed?
Point 2. is a duplication of #106, other improvements are suggested in #76, #85, #86. However point 1. and point 3. are mentioned only in this ticket, and they are not solved nor rejected.
- I was thinking of a good grouping of the options a long ago, but could not come up with a nice one (i.e. which is better than what we have now). You may come up with a solution, but I think the current doc is quite OK.
- The suggestion 3/1 is not really a reasonable requirement here, as there are different, very small and very specific inputs here. Of course, the LGF input would make sense if this demo were capable to draw more-or-less arbitrary inputs. Unfortunately, this is not the case.
- For suggestion 3/2, it was even pointed out by you the it isn't feasible. However there might be a solution to this in the long run, see ticket:86
Some improvements in the doc and in the demo file.