COIN-OR::LEMON - Graph Library

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#131 closed enhancement (fixed)

Add section writer for lgf tools

Reported by: Balazs Dezso Owned by: Balazs Dezso
Priority: major Milestone: LEMON 1.0 release
Component: core Version: hg main
Keywords: Cc:
Revision id:

Description

The lgf section writer is implemented in [5b77a093fd62] patch.

Attachments (2)

5b77a093fd62.patch (7.5 KB) - added by Balazs Dezso 11 years ago.
8fada33fc60a.patch (7.3 KB) - added by Balazs Dezso 11 years ago.

Download all attachments as: .zip

Change History (7)

Changed 11 years ago by Balazs Dezso

Attachment: 5b77a093fd62.patch added

comment:1 Changed 11 years ago by Alpar Juttner

Version: hg main

comment:2 in reply to:  description ; Changed 11 years ago by Alpar Juttner

Replying to deba:

The lgf section writer is implemented in [5b77a093fd62] patch.

In [5b77a093fd62], sectionLines() takes a std::string reference where it puts the output line and it has a bool return value for indicating that there is no more lines. (What about the last execution of sectionLines() will the returned std::string written to the output file?)

I would prefer a callback function with no parameter and an std::string return value, where the empty string would indicate that the section is finished.

What do you think of this?

Btw, I found a couple of typos is the doc.

Changed 11 years ago by Balazs Dezso

Attachment: 8fada33fc60a.patch added

comment:3 in reply to:  2 ; Changed 11 years ago by Balazs Dezso

Replying to alpar:

Replying to deba:

The lgf section writer is implemented in [5b77a093fd62] patch.

In [5b77a093fd62], sectionLines() takes a std::string reference where it puts the output line and it has a bool return value for indicating that there is no more lines. (What about the last execution of sectionLines() will the returned std::string written to the output file?)

I would prefer a callback function with no parameter and an std::string return value, where the empty string would indicate that the section is finished.

What do you think of this?

The patch [8fada33fc60a] contains the reworked section writer which follows your suggestion.

Btw, I found a couple of typos is the doc.

I tried to correct the documentation, I hope there are less typos than before.

comment:4 in reply to:  3 Changed 11 years ago by Alpar Juttner

Resolution: fixed
Status: newclosed

Replying to deba:

The patch [8fada33fc60a] contains the reworked section writer which follows your suggestion

It is now in the main branch.

comment:5 Changed 11 years ago by Alpar Juttner

Type: defectenhancement
Note: See TracTickets for help on using tickets.