COIN-OR::LEMON - Graph Library

Opened 11 years ago

Closed 11 years ago

#170 closed defect (fixed)

Critical bug fix in SmartDigraph::split()

Reported by: Peter Kovacs Owned by: Peter Kovacs
Priority: critical Milestone: LEMON 1.1 release
Component: core Version: hg main
Keywords: Cc:
Revision id: 9194a12c52e6

Description

The following code causes "Segmentation fault" error in the 1.0 release as well as in [9194a12c52e6].

  typedef lemon::SmartDigraph Digraph;
  DIGRAPH_TYPEDEFS(Digraph);

  Digraph G;
  Node n1 = G.addNode(), n2 = G.addNode(), n3 = G.addNode();
  Arc a1 = G.addArc(n1, n2), a2 = G.addArc(n2, n1),
      a3 = G.addArc(n2, n3), a4 = G.addArc(n2, n3);

  Node n4 = G.split(n2);

The attached patch [99dcd99637ba] fixes this critical bug on the top of [9194a12c52e6]. However I think it would also worth to merge into the 1.0 release branch.

Attachments (1)

smart_bugfix_99dcd99637ba.patch (712 bytes) - added by Peter Kovacs 11 years ago.

Download all attachments as: .zip

Change History (3)

Changed 11 years ago by Peter Kovacs

comment:1 in reply to:  description Changed 11 years ago by Alpar Juttner

Replying to kpeter:

The attached patch [99dcd99637ba] fixes this critical bug on the top of [9194a12c52e6]. However I think it would also worth to merge into the 1.0 release branch.

Bugfix changesets should be applied on the top of the "last common point" of the affected branches. See MakingRelease and the this post on the lemon-devel list for more details. (BTW these information should probably be put on the CommitGuides page instead).

So, I transplanted your patch on the top of [6dbd5184c6a9], the result is [00c8843d491d]. Then I merged it to both branch, of course.

comment:2 Changed 11 years ago by Alpar Juttner

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.