#186 closed enhancement (fixed)
Improvements for scripts
Reported by: | Peter Kovacs | Owned by: | Peter Kovacs |
---|---|---|---|
Priority: | major | Milestone: | LEMON 1.1 release |
Component: | tools | Version: | hg main |
Keywords: | Cc: | ||
Revision id: |
Description
See the attached patch.
Attachments (2)
Change History (7)
Changed 16 years ago by
Attachment: | 3af1acfc8c45.patch added |
---|
comment:1 follow-up: 2 Changed 16 years ago by
comment:2 follow-up: 3 Changed 16 years ago by
Replying to kpeter:
If
unify-sources.sh
is used as a hg hook (I always use it for my LEMON commits) it is sometimes important to be able to accept "errors", too, not only warnings. E.g. when the file you modify already contains "errors" (e.g. trailing spaces) and you do not want to make white-space changes.
And what about the other changes (in the migrate script)? Do we really want to change _graph to _digraph at all? This name is typically used for private variables. As far as I'm concerned, I prefer to use g
or graph
(and not d
or digraph
) for denoting the directed graphs, too.
comment:3 follow-up: 4 Changed 16 years ago by
Replying to alpar:
And what about the other changes (in the migrate script)? Do we really want to change _graph to _digraph at all? This name is typically used for private variables.
Yes. As a whole word _graph
is usually used for private variables. _Graph
is sometimes used as template parameter.
As far as I'm concerned, I prefer to use
g
orgraph
(and notd
ordigraph
) for denoting the directed graphs, too.
Then of course these changes shouldn't be applied. Consider to use [c5f010a5647a] instead.
Changed 16 years ago by
Attachment: | c5f010a5647a.patch added |
---|
comment:4 Changed 16 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Replying to kpeter:
Then of course these changes shouldn't be applied. Consider to use [c5f010a5647a] instead.
It is now in the main.
comment:5 Changed 16 years ago by
Component: | core → tools |
---|
If
unify-sources.sh
is used as a hg hook (I always use it for my LEMON commits) it is sometimes important to be able to accept "errors", too, not only warnings. E.g. when the file you modify already contains "errors" (e.g. trailing spaces) and you do not want to make white-space changes.