COIN-OR::LEMON - Graph Library

Opened 11 years ago

Closed 11 years ago

#193 closed defect (fixed)

Bug in skipSection() of lgf_reader.h

Reported by: Akos Ladanyi Owned by: Balazs Dezso
Priority: critical Milestone: LEMON 1.1 release
Component: core Version: hg main
Keywords: Cc:
Revision id: 62c1ed05e83f

Description

    void skipSection() {
      char c;
      while (readSuccess() && line >> c && c != '@') {
        readLine();
      }
      line.putback(c);
    }

Here line.putback() puts back an uninitialized variable in case readSuccess() returns false.

Attachments (1)

09e530504129.patch (1.3 KB) - added by Balazs Dezso 11 years ago.
Bug fix

Download all attachments as: .zip

Change History (4)

comment:1 Changed 11 years ago by Alpar Juttner

This bug seems to affect the lemon 1.0.1 version, too. So the bugfix should go on the top of e.g [62f9787c516c].

Changed 11 years ago by Balazs Dezso

Attachment: 09e530504129.patch added

Bug fix

comment:2 Changed 11 years ago by Balazs Dezso

Status: newassigned

The patch is uploaded.

comment:3 in reply to:  2 Changed 11 years ago by Alpar Juttner

Resolution: fixed
Status: assignedclosed

Replying to deba:

The patch is uploaded.

I re-parented the patch to the right place (see [33e9699c7d3a]) and merged to both branches.

Note: See TracTickets for help on using tickets.