COIN-OR::LEMON - Graph Library

Opened 10 years ago

Closed 10 years ago

#278 closed defect (fixed)

Superfluous HAVE_CONFIG_H

Reported by: Akos Ladanyi Owned by: Akos Ladanyi
Priority: minor Milestone: LEMON 1.1 release
Component: build system Version: hg main
Keywords: Cc:
Revision id:

Description

lp_test.cc and mip_test.cc use HAVE_CONFIG_H unnecessarily.

Attachments (1)

remove-have-config-h.patch (1.2 KB) - added by Akos Ladanyi 10 years ago.
d21b38647e53

Download all attachments as: .zip

Change History (5)

Changed 10 years ago by Akos Ladanyi

Attachment: remove-have-config-h.patch added

comment:1 Changed 10 years ago by Akos Ladanyi

Status: newassigned

Please apply the attached patch.

comment:2 Changed 10 years ago by Peter Kovacs

As far as I see this ticket partially reverts the changes of [d8ca76573eb3] in CMakeLists.txt

comment:3 in reply to:  2 Changed 10 years ago by Akos Ladanyi

Replying to kpeter:

As far as I see this ticket partially reverts the changes of [d8ca76573eb3] in CMakeLists.txt

Well, yes. [d8ca76573eb3] added ADD_DEFINITIONS(-DHAVE_CONFIG_H) because it was not present at the fork of the 1.0 branch. When merging this changeset to the head of the main branch in [20dac2104519] a duplicate ADD_DEFINITIONS(-DHAVE_CONFIG_H) ended up in CMakeLists.txt.

Anyway, the HAVE_CONFIG_H define is only required if one includes the top level config.h, and we never do that. Therefore it can be removed from everywhere.

comment:4 Changed 10 years ago by Peter Kovacs

Resolution: fixed
Status: assignedclosed

[d21b38647e53] went to the main branch.

Note: See TracTickets for help on using tickets.