COIN-OR::LEMON - Graph Library

Opened 10 years ago

Closed 10 years ago

#280 closed defect (fixed)

lemon/config.h gets distributed in the tarball

Reported by: Akos Ladanyi Owned by: Akos Ladanyi
Priority: major Milestone: LEMON 1.1 release
Component: build system Version: hg main
Keywords: Cc:
Revision id:

Description

lemon/config.h should be generated on the target system, and not distributed in the tarball.

Attachments (1)

config-h-nodist.patch (662 bytes) - added by Akos Ladanyi 10 years ago.
e90b4df7a035

Download all attachments as: .zip

Change History (9)

Changed 10 years ago by Akos Ladanyi

Attachment: config-h-nodist.patch added

comment:1 Changed 10 years ago by Akos Ladanyi

Status: newassigned

Please apply the attached patch.

comment:2 Changed 10 years ago by Peter Kovacs

This patch reverts the changes of [d8ca76573eb3] in Makefile.am, so that changeset wasn't good enough. Am I right?

comment:3 in reply to:  2 ; Changed 10 years ago by Akos Ladanyi

Replying to kpeter:

This patch reverts the changes of [d8ca76573eb3] in Makefile.am, so that changeset wasn't good enough. Am I right?

Yes. The problem was that [d8ca76573eb3] caused lemon/config.h to be installed and distributed too.

comment:4 in reply to:  3 Changed 10 years ago by Alpar Juttner

Replying to ladanyi:

Replying to kpeter:

This patch reverts the changes of [d8ca76573eb3] in Makefile.am, so that changeset wasn't good enough. Am I right?

Yes. The problem was that [d8ca76573eb3] caused lemon/config.h to be installed and distributed too.

Which may cause problem in rare situations, i.e. when you

  • make external build and
  • apply certain extra configure option like --with-coin=.

I don't do regular test for these situations together, that's why this problem remained hidden.

comment:5 Changed 10 years ago by Alpar Juttner

Shouldn't this be merged into both the main and to 1.0 branches?

comment:6 in reply to:  5 ; Changed 10 years ago by Akos Ladanyi

Replying to alpar:

Shouldn't this be merged into both the main and to 1.0 branches?

Yes, it should.

comment:7 in reply to:  6 Changed 10 years ago by Alpar Juttner

Replying to ladanyi:

Replying to alpar:

Shouldn't this be merged into both the main and to 1.0 branches?

Yes, it should.

Done, see [32fb28fc9d42]. It also fixes a stupid mistake in 'lemon/core.h'.

comment:8 Changed 10 years ago by Alpar Juttner

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.