COIN-OR::LEMON - Graph Library

Opened 9 years ago

Closed 9 years ago

#372 closed defect (fixed)

Critical bug in Elevator

Reported by: Peter Kovacs Owned by: Balazs Dezso
Priority: critical Milestone: LEMON 1.3 release
Component: core Version: hg main
Keywords: Cc:
Revision id:

Description

The attached code fails on the attached input file. It runs Preflow for all node pairs, but for one of them, it gets in an infinite loop. Using LinkedElevator, however, it works correctly, see the commented lines.

It seems that calling the deactivate() function of Elevator does not deactive the node, so it will be selected again as the highest active node.

Attachments (3)

preflow_bug.cpp (1.4 KB) - added by Peter Kovacs 9 years ago.
preflow_bug.lgf (6.7 KB) - added by Peter Kovacs 9 years ago.
59b68d0e4dbd.patch (2.4 KB) - added by Balazs Dezso 9 years ago.
Fix in preflow

Download all attachments as: .zip

Change History (5)

Changed 9 years ago by Peter Kovacs

Attachment: preflow_bug.cpp added

Changed 9 years ago by Peter Kovacs

Attachment: preflow_bug.lgf added

Changed 9 years ago by Balazs Dezso

Attachment: 59b68d0e4dbd.patch added

Fix in preflow

comment:1 Changed 9 years ago by Balazs Dezso

I have uploaded the patch [59b68d0e4dbd], which fixes the bug.

comment:2 in reply to:  1 Changed 9 years ago by Alpar Juttner

Resolution: fixed
Status: newclosed

Replying to deba:

I have uploaded the patch [59b68d0e4dbd], which fixes the bug.

Thanks. I rebased to the right place as [bb70ad62c95f] and merged into branches 1.1, 1.2 and main.

Note: See TracTickets for help on using tickets.