COIN-OR::LEMON - Graph Library

Opened 12 years ago

Closed 11 years ago

#61 closed task (fixed)

Port connectivity related algorithms

Reported by: Alpar Juttner Owned by: Balazs Dezso
Priority: blocker Milestone: LEMON 1.1 release
Component: core Version:
Keywords: Cc:
Revision id:

Description

The following file is affected.

  • lemon/topology.h

The name should possibly be changed.

Attachments (2)

581bec1d16d6.patch (48.3 KB) - added by Balazs Dezso 11 years ago.
Port topology.h
015e4ee9bae4.patch (12.7 KB) - added by Balazs Dezso 11 years ago.
Renames and a fix in stronglyConnectedCutArcs

Download all attachments as: .zip

Change History (16)

comment:1 Changed 12 years ago by Alpar Juttner

Milestone: LEMON 1.0 releasePost 1.0

comment:2 Changed 11 years ago by Peter Kovacs

Owner: changed from Alpar Juttner to Peter Kovacs
Status: newassigned

comment:3 Changed 11 years ago by Alpar Juttner

Priority: majorcritical

comment:4 Changed 11 years ago by Alpar Juttner

Priority: criticalblocker

It would be nice if someone took on the job of porting this, as it blocks the port of other tools, namely,

  • the Eulerian Walk related stuff (#65) and
  • therefore the lgf-gen tool (#45).

This latter one is a must-to-have in the next release.

comment:5 Changed 11 years ago by Balazs Dezso

Owner: changed from Peter Kovacs to Balazs Dezso
Status: assignednew

comment:6 Changed 11 years ago by Balazs Dezso

Status: newassigned

Changed 11 years ago by Balazs Dezso

Attachment: 581bec1d16d6.patch added

Port topology.h

comment:7 Changed 11 years ago by Balazs Dezso

The [581bec1d16d6] contains the port of topology.h, and it is renamed to connectivity.h. Maybe this file should be separated to two parts, the first for connectivty related algorithms, while the second for simple graph properties. Some extension would be nice, for example tests and some additional functions.

comment:8 in reply to:  7 Changed 11 years ago by Alpar Juttner

Replying to deba:

The [581bec1d16d6] contains the port of topology.h, and it is renamed to connectivity.h. Maybe this file should be separated to two parts, the first for connectivty related algorithms, while the second for simple graph properties. Some extension would be nice, for example tests and some additional functions.

A like the interfaces of the tools in connectivity.h. I don't think it should be split into two parts.

comment:9 Changed 11 years ago by Alpar Juttner

A version of the port (with changed commit log and reapplied on top of the main branch version of graph adaptors) are in the main, see [6ff53afe98b5].

comment:10 in reply to:  9 Changed 11 years ago by Balazs Dezso

Replying to alpar:

A version of the port (with changed commit log and reapplied on top of the main branch version of graph adaptors) are in the main, see [6ff53afe98b5].

Please, check the definition of the connectedness, I am quite nut sure that they are correct (for example biNodeConnected() ).

Changed 11 years ago by Balazs Dezso

Attachment: 015e4ee9bae4.patch added

Renames and a fix in stronglyConnectedCutArcs

comment:11 Changed 11 years ago by Balazs Dezso

I have uploaded a patch [015e4ee9bae4]. I tested almost every algorithm in this header with nauty. So I hope, I could find the only bug in stronglyConnectedCutArcs().

comment:12 in reply to:  11 Changed 11 years ago by Alpar Juttner

Replying to deba:

I have uploaded a patch [015e4ee9bae4]. I tested almost every algorithm in this header with nauty. So I hope, I could find the only bug in stronglyConnectedCutArcs().

I pushed it to the main branch, but with different commit log, see [9afe81e4c543].

comment:13 Changed 11 years ago by Peter Kovacs

Could we close this ticket? Is there any open questions?

comment:14 in reply to:  13 Changed 11 years ago by Alpar Juttner

Resolution: fixed
Status: assignedclosed

Replying to kpeter:

Could we close this ticket? Is there any open questions?

Probably there isn't. However there are two important follow-ups pending for review: #65, #45.

Note: See TracTickets for help on using tickets.