COIN-OR::LEMON - Graph Library

Opened 11 years ago

Closed 11 years ago

#174 closed enhancement (fixed)

Port the Elevator

Reported by: Alpar Juttner Owned by: Alpar Juttner
Priority: critical Milestone: LEMON 1.1 release
Component: core Version: hg main
Keywords: Cc:
Revision id:

Description (last modified by Alpar Juttner)

This ticket is a follow-up of #47.

The affected files are

  • lemon/elevator.h

Attachments (5)

fa7562ef5f8e.patch (28.5 KB) - added by Alpar Juttner 11 years ago.
Port of elevator
7951042b9e53.patch (3.1 KB) - added by Alpar Juttner 11 years ago.
Some fixes
elevator-1bab3a47be88-d916b8995e22-b04e431907bc-bd4154ce8486.bundle (6.5 KB) - added by Alpar Juttner 11 years ago.
bugfix_09acd23a35bd.patch (594 bytes) - added by Peter Kovacs 11 years ago.
doc_d21271cbdc09.patch (15.7 KB) - added by Peter Kovacs 11 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 11 years ago by Alpar Juttner

Description: modified (diff)
Status: newassigned

Changed 11 years ago by Alpar Juttner

Attachment: fa7562ef5f8e.patch added

Port of elevator

Changed 11 years ago by Alpar Juttner

Attachment: 7951042b9e53.patch added

Some fixes

comment:2 Changed 11 years ago by Alpar Juttner

Please review them, so that I can go forward with #175 and #176.

There is no test for the elevator classes, but I've checked it with a preliminary port of the Circulation class. (I think the test files for the Circulation and for the Preflow will sufficiently test the Elevator class, as well.

comment:3 Changed 11 years ago by Alpar Juttner

The attached bundle file contains a slightly modified version of the original port (only the commit log has changed) plus two more commits fixing some problem of the original elevator implementation (i.e. the Elevator class).

Changed 11 years ago by Peter Kovacs

Attachment: bugfix_09acd23a35bd.patch added

Changed 11 years ago by Peter Kovacs

Attachment: doc_d21271cbdc09.patch added

comment:4 in reply to:  3 ; Changed 11 years ago by Peter Kovacs

Replying to alpar:

The attached bundle file contains a slightly modified version of the original port (only the commit log has changed) plus two more commits fixing some problem of the original elevator implementation (i.e. the Elevator class).

[09acd23a35bd] fixes a bug that was made in [bd4154ce8486] (these two changesets could be joined together, since the latter one could not be compiled). [d21271cbdc09] contains doc improvements.

I thnik these changesets can be pushed into the main branch. However before we close this ticket, I think it would be important to extend the doc of these two classes with comments on the difference between them. E.g. we could note at each class the basic storage scheme and what operations are typically faster/slower than in the other one.

comment:5 in reply to:  4 Changed 11 years ago by Alpar Juttner

Replying to kpeter:

Many thanks for the reviewing the pathces. They went to the main, see [1bab3a47be88], [d916b8995e22], [61fbd77f0f44], [b04e431907bc] and [a8a22a96d495].

[09acd23a35bd] fixes a bug that was made in [bd4154ce8486] (these two changesets could be joined together,

I've done so.

I thnik these changesets can be pushed into the main branch. However before we close this ticket, I think it would be important to extend the doc of these two classes with comments on the difference between them. E.g. we could note at each class the basic storage scheme and what operations are typically faster/slower than in the other one.

Yes, it might be good, though this tool does not primarily targets the end users.

comment:6 Changed 11 years ago by Alpar Juttner

Priority: majorcritical

comment:7 in reply to:  4 Changed 11 years ago by Alpar Juttner

Resolution: fixed
Status: assignedclosed

Replying to kpeter:

However before we close this ticket, I think it would be important to extend the doc of these two classes with comments on the difference between them.

Instead, I've created a separete ticket for doc improvements, see #183.

Note: See TracTickets for help on using tickets.