Opened 17 years ago
Closed 17 years ago
#174 closed enhancement (fixed)
Port the Elevator
| Reported by: | Alpar Juttner | Owned by: | Alpar Juttner |
|---|---|---|---|
| Priority: | critical | Milestone: | LEMON 1.1 release |
| Component: | core | Version: | hg main |
| Keywords: | Cc: | ||
| Revision id: |
Description (last modified by )
Attachments (5)
Change History (12)
comment:1 Changed 17 years ago by
| Description: | modified (diff) |
|---|---|
| Status: | new → assigned |
Changed 17 years ago by
| Attachment: | fa7562ef5f8e.patch added |
|---|
comment:2 Changed 17 years ago by
- [fa7562ef5f8e] ports the Elevators
- [7951042b9e53] renames
markToBottom()todirtyTopButOne()plus improves the doc at some places.
Please review them, so that I can go forward with #175 and #176.
There is no test for the elevator classes, but I've checked it with a preliminary port of the Circulation class. (I think the test files for the Circulation and for the Preflow will sufficiently test the Elevator class, as well.
Changed 17 years ago by
| Attachment: | elevator-1bab3a47be88-d916b8995e22-b04e431907bc-bd4154ce8486.bundle added |
|---|
comment:3 follow-up: 4 Changed 17 years ago by
The attached bundle file contains a slightly modified version of the original port (only the commit log has changed) plus two more commits fixing some problem of the original elevator implementation (i.e. the Elevator class).
Changed 17 years ago by
| Attachment: | bugfix_09acd23a35bd.patch added |
|---|
Changed 17 years ago by
| Attachment: | doc_d21271cbdc09.patch added |
|---|
comment:4 follow-ups: 5 7 Changed 17 years ago by
Replying to alpar:
The attached bundle file contains a slightly modified version of the original port (only the commit log has changed) plus two more commits fixing some problem of the original elevator implementation (i.e. the Elevator class).
[09acd23a35bd] fixes a bug that was made in [bd4154ce8486] (these two changesets could be joined together, since the latter one could not be compiled). [d21271cbdc09] contains doc improvements.
I thnik these changesets can be pushed into the main branch. However before we close this ticket, I think it would be important to extend the doc of these two classes with comments on the difference between them. E.g. we could note at each class the basic storage scheme and what operations are typically faster/slower than in the other one.
comment:5 Changed 17 years ago by
Replying to kpeter:
Many thanks for the reviewing the pathces. They went to the main, see [1bab3a47be88], [d916b8995e22], [61fbd77f0f44], [b04e431907bc] and [a8a22a96d495].
[09acd23a35bd] fixes a bug that was made in [bd4154ce8486] (these two changesets could be joined together,
I've done so.
I thnik these changesets can be pushed into the main branch. However before we close this ticket, I think it would be important to extend the doc of these two classes with comments on the difference between them. E.g. we could note at each class the basic storage scheme and what operations are typically faster/slower than in the other one.
Yes, it might be good, though this tool does not primarily targets the end users.
comment:6 Changed 17 years ago by
| Priority: | major → critical |
|---|
comment:7 Changed 17 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Port of elevator