COIN-OR::LEMON - Graph Library

Opened 10 years ago

Closed 10 years ago

#175 closed enhancement (fixed)

Port the feasible circulation algorithm

Reported by: Alpar Juttner Owned by: Alpar Juttner
Priority: critical Milestone: LEMON 1.1 release
Component: core Version: hg main
Keywords: Cc:
Revision id:

Description (last modified by Alpar Juttner)

This ticket is a follow-up of #47.

The affected files are

  • lemon/circulation.h

This ticket depends on #174.

Attachments (4)

circ-5a7dbeaed70e-a26cb20c4c5f-ef7c87032593.bundle (7.8 KB) - added by Alpar Juttner 10 years ago.
circ_b4fbf36feb57.patch (20.9 KB) - added by Peter Kovacs 10 years ago.
circ-test_2a7704daaf11.patch (6.0 KB) - added by Peter Kovacs 10 years ago.
circ-test_63c4cc72d7eb.patch (6.0 KB) - added by Peter Kovacs 10 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 10 years ago by Alpar Juttner

Description: modified (diff)
Status: newassigned

Changed 10 years ago by Alpar Juttner

comment:2 Changed 10 years ago by Alpar Juttner

The attached bundle file ports the Circulation class. Namely,

comment:3 Changed 10 years ago by Alpar Juttner

Priority: majorcritical

Changed 10 years ago by Peter Kovacs

Attachment: circ_b4fbf36feb57.patch added

Changed 10 years ago by Peter Kovacs

comment:4 Changed 10 years ago by Peter Kovacs

I attached two changesets containing improvements. See [b4fbf36feb57] and [2a7704daaf11].

Make check fails on [ef7c87032593] because of a missing #include. [2a7704daaf11] also fixes this.

comment:5 Changed 10 years ago by Peter Kovacs

I have two questions:

  1. What concept do we want to follow about "checker funtions" like the ones in Circulation? Most of the algorithms do not contain such functions, only the test files of them. Should such checker function be placed into the algorithm classes or into the test files? An end-user typically don't need such checking since the correctness of the algorithms should be supposed. (Among others that's why we have test files.)
  1. How should a test file read the input graph? From a separate file or from a constant char array? See e.g. preflow_test.cc and circulation_test.cc.

comment:6 in reply to:  4 ; Changed 10 years ago by Alpar Juttner

Replying to kpeter:

Make check fails on [ef7c87032593] because of a missing #include. [2a7704daaf11] also fixes this.

Very strange. I'm pretty sure I tried to compile it. (If not, then it is actually quite impressive that the missing include is the only error I made, isn't it? :) )

Btw, why do we need to include the lemon/elevator.h? Isn't is included by lemon/circulation.h?

comment:7 in reply to:  6 Changed 10 years ago by Peter Kovacs

Replying to alpar:

Btw, why do we need to include the lemon/elevator.h? Isn't is included by lemon/circulation.h?

Yes, this include is unnecessary. I just copied the #include commands from preflow_test.cc which also contains this unnecessary line.

You can remove it from both test files.

Changed 10 years ago by Peter Kovacs

comment:8 Changed 10 years ago by Peter Kovacs

For this test file you can use [63c4cc72d7eb] isntead of the former changeset.

comment:9 Changed 10 years ago by Alpar Juttner

Resolution: fixed
Status: assignedclosed

A bit reorganized version of these changes are in the main now, see [5a7dbeaed70e], [fa341dd6ab23], [26fd85a3087e], [235be9d4b6ab] and [940587667b47].

Note: See TracTickets for help on using tickets.