COIN-OR::LEMON - Graph Library

Opened 10 months ago

Closed 9 months ago

#609 closed defect (fixed)

Missing break statement in dimacs-solver.cc

Reported by: Peter Kovacs Owned by: Peter Kovacs
Priority: minor Milestone: LEMON 1.4 release
Component: core Version: hg main
Keywords: Cc:
Revision id:

Description (last modified by Peter Kovacs)

See the attached patch.

Compiling with g++ 7.2.0 showed 3 warnings about falling through for case blocks in dimacs-solver.cc. 2 out of 3 was deliberate, so I added a comment (which eliminates the warning), but the third one was a bug, so it was fixed.

Attachments (2)

609-e9b540c888f3.patch (971 bytes) - added by Peter Kovacs 10 months ago.
609-ad22262328b3.patch (969 bytes) - added by Peter Kovacs 9 months ago.

Download all attachments as: .zip

Change History (8)

Changed 10 months ago by Peter Kovacs

Attachment: 609-e9b540c888f3.patch added

comment:1 Changed 10 months ago by Peter Kovacs

Description: modified (diff)

comment:2 Changed 10 months ago by Peter Kovacs

Description: modified (diff)

comment:3 Changed 9 months ago by Alpar Juttner

I cannot apply 609-e9b540c888f3.patch with --exact, mercurial says this patch is corrupt.

Changed 9 months ago by Peter Kovacs

Attachment: 609-ad22262328b3.patch added

comment:4 Changed 9 months ago by Peter Kovacs

I recreated the patch as [ad22262328b3], it should be OK.

comment:5 Changed 9 months ago by Alpar Juttner

It works now. Thanks.

comment:6 Changed 9 months ago by Alpar Juttner

Resolution: fixed
Status: newclosed

The bugfix has been merged to the main branch, as well as into 1.3.

Note: See TracTickets for help on using tickets.