MaxWeightedPerfectMatching re-run crash

[Ben Strasser]

Hello,

when calling run a second time after changing the referenced graph and weights the matching function may crash.

Graph g;
Graph::EdgeMap<int>w(g);
// fill g and w
MaxWeightedPerfectMatching<Graph> mm(g, w);
mm.run();
// modify g and w
mm.run();
for(EdgeIt i(g);i!=INVALID; ++i)
  mm.matching(i); // This can crash here

Version is the 1.1.2 Download from the main site.

[Alpar Juttner]

Thanks for reporting this problem. In your orig e-mail you were talking about changing w only. Can you confirm that the problem can also appear when you don't touch the graph but only the weights?

[Balazs Dezso]

Fix multiple execution

[Balazs Dezso]

Some of the data structures were not cleared between executions. It is fixed already in [4ac8f688b6fc].

[Ben Strasser]

Can you confirm that the problem can also appear when you don't touch the graph but only the weights?

No

[Alpar Juttner]

Replying to deba:

Some of the data structures were not cleared between executions. It is fixed already in [4ac8f688b6fc].

Thanks. The bugfix was rebased as [5b926cc36a4b], then it has been merged to both 1.1 and the default branches. So, it will be included in the soon-to-be-come 1.2 release and in release 1.1.3 (which will be released a bit later, probably along with the first bugfix release of 1.2).

The jumpstart matching initialization (see #314) has also been merged into the main branch. Could you check if it also works correctly in case of the multiple execution?

Some specific test cases for the multiple execution could also be nice.

[Balazs Dezso]

Fractional matching and jumpstart

[Balazs Dezso]

The patch [dd9ba625e801] solves the same problem in fractional matching algorithms and in jumpstart initialization.

[Alpar Juttner]

Replying to deba:

The patch [dd9ba625e801] solves the same problem in fractional matching algorithms and in jumpstart initialization.

It went to the main branch with changes log msg, see [7f6e2bd76654]